superreview granted: [Bug 295729] crash after Firefox or Thunderbird checks for Extension/Theme updates - Trunk FF11a1 TB11a1 [@ firefox-bin][@ thunderbird-bin] : [Attachment 187084] Null-check XPCon

Benjamin Smedberg  [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>
has granted Benjamin Smedberg  [:bs] (formerly bsmedberg@covad.net)
<benjamin@smedbergs.us>'s request for superreview:
Bug 295729: crash after Firefox or Thunderbird checks for Extension/Theme
updates - Trunk FF11a1 TB11a1 [@ firefox-bin][@ thunderbird-bin]
https://bugzilla.mozilla.org/show_bug.cgi?id=295729

Attachment 187084: Null-check XPConnect() directly, rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=187084&action=edit

------- Additional Comments from Benjamin Smedberg  [:bs] (formerly
bsmedberg@covad.net) <benjamin@smedbergs.us>
Got r+sr from jst, a=drivers
0
bugzilla
6/23/2005 1:04:18 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
663 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:

superreview granted: [Bug 306959] Crash on first startup after running downrev Firefox/Thunderbird version crash [@ nsXBLBinding::AllowScripts][@ PresShell::Destroy] : [Attachment 207086] Check for n
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 306959: Crash on first startup after running downrev Firefox/Thunderbird version crash [@ nsXBLBinding::AllowScripts][@ PresShell::Destroy] https://bugzilla.mozilla.org/show_bug.cgi?id=306959 Attachment 207086: Check for null event queue service https://bugzilla.mozilla.org/attachment.cgi?id=207086&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> I'm OK wi...

superreview requested: [Bug 306959] Crash on first startup after running downrev Firefox/Thunderbird version crash [@ nsXBLBinding::AllowScripts][@ PresShell::Destroy] : [Attachment 207086] Check for
Mark Mentovai <mark@moxienet.com> has asked Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 306959: Crash on first startup after running downrev Firefox/Thunderbird version crash [@ nsXBLBinding::AllowScripts][@ PresShell::Destroy] https://bugzilla.mozilla.org/show_bug.cgi?id=306959 Attachment 207086: Check for null event queue service https://bugzilla.mozilla.org/attachment.cgi?id=207086&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> The event queue service is gone when destroying the presshe...

superreview granted: [Bug 344121] Restart after extension update check fails [@ nsContentUtils::IsCallerChrome] : [Attachment 228834] fix for IsCallerChrome() to check for null sSecurityManager
Johnny Stenback <jst@mozilla.org> has granted superreview: Bug 344121: Restart after extension update check fails [@ nsContentUtils::IsCallerChrome] https://bugzilla.mozilla.org/show_bug.cgi?id=344121 Attachment 228834: fix for IsCallerChrome() to check for null sSecurityManager https://bugzilla.mozilla.org/attachment.cgi?id=228834&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst for this change for the branch if we chose to take this as a spot-fix for this problem on the branch. ...

superreview granted: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 220339] Patch that uses MOZ_APP_D
Mark Mentovai <mark@moxienet.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 220339: Patch that uses MOZ_APP_DISPLAYNAME for executable https://bugzilla.mozilla.org/attachment.cgi?id=220339&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> This comment isn't necessary: +# Executable should match ...

superreview granted: [Bug 256631] TB07x crash exiting Thunderbird [@ nsMimeHtmlDisplayEmitter::GenerateDateString ] : [Attachment 163920] check for failure
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 256631: TB07x crash exiting Thunderbird [@ nsMimeHtmlDisplayEmitter::GenerateDateString ] https://bugzilla.mozilla.org/show_bug.cgi?id=256631 Attachment 163920: check for failure https://bugzilla.mozilla.org/attachment.cgi?id=163920&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I still think the caller needs to handle failure... ...

superreview granted: [Bug 234331] Mozilla crashes if document.getBoxObjectFor() is called with an undefined parameter : [Attachment 141408] Null-checks
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 234331: Mozilla crashes if document.getBoxObjectFor() is called with an undefined parameter http://bugzilla.mozilla.org/show_bug.cgi?id=234331 Attachment 141408: Null-checks http://bugzilla.mozilla.org/attachment.cgi?id=141408&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> r+sr=jst ...

superreview granted: [Bug 282796] update rv and Firefox version numbers (as seen from About > Help) : [Attachment 174758] thunderbird patch
Daniel Veditz <dveditz@cruzio.com> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 282796: update rv and Firefox version numbers (as seen from About > Help) https://bugzilla.mozilla.org/show_bug.cgi?id=282796 Attachment 174758: thunderbird patch https://bugzilla.mozilla.org/attachment.cgi?id=174758&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> sr/a=dveditz Where does the Gecko rv: get bumped? ...

superreview granted: [Bug 241966] Mozilla/Firefox/Thunderbird can't launch each other : [Attachment 147392] Cleanup that Javier suggested
Michael Kaply (IBM) <mkaply@us.ibm.com> has granted Michael Kaply (IBM) <mkaply@us.ibm.com>'s request for superreview: Bug 241966: Mozilla/Firefox/Thunderbird can't launch each other http://bugzilla.mozilla.org/show_bug.cgi?id=241966 Attachment 147392: Cleanup that Javier suggested http://bugzilla.mozilla.org/attachment.cgi?id=147392&action=edit ------- Additional Comments from Michael Kaply (IBM) <mkaply@us.ibm.com> sr=blizzard (platform specific) a=mkaply (OS/2 only) We need this for long lived TB and FF ...

superreview granted: [Bug 335068] Firefox and Thunderbird windows grouped under "Mozilla" rather than in separate groups : [Attachment 228652] patch3
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 335068: Firefox and Thunderbird windows grouped under "Mozilla" rather than in separate groups https://bugzilla.mozilla.org/show_bug.cgi?id=335068 Attachment 228652: patch3 https://bugzilla.mozilla.org/attachment.cgi?id=228652&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Thanks! ...

superreview granted: [Bug 314187] NSS PK11 Module: certificates with unknown AlgorythmIdentifiers make ThunderBird crashed : [Attachment 237013] check for returned OID
Julien Pierre <julien.pierre.bugs@sun.com> has granted Alexei Volkov <alexei.volkov.bugs@sun.com>'s request for superreview: Bug 314187: NSS PK11 Module: certificates with unknown AlgorythmIdentifiers make ThunderBird crashed https://bugzilla.mozilla.org/show_bug.cgi?id=314187 Attachment 237013: check for returned OID https://bugzilla.mozilla.org/attachment.cgi?id=237013&action=edit ...

superreview granted: [Bug 264326] current mozilla/firefox/thunderbird does not work reliable on s390(x) : [Attachment 162060] xpcom fixes for s390(x)
Mike Shaver <shaver@mozilla.org> has granted Mike Shaver <shaver@mozilla.org>'s request for superreview: Bug 264326: current mozilla/firefox/thunderbird does not work reliable on s390(x) https://bugzilla.mozilla.org/show_bug.cgi?id=264326 Attachment 162060: xpcom fixes for s390(x) https://bugzilla.mozilla.org/attachment.cgi?id=162060&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> Yeah, looks safe enough, and if you're running with it on s390, who am I to argue? Let's get it on the stable/release branches too. ...

superreview granted: [Bug 225885] nsPresShell::DoCopy does not work if the focus is outside the window : [Attachment 135708] update for mozilla head and remove unnecessary NULL check
Brian Ryner <bryner@brianryner.com> has granted marco@gnome.org's request for superreview: Bug 225885: nsPresShell::DoCopy does not work if the focus is outside the window http://bugzilla.mozilla.org/show_bug.cgi?id=225885 Attachment 135708: update for mozilla head and remove unnecessary NULL check http://bugzilla.mozilla.org/attachment.cgi?id=135708&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> Looks good, modulo any lurking bugs with the focus state being out of sync. ...

superreview granted: [Bug 265135] Can't install extensions from update.mozilla.org (whitelist) : [Attachment 163106] Fix null-referrer crash
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 265135: Can't install extensions from update.mozilla.org (whitelist) https://bugzilla.mozilla.org/show_bug.cgi?id=265135 Attachment 163106: Fix null-referrer crash https://bugzilla.mozilla.org/attachment.cgi?id=163106&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over sr/a ...

superreview granted: [Bug 361150] Message aging with grouped views can crash [@thunderbird-bin + 0x402 (0xb7f13402) 41762308] : [Attachment 247232] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 361150: Message aging with grouped views can crash [@thunderbird-bin + 0x402 (0xb7f13402) 41762308] https://bugzilla.mozilla.org/show_bug.cgi?id=361150 Attachment 247232: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=247232&action=edit ...

superreview granted: [Bug 308727] FireFox 1.5 with kpkcs11 (kerberos pki) crashes loading https:// [@ 0x000a0027
Julien Pierre <julien.pierre.bugs@sun.com> has granted Robert Relyea <rrelyea@redhat.com>'s request for superreview: Bug 308727: FireFox 1.5 with kpkcs11 (kerberos pki) crashes loading https:// [@ 0x000a0027 - SECMOD_WaitForAnyTokenEvent] https://bugzilla.mozilla.org/show_bug.cgi?id=308727 Attachment 196811: Updated patch with review comments. https://bugzilla.mozilla.org/attachment.cgi?id=196811&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch is fine. The test for cryptokiVersion.major isn't necessary...

Web resources about - superreview granted: [Bug 295729] crash after Firefox or Thunderbird checks for Extension/Theme updates - Trunk FF11a1 TB11a1 [@ firefox-bin][@ thunderbird-bin] : [Attachment 187084] Null-check XPCon - netscape.mozilla.reviewers

Resources last updated: 1/11/2016 5:52:24 AM