superreview granted: [Bug 294717] crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> : [Attachment 187320] Patch rev. 1

David Baron <dbaron@mozillafoundation.org> has granted Mats Palmgren
<mats.palmgren@bredband.net>'s request for superreview:
Bug 294717: crash in [@ nsFieldSetFrame::SetInitialChildList] printing
<fieldset><legend>
https://bugzilla.mozilla.org/show_bug.cgi?id=294717

Attachment 187320: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=187320&action=edit
0
bugzilla
6/27/2005 11:32:11 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
221 Views

Similar Articles

[PageSpeed] 51

Reply:

Similar Artilces:

superreview requested: [Bug 294717] crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> : [Attachment 187320] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 294717: crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> https://bugzilla.mozilla.org/show_bug.cgi?id=294717 Attachment 187320: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187320&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Fixes the crash (last hunk, in |CreateContinuingFrame|), also fixes |GetAbsoluteContainingBlock| which would return the lege...

superreview granted: [Bug 344850] Tabbing from <radio> or <textbox> with tabindex fails : [Attachment 231513] Patch rev. 1
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 344850: Tabbing from <radio> or <textbox> with tabindex fails https://bugzilla.mozilla.org/show_bug.cgi?id=344850 Attachment 231513: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=231513&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> I can't give this code good review, but generally I feel it's better to do what one can rather than block things indefi...

superreview granted: [Bug 340564] Print/Print Preview does not print text in <input text> or <textarea> : [Attachment 243735] Patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340564: Print/Print Preview does not print text in <input text> or <textarea> https://bugzilla.mozilla.org/show_bug.cgi?id=340564 Attachment 243735: Patch https://bugzilla.mozilla.org/attachment.cgi?id=243735&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> thanks! the new textframe kills all this horrible code. ...

superreview requested: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview cancelled: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview granted: [Bug 244569] Incorrect font style after <p></font> inside <table> inside <font> : [Attachment 204389] Potential patch
Johnny Stenback <jst@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 244569: Incorrect font style after <p></font> inside <table> inside <font> https://bugzilla.mozilla.org/show_bug.cgi?id=244569 Attachment 204389: Potential patch https://bugzilla.mozilla.org/attachment.cgi?id=204389&action=edit ...

superreview granted: [Bug 204615] Editor hangs when pasting a list fragment <LI> in <DL>, <UL> or <OL> : [Attachment 171288] patch v1
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 204615: Editor hangs when pasting a list fragment <LI> in <DL>, <UL> or <OL> https://bugzilla.mozilla.org/show_bug.cgi?id=204615 Attachment 171288: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=171288&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> sr=dveditz. Really should have an editor peer review, but I guess this is trivial enough. ...

superreview cancelled: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1 #2
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview granted: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187358] Patch rev. 1
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187358: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187358&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> You certainly should be able to drag content without frames. But all this code is trying to do it turn off ...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview granted: [Bug 238989] whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags : [Attachment 145302] This should fix it
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 238989: whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags http://bugzilla.mozilla.org/show_bug.cgi?id=238989 Attachment 145302: This should fix it http://bugzilla.mozilla.org/attachment.cgi?id=145302&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> Fine by me, although I don't really understand why we'd want kOmitWS at all. ...

superreview granted: [Bug 293224] [FIX]Matrix from getScreenCTM should be to initial viewport space : [Attachment 194961] patch
T Rowley (IBM) <tor@acm.org> has granted Jonathan Watt <jonathan.watt@strath.ac.uk>'s request for superreview: Bug 293224: [FIX]Matrix from getScreenCTM should be to initial viewport space https://bugzilla.mozilla.org/show_bug.cgi?id=293224 Attachment 194961: patch - include currentScale and Translate for <svg><svg></svg></svg> https://bugzilla.mozilla.org/attachment.cgi?id=194961&action=edit ...

Web resources about - superreview granted: [Bug 294717] crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> : [Attachment 187320] Patch rev. 1 - netscape.mozilla.reviewers

Resources last updated: 12/30/2015 11:51:03 PM