superreview granted: [Bug 293407] Canvas frame uses wrong frame type : [Attachment 182997] fix for frame type, memory leaks, default size

Boris Zbarsky <bzbarsky@mit.edu> has granted vladimir@pobox.com's request for
superreview:
Bug 293407: Canvas frame uses wrong frame type
https://bugzilla.mozilla.org/show_bug.cgi?id=293407

Attachment 182997: fix for frame type, memory leaks, default size
https://bugzilla.mozilla.org/attachment.cgi?id=182997&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>Index: content/canvas/public/nsICanvasRenderingContextInternal.h

>+  NS_IMETHOD SetCanvasElement(nsIDOMHTMLCanvasElement* aParentCanvas) = 0;

Document that this does NOT hold a ref.

> 
>   NS_IMETHOD SetTargetImageFrame(gfxIImageFrame* aImageFrame) = 0;
>+

No need for that whitespace change.

>Index: content/canvas/src/nsCanvasRenderingContext2D.cpp
>+    // the canvas element informs us when its going away,
>+    // so these are not nsCOMPtrs
>+    nsIDOMHTMLCanvasElement* mDOMCanvasElement;
>+    nsICanvasElement* mCanvasElement;

The constructor should set these to null, I would think.

>+nsCanvasRenderingContext2D::SetCanvasElement(nsIDOMHTMLCanvasElement*
aCanvasElement)

>+    if (mDOMCanvasElement) {
>+	  if (NS_SUCCEEDED (CallQueryInterface(mDOMCanvasElement,
&mCanvasElement))) {
>+	      // don't hold a ref to this!
>+	      NS_RELEASE(mCanvasElement);

NS_RELEASE sets to null.  You'd want to be calling Release() by hand here.

r+sr=bzbarsky with that, assuming apple does the 150px height thing.
0
bugzilla
5/9/2005 5:55:45 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
486 Views

Similar Articles

[PageSpeed] 45

Reply:

Similar Artilces:

superreview requested: [Bug 293407] Canvas frame uses wrong frame type : [Attachment 182997] fix for frame type, memory leaks, default size
vladimir@pobox.com has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 293407: Canvas frame uses wrong frame type https://bugzilla.mozilla.org/show_bug.cgi?id=293407 Attachment 182997: fix for frame type, memory leaks, default size https://bugzilla.mozilla.org/attachment.cgi?id=182997&action=edit ------- Additional Comments from vladimir@pobox.com This patch fixes the layout type issue, also fixes bug 293306 (canvas leaks lots of memory) and bug 293225 (default height of canvas should be 150). Also deletes a bunch of obsolete files from our previous <canv...

superreview granted: [Bug 338012] Simplify stop frame lookup : [Attachment 222050] look at frame type instead of QI
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 338012: Simplify stop frame lookup https://bugzilla.mozilla.org/show_bug.cgi?id=338012 Attachment 222050: look at frame type instead of QI https://bugzilla.mozilla.org/attachment.cgi?id=222050&action=edit ...

superreview granted: [Bug 255881] REGRESSION: frames and iframes not tabbable : [Attachment 156349] Better fix: make default tabIndex 0 for frame/iframe
Brian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 255881: REGRESSION: frames and iframes not tabbable http://bugzilla.mozilla.org/show_bug.cgi?id=255881 Attachment 156349: Better fix: make default tabIndex 0 for frame/iframe http://bugzilla.mozilla.org/attachment.cgi?id=156349&action=edit ...

superreview granted: [Bug 307616] <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" : [Attachment 207080] patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 307616: <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" https://bugzilla.mozilla.org/show_bug.cgi?id=307616 Attachment 207080: patch https://bugzilla.mozilla.org/attachment.cgi?id=207080&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> Yep...

superreview granted: [Bug 185824] Type-ahead find fails with frames : [Attachment 157362] 1) Don't prefer first visible if frame/iframe already focused, 2) Make sure if search result in new doc, the
Johnny Stenback <jst@mozilla.jstenback.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 185824: Type-ahead find fails with frames http://bugzilla.mozilla.org/show_bug.cgi?id=185824 Attachment 157362: 1) Don't prefer first visible if frame/iframe already focused, 2) Make sure if search result in new doc, the new doc gets focused, 3) Some null checks for bug 255002 http://bugzilla.mozilla.org/attachment.cgi?id=157362&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=js...

superreview granted: [Bug 317948] [FIX]Possible to readd frames to frame map after they've been removed : [Attachment 204298] Fix
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 317948: [FIX]Possible to readd frames to frame map after they've been removed https://bugzilla.mozilla.org/show_bug.cgi?id=317948 Attachment 204298: Fix https://bugzilla.mozilla.org/attachment.cgi?id=204298&action=edit ...

superreview granted: [Bug 335419] [FIX]nsHTMLButtonControlFrame should have a frame type : [Attachment 219783] Patch
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 335419: [FIX]nsHTMLButtonControlFrame should have a frame type https://bugzilla.mozilla.org/show_bug.cgi?id=335419 Attachment 219783: Patch https://bugzilla.mozilla.org/attachment.cgi?id=219783&action=edit ...

superreview granted: [Bug 341257] clipPath position does not update when used in Javascript animation : [Attachment 227429] switch frame type check
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted T Rowley (IBM) <tor@acm.org>'s request for superreview: Bug 341257: clipPath position does not update when used in Javascript animation https://bugzilla.mozilla.org/show_bug.cgi?id=341257 Attachment 227429: switch frame type check https://bugzilla.mozilla.org/attachment.cgi?id=227429&action=edit ...

superreview granted: [Bug 230173] Mozilla use 15 point size font for characters with style {font-size:14px;} : [Attachment 138463] use float type for mPointSize
Christopher Blizzard <blizzard@mozilla.org> has granted Christopher Blizzard <blizzard@mozilla.org>'s request for superreview: Bug 230173: Mozilla use 15 point size font for characters with style {font-size:14px;} http://bugzilla.mozilla.org/show_bug.cgi?id=230173 Attachment 138463: use float type for mPointSize http://bugzilla.mozilla.org/attachment.cgi?id=138463&action=edit ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 318566] Fix memory leaks
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocat= ed arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=3D431414 Attachment 318566: Fix memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=3D318566&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ // Ensure any old data is freed if necessary.=0D >+ if (mSearchAttrs) {=0D ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 319371] Fix memory leaks v2
Mark Banner <bugzilla@standard8.plus.com> has granted superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=431414 Attachment 319371: Fix memory leaks v2 https://bugzilla.mozilla.org/attachment.cgi?id=319371&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Fixes Neil's comments, carrying forward his sr. ...

superreview granted: [Bug 265367] [FIX]Frame construction tries to construct kids of leaf frames : [Attachment 182795] Patch
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 265367: [FIX]Frame construction tries to construct kids of leaf frames https://bugzilla.mozilla.org/show_bug.cgi?id=265367 Attachment 182795: Patch https://bugzilla.mozilla.org/attachment.cgi?id=182795&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> Actually, never mind that last assertion comment. r+sr=dbaron ...

superreview requested: [Bug 255881] REGRESSION: frames and iframes not tabbable : [Attachment 156349] Better fix: make default tabIndex 0 for frame/iframe
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 255881: REGRESSION: frames and iframes not tabbable http://bugzilla.mozilla.org/show_bug.cgi?id=255881 Attachment 156349: Better fix: make default tabIndex 0 for frame/iframe http://bugzilla.mozilla.org/attachment.cgi?id=156349&action=edit ...

superreview granted: [Bug 222191] can't set frame location if frame name is "sidebar" : [Attachment 135975] This fixes the problem
Brendan Eich <brendan@mozilla.org> has granted Christopher A. Aillon <caillon@aillon.org>'s request for superreview: Bug 222191: can't set frame location if frame name is "sidebar" http://bugzilla.mozilla.org/show_bug.cgi?id=222191 Attachment 135975: This fixes the problem http://bugzilla.mozilla.org/attachment.cgi?id=135975&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> r=me with the sSidebar_id zappage. /be ...

Web resources about - superreview granted: [Bug 293407] Canvas frame uses wrong frame type : [Attachment 182997] fix for frame type, memory leaks, default size - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/28/2015 3:59:00 PM