superreview granted: [Bug 292355] Plugins send document's base URI as referrer, instead of document's URI : [Attachment 182225] patch

Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi)
<cbiesinger@gmx.at>'s request for superreview:
Bug 292355: Plugins send document's base URI as referrer, instead of document's
URI
https://bugzilla.mozilla.org/show_bug.cgi?id=292355

Attachment 182225: patch
https://bugzilla.mozilla.org/attachment.cgi?id=182225&action=edit
0
bugzilla
4/30/2005 4:09:57 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
537 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview requested: [Bug 292355] Plugins send document's base URI as referrer, instead of document's URI : [Attachment 182225] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 292355: Plugins send document's base URI as referrer, instead of document's URI https://bugzilla.mozilla.org/show_bug.cgi?id=292355 Attachment 182225: patch https://bugzilla.mozilla.org/attachment.cgi?id=182225&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> only the second hunk of the patch is needed to fix this bug, the rest is removing some unnecessary casts and indentation fixing. I'd attac...

superreview granted: [Bug 209717] Doc.load fails, when using relative path : [Attachment 125977] Proposed fix, use the caller's base URI as the base URI in document.load().
Heikki Toivonen <heikki-bugzilla@comcast.net> has granted Johnny Stenback <jst@netscape.com>'s request for superreview: Bug 209717: Doc.load fails, when using relative path http://bugzilla.mozilla.org/show_bug.cgi?id=209717 Attachment 125977: Proposed fix, use the caller's base URI as the base URI in document.load(). http://bugzilla.mozilla.org/attachment.cgi?id=125977&action=edit ...

superreview granted: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172567] Updated patch to cope with Neil's suggestions, ready for checkin after Ben's approval
Giacomo Magnini <giacomo.magnini@portalis.it> has granted Giacomo Magnini <giacomo.magnini@portalis.it>'s request for superreview: Bug 252780: Roaming Access needs to be documented in help https://bugzilla.mozilla.org/show_bug.cgi?id=252780 Attachment 172567: Updated patch to cope with Neil's suggestions, ready for checkin after Ben's approval https://bugzilla.mozilla.org/attachment.cgi?id=172567&action=edit ...

superreview granted: [Bug 189307] typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play : [Attachment 135251] right
Robert O'Callahan <roc@ocallahan.org> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 189307: typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play http://bugzilla.mozilla.org/show_bug.cgi?id=189307 Attachment 135251: right http://bugzilla.mozilla.org/attachment.cgi?id=135251&action=edit ...

superreview granted: [Bug 337631] Support document.activeElement and document.hasFocus (IE's focus model) : [Attachment 225490] patch v4
Boris Zbarsky (gone June 15 -- June 20) <bzbarsky@mit.edu> has granted Peter Kasting <pkasting@google.com>'s request for superreview: Bug 337631: Support document.activeElement and document.hasFocus (IE's focus model) https://bugzilla.mozilla.org/show_bug.cgi?id=337631 Attachment 225490: patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=225490&action=edit ------- Additional Comments from Boris Zbarsky (gone June 15 -- June 20) <bzbarsky@mit.edu> >Index: content/base/src/nsDocument.cpp >+nsDocument::GetActiveElement(nsIDOMElement **aElem...

superreview granted: [Bug 220215] use the xpcnativewrapper for the current callers of components.lookupmethod : [Attachment 135169] Actually it's document.location that's safe, window is totally uns
Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 220215: use the xpcnativewrapper for the current callers of components.lookupmethod http://bugzilla.mozilla.org/show_bug.cgi?id=220215 Attachment 135169: Actually it's document.location that's safe, window is totally unsafe http://bugzilla.mozilla.org/attachment.cgi?id=135169&action=edit ------- Additional Comments from Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> sr=bzbarsky...

superreview granted: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ...

superreview granted: [Bug 292464] event listeners added using addEventListener() listen only trusted events : [Attachment 182542] v2: Use the document's principals to check whether it's chrome or not
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 292464: event listeners added using addEventListener() listen only trusted events https://bugzilla.mozilla.org/show_bug.cgi?id=292464 Attachment 182542: v2: Use the document's principals to check whether it's chrome or not. https://bugzilla.mozilla.org/attachment.cgi?id=182542&action=edit ...

superreview granted: [Bug 244288] MSAA's WindowFromAccessibleObject() doesn't work with Mozilla : [Attachment 149050] get_accParent() on document object should return ROLE_WINDOW object
Henry Jia <Henry.Jia@sun.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 244288: MSAA's WindowFromAccessibleObject() doesn't work with Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=244288 Attachment 149050: get_accParent() on document object should return ROLE_WINDOW object http://bugzilla.mozilla.org/attachment.cgi?id=149050&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...

superreview granted: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass null
neil@parkwaycc.co.uk <neil@httl.net> has granted Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 https://bugzilla.mozilla.org/show_bug.cgi?id=341436 Attachment 225493: Don't pass null in. https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Nit: adding a blank line after the return would make the code look nicer...

superreview granted: [Bug 316077] Add protocol handler to allow annotations to be referenced from a URI : [Attachment 203076] Patch addressing darin's review
Darin Fisher <darin@meer.net> has granted Brett Wilson <brettw@gmail.com>'s request for superreview: Bug 316077: Add protocol handler to allow annotations to be referenced from a URI https://bugzilla.mozilla.org/show_bug.cgi?id=316077 Attachment 203076: Patch addressing darin's review https://bugzilla.mozilla.org/attachment.cgi?id=203076&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> >Index: browser/components/places/src/nsAnnoProtocolHandler.h >+#define NS_ANNOPROTOCOLHANDLER_CID \ >+{ 0xe8b8bdb7, 0xc96c, 0x4d8...

superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...

superreview granted: [Bug 275960] document.lastModified cannot handle non-ascii characters when the page's HTTP header doesn't have Last-Modified : [Attachment 190024] Patch rv3.0
Boris Zbarsky <bzbarsky@mit.edu> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 275960: document.lastModified cannot handle non-ascii characters when the page's HTTP header doesn't have Last-Modified https://bugzilla.mozilla.org/show_bug.cgi?id=275960 Attachment 190024: Patch rv3.0 https://bugzilla.mozilla.org/attachment.cgi?id=190024&action=edit ...

superreview granted: [Bug 309044] Flashplayer 8 "Bad NPObject as private data!" : [Attachment 201809] Take a plugin's scriptable object out of the plugin element's prototype chain on plugin destructi
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 309044: Flashplayer 8 "Bad NPObject as private data!" https://bugzilla.mozilla.org/show_bug.cgi?id=309044 Attachment 201809: Take a plugin's scriptable object out of the plugin element's prototype chain on plugin destruction https://bugzilla.mozilla.org/attachment.cgi?id=201809&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> sr=me. /be ...

Web resources about - superreview granted: [Bug 292355] Plugins send document's base URI as referrer, instead of document's URI : [Attachment 182225] patch - netscape.mozilla.reviewers

Resources last updated: 12/28/2015 8:13:48 AM