superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178870] patch stage 1, review nits fixed

Robert Kaiser <kairo@kairo.at> has granted Robert Kaiser <kairo@kairo.at>'s
request for superreview:
Bug 285696: Check in code for rebranding Mozilla for milestone releases
https://bugzilla.mozilla.org/show_bug.cgi?id=285696

Attachment 178870: patch stage 1, review nits fixed
https://bugzilla.mozilla.org/attachment.cgi?id=178870&action=edit

------- Additional Comments from Robert Kaiser <kairo@kairo.at>
OK, this is the stage 1 patch with the review nits fixed.
I still need input if it builds OK on windows and mac before I check it in
though (linux was tested by me and doron).
0
bugzilla
3/29/2005 1:10:46 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
590 Views

Similar Articles

[PageSpeed] 57

Reply:

Similar Artilces:

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 180057] stage 1, additional fix 1: remove quoting trickery in bootstrap
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 180057: stage 1, additional fix 1: remove quoting trickery in bootstrap https://bugzilla.mozilla.org/attachment.cgi?id=180057&action=edit ...

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178797] patch stage 1: clean up some stuff and use MOZ_APP_* more often
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 178797: patch stage 1: clean up some stuff and use MOZ_APP_* more often https://bugzilla.mozilla.org/attachment.cgi?id=178797&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Please fix up the grammar of cannotEnableFilter to say "by a fut...

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 180058] stage 1, additional fix 2: remove version.dtd
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 180058: stage 1, additional fix 2: remove version.dtd https://bugzilla.mozilla.org/attachment.cgi?id=180058&action=edit ...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 180057] stage 1, additional fix 1: remove quoting trickery in bootstrap
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 180057: stage 1, additional fix 1: remove quoting trickery in bootstrap https://bugzilla.mozilla.org/attachment.cgi?id=180057&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Looking through the recently checked in patch for bug 274928 and applying that approach to our stuff, I realised...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178797] patch stage 1: clean up some stuff and use MOZ_APP_* more often
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 178797: patch stage 1: clean up some stuff and use MOZ_APP_* more often https://bugzilla.mozilla.org/attachment.cgi?id=178797&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> OK, I got a first stage of the patch for you. This doesn't contain any real branding change, but lots of stu...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 180058] stage 1, additional fix 2: remove version.dtd
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 180058: stage 1, additional fix 2: remove version.dtd https://bugzilla.mozilla.org/attachment.cgi?id=180058&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> As biesi has requested it in his review nits for stage 1, and we still have to wait for a complete solution, I hacked up the remova...

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 187687] stage 2: do the real rebranding
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 187687: stage 2: do the real rebranding https://bugzilla.mozilla.org/attachment.cgi?id=187687&action=edit ...

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 179417] Revised fixed for man page 2
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 179417: Revised fixed for man page 2 https://bugzilla.mozilla.org/attachment.cgi?id=179417&action=edit ...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 187687] stage 2: do the real rebranding
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 187687: stage 2: do the real rebranding https://bugzilla.mozilla.org/attachment.cgi?id=187687&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> OK, this is the real thing now. Please DON'T shout out loud about it for now (_no_ blog entries, board threads or similar stuff yet), we&#...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 179393] Fix Man Page
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 179393: Fix Man Page https://bugzilla.mozilla.org/attachment.cgi?id=179393&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> As discussed with Kairo earlier today, this patch fixes the manual page found in mozilla/xpfe/bootstrap that was broken by the stage 1 p...

superreview cancelled: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 179393] Fix Man Page
Robert Kaiser <kairo@kairo.at> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 179393: Fix Man Page https://bugzilla.mozilla.org/attachment.cgi?id=179393&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> r- via IRC. We should better use the configured prefix (mozappdir) that we install to with "make install". That way some distro can use standard conf...

superreview cancelled: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 179410] Revised fix for Man Page
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 179410: Revised fix for Man Page https://bugzilla.mozilla.org/attachment.cgi?id=179410&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Sorry folks, I got this wrong again, make install installs the wrapper script into bindir & the executable into moz...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 179410] Revised fix for Man Page
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 179410: Revised fix for Man Page https://bugzilla.mozilla.org/attachment.cgi?id=179410&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch to use mozappdir. ...

superreview requested: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 179417] Revised fixed for man page 2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 179417: Revised fixed for man page 2 https://bugzilla.mozilla.org/attachment.cgi?id=179417&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Ok, this one matches where things go when we do a make install. ...

Web resources about - superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178870] patch stage 1, review nits fixed - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/9/2015 7:00:53 PM