superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178797] patch stage 1: clean up some stuff and use MOZ_APP_* more often

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert
Kaiser <kairo@kairo.at>'s request for superreview:
Bug 285696: Check in code for rebranding Mozilla for milestone releases
https://bugzilla.mozilla.org/show_bug.cgi?id=285696

Attachment 178797: patch stage 1: clean up some stuff and use MOZ_APP_* more
often
https://bugzilla.mozilla.org/attachment.cgi?id=178797&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
Please fix up the grammar of cannotEnableFilter to say "by a future version".
Are those DEFINES supposed to be on separate lines?
Would you mind changing the bug reporting address to https: please?
You don't have to use %s to embed string contents in printf format strings, you
could use "literal" LITERAL concatenation (although I don't know what other
modules do).
Feel free to fix up the broken build id code.
Do we want to display the Gecko version in about: ? Former Suite users might
want to know ;-)
0
bugzilla
3/28/2005 8:41:52 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
299 Views

Similar Articles

[PageSpeed] 24

Reply: