superreview granted: [Bug 280871] Fix MSAA support for XUL and HTML combo boxes : [Attachment 173647] Five part fix

Brian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 280871: Fix MSAA support for XUL and HTML combo boxes
https://bugzilla.mozilla.org/show_bug.cgi?id=280871

Attachment 173647: Five part fix
https://bugzilla.mozilla.org/attachment.cgi?id=173647&action=edit

------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com>
>--- accessible/src/html/nsHTMLSelectAccessible.h	25 Jan 2005 19:35:53
-0000	   1.24
>+++ accessible/src/html/nsHTMLSelectAccessible.h	7 Feb 2005 18:11:25
-0000
>@@ -80,10 +80,12 @@ public:
>   NS_DECL_NSIACCESSIBLESELECTABLE
> 
>   nsHTMLSelectableAccessible(nsIDOMNode* aDOMNode, nsIWeakReference* aShell);

>   virtual ~nsHTMLSelectableAccessible() {}
> 
>+  NS_IMETHODIMP GetName(nsAString &aName) { return GetHTMLName(aName,
PR_FALSE); }
>+

I'm not sure if it matters or not, but for inline definitions we normally use
NS_IMETHOD instead of NS_IMETHODIMP.

>--- layout/forms/nsComboboxControlFrame.cpp	27 Jan 2005 22:52:52 -0000     
1.303
>+++ layout/forms/nsComboboxControlFrame.cpp	7 Feb 2005 18:11:27 -0000
>@@ -2374,18 +2375,34 @@ nsComboboxControlFrame::OnOptionSelected
>	selectFrame->OnOptionSelected(aPresContext, aIndex, aSelected);
>     }
>   } else {
>     if (aSelected) {
>	RedisplayText(aIndex);
>+	FireValueChangeEvent();
>     } else {
>	RedisplaySelectedText();
>     }
>   }
> 
>   return NS_OK;
> }
> 
>+void nsComboboxControlFrame::FireValueChangeEvent()
>+{

Looks ok otherwise.
0
bugzilla
2/7/2005 11:04:53 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
413 Views

Similar Articles

[PageSpeed] 6

Reply:

Similar Artilces:

superreview requested: [Bug 280871] Fix MSAA support for XUL and HTML combo boxes : [Attachment 173647] Five part fix
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 280871: Fix MSAA support for XUL and HTML combo boxes https://bugzilla.mozilla.org/show_bug.cgi?id=280871 Attachment 173647: Five part fix https://bugzilla.mozilla.org/attachment.cgi?id=173647&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> 1) Never create combo box name by appending option labels, Value change events 2) Use MSAA VALUE_CHANGE events for combo boxes that change, 3) fire DOM ValueChange event...

superreview granted: [Bug 289376] Fix description and value for combo boxes : [Attachment 179907] 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal (out til May 5) <aaronleventhal@moonset.net>'s request for superreview: Bug 289376: Fix description and value for combo boxes https://bugzilla.mozilla.org/show_bug.cgi?id=289376 Attachment 179907: 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected https://bugzilla.mozilla.org/attachment.cgi?id=179907&action=edit ------- Additional Comments from n...

superreview granted: [Bug 354832] Buttons and list options should support nsIAccessibleText : [Attachment 240651] Fix for HTML. Will need followup bug for XUL buttons, menu items and options
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 354832: Buttons and list options should support nsIAccessibleText https://bugzilla.mozilla.org/show_bug.cgi?id=354832 Attachment 240651: Fix for HTML. Will need followup bug for XUL buttons, menu items and options https://bugzilla.mozilla.org/attachment.cgi?id=240651&action=edit ...

superreview granted: [Bug 221669] [FIX]xul-overlay processing instruction pointing to inexistent file make mozilla enter in some kind of loop : [Attachment 153010] This should fix the problem
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 221669: [FIX]xul-overlay processing instruction pointing to inexistent file make mozilla enter in some kind of loop http://bugzilla.mozilla.org/show_bug.cgi?id=221669 Attachment 153010: This should fix the problem http://bugzilla.mozilla.org/attachment.cgi?id=153010&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - In nsXULDocument::ReportMissingOverlay(): + nsresult rv; + nsCOMPtr<nsI...

superreview granted: [Bug 317855] [FIX]Crash on reload with evil xul testcase, using -moz-box, -moz-grid-group, float: left [@ nsIFrame::GetNextSibling] : [Attachment 204987] Fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 317855: [FIX]Crash on reload with evil xul testcase, using -moz-box, -moz-grid-group, float: left [@ nsIFrame::GetNextSibling] https://bugzilla.mozilla.org/show_bug.cgi?id=317855 Attachment 204987: Fix https://bugzilla.mozilla.org/attachment.cgi?id=204987&action=edit ...

superreview requested: [Bug 289376] Fix description and value for combo boxes : [Attachment 179907] 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for comb #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 289376: Fix description and value for combo boxes https://bugzilla.mozilla.org/show_bug.cgi?id=289376 Attachment 179907: 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected https://bugzilla.mozilla.org/attachment.cgi?id=179907&action=edit ...

superreview requested: [Bug 289376] Fix description and value for combo boxes : [Attachment 179907] 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for comb #3
Aaron Leventhal (out til May 5) <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 289376: Fix description and value for combo boxes https://bugzilla.mozilla.org/show_bug.cgi?id=289376 Attachment 179907: 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected https://bugzilla.mozilla.org/attachment.cgi?id=179907&action=edit ------- Additional Comments from Aaron Leventhal (o...

superreview granted: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Would be nice to have this in cairo as well. Someone else's problem I guess. ...

superreview granted: [Bug 227819] [FIX]left and right results in wrong width with box-sizing border-box : [Attachment 137067] Fix (diff -uw)
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu>'s request for superreview: Bug 227819: [FIX]left and right results in wrong width with box-sizing border-box http://bugzilla.mozilla.org/show_bug.cgi?id=227819 Attachment 137067: Fix (diff -uw) http://bugzilla.mozilla.org/attachment.cgi?id=137067&action=edit ...

superreview granted: [Bug 280214] [FIX]views don't get updated with SVG generated in XUL documents : [Attachment 172726] This fixes the bug for me
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 280214: [FIX]views don't get updated with SVG generated in XUL documents https://bugzilla.mozilla.org/show_bug.cgi?id=280214 Attachment 172726: This fixes the bug for me https://bugzilla.mozilla.org/attachment.cgi?id=172726&action=edit ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

superreview granted: [Bug 360511] [FIX]Going back to page with URL hash (#foo) doesn't show hash part : [Attachment 245427] Fixes bug, as expected
Jonas Sicking <bugmail@sicking.cc> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 360511: [FIX]Going back to page with URL hash (#foo) doesn't show hash part https://bugzilla.mozilla.org/show_bug.cgi?id=360511 Attachment 245427: Fixes bug, as expected https://bugzilla.mozilla.org/attachment.cgi?id=245427&action=edit ...

superreview granted: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview granted: [Bug 233094] [FIX]input text doesn't appear in text box if text box is in floated cell : [Attachment 140654] This fixes all three testcases and the website
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 233094: [FIX]input text doesn't appear in text box if text box is in floated cell http://bugzilla.mozilla.org/show_bug.cgi?id=233094 Attachment 140654: This fixes all three testcases and the website http://bugzilla.mozilla.org/attachment.cgi?id=140654&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> I'm not crazy about any of the table pseudo frame construction code, and I don't remember my previous objection ...

Web resources about - superreview granted: [Bug 280871] Fix MSAA support for XUL and HTML combo boxes : [Attachment 173647] Five part fix - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/29/2015 7:19:22 AM