superreview granted: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch

Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 279495: A link with an URL and additional javascript open shows a popup and
an unwanted new window [link with TARGET and onClick=window.open]
https://bugzilla.mozilla.org/show_bug.cgi?id=279495

Attachment 172585: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
Ugh, I can't explain how this worked... not w/o digging through old code I
don't have handy.

sr=jst nonetheless.
0
bugzilla
1/28/2005 2:05:13 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
1103 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:

superreview requested: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 279495: A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] https://bugzilla.mozilla.org/show_bug.cgi?id=279495 Attachment 172585: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This basically backs out the "fix" for bug 135811. Now I can't figure out how finding targe...

superreview granted: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview granted: [Bug 174266] links opening blank new window but content showing in current window if browser.block.target_new_window : [Attachment 152987] Proposed patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 174266: links opening blank new window but content showing in current window if browser.block.target_new_window http://bugzilla.mozilla.org/show_bug.cgi?id=174266 Attachment 152987: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=152987&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Peter Van der Beken <peterv@propagandism.org> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: dom/src/base/nsGlobalWindow.cpp >=================================...

superreview granted: [Bug 310395] Open Link in New Window
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 227974: Unbitrots it https://bugzilla.mozilla.org/attachment.cgi?id=227974&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview cancelled: [Bug 310395] Open Link in New Window
froodiantherapy <stridey@gmail.com> has cancelled froodiantherapy <stridey@gmail.com>'s request for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy <stridey@gmail.com> This patch unbitrots the previous one. It touches all the high-traffic files, and took a long time to get back up to date, so let...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy (mostly gone until June 4) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy (mostly gone until June 4) <stridey@gmail.com> Assuming that this has cl+ too. ;) ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...

superreview cancelled: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...

superreview granted: [Bug 263844] Javascript window.close() on popup not working when popup is opened in tab : [Attachment 162257] set opener on opened windows diverted into tabs
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 263844: Javascript window.close() on popup not working when popup is opened in tab https://bugzilla.mozilla.org/show_bug.cgi?id=263844 Attachment 162257: set opener on opened windows diverted into tabs https://bugzilla.mozilla.org/attachment.cgi?id=162257&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky. Dan, thanks for doing this! I really wish we could factor some of this code that's being copied f...

superreview granted: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 242120] address review comments
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 242120: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=242120&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> I'd prefer if the lines didn't move. ...

superreview granted: [Bug 255123] Opening URL from another app focuses an existing window before opening a new window : [Attachment 161778] Updated patch repsecting loadDivertedInBackground preferenc
Brian Ryner (IBM) <bryner@brianryner.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 255123: Opening URL from another app focuses an existing window before opening a new window https://bugzilla.mozilla.org/show_bug.cgi?id=255123 Attachment 161778: Updated patch repsecting loadDivertedInBackground preference https://bugzilla.mozilla.org/attachment.cgi?id=161778&action=edit ...

superreview requested: [Bug 174266] links opening blank new window but content showing in current window if browser.block.target_new_window : [Attachment 152987] Proposed patch
Boris Zbarsky <bzbarsky@mit.edu> has asked for superreview: Bug 174266: links opening blank new window but content showing in current window if browser.block.target_new_window http://bugzilla.mozilla.org/show_bug.cgi?id=174266 Attachment 152987: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=152987&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> jst, would you sr? ...

Web resources about - superreview granted: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch - netscape.mozilla.reviewers

Resources last updated: 12/11/2015 1:05:33 PM