superreview granted: [Bug 270079] Mozilla can not print the URL in the header and footer. : [Attachment 168382] Patch with bz's comments

Robert O'Callahan <roc@ocallahan.org> has granted Robert O'Callahan
<roc@ocallahan.org>'s request for superreview:
Bug 270079: Mozilla can not print the URL in the header and footer.
https://bugzilla.mozilla.org/show_bug.cgi?id=270079

Attachment 168382: Patch with bz's comments
https://bugzilla.mozilla.org/attachment.cgi?id=168382&action=edit

------- Additional Comments from Robert O'Callahan <roc@ocallahan.org>
+  NS_ASSERTION(mGlobalPrintSettings, "Can't be NULL!");

I think this should be
NS_ASSERTION(NS_FAILED(rv) || mGlobalPrintSettings,

so we don't get the assertion if out of memory

r+sr=roc with that
0
bugzilla
12/19/2004 3:08:06 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
477 Views

Similar Articles

[PageSpeed] 8

Reply:

Similar Artilces:

superreview granted: [Bug 263177] [ps] mozilla generates level 2 postscript that will not print on a level 1 printer : [Attachment 176855] Patch with kherron+mozilla's comments.
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Leon Sha <leon.sha@sun.com>'s request for superreview: Bug 263177: [ps] mozilla generates level 2 postscript that will not print on a level 1 printer https://bugzilla.mozilla.org/show_bug.cgi?id=263177 Attachment 176855: Patch with kherron+mozilla's comments. https://bugzilla.mozilla.org/attachment.cgi?id=176855&action=edit ...

superreview requested: [Bug 263177] [ps] mozilla generates level 2 postscript that will not print on a level 1 printer : [Attachment 176855] Patch with kherron+mozilla's comments.
Leon Sha <leon.sha@sun.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 263177: [ps] mozilla generates level 2 postscript that will not print on a level 1 printer https://bugzilla.mozilla.org/show_bug.cgi?id=263177 Attachment 176855: Patch with kherron+mozilla's comments. https://bugzilla.mozilla.org/attachment.cgi?id=176855&action=edit ...

superreview granted: [Bug 290292] [Postscript] Text will beyond the end of table cell when printing or previewing in xft enabled mozilla. : [Attachment 181729] patch with jshin1987's comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 290292: [Postscript] Text will beyond the end of table cell when printing or previewing in xft enabled mozilla. https://bugzilla.mozilla.org/show_bug.cgi?id=290292 Attachment 181729: patch with jshin1987's comments https://bugzilla.mozilla.org/attachment.cgi?id=181729&action=edit ...

superreview granted: [Bug 274685] [print]Mozilla can't print frame correctly. : [Attachment 168746] Patch
Robert O'Callahan <roc@ocallahan.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 274685: [print]Mozilla can't print frame correctly. https://bugzilla.mozilla.org/show_bug.cgi?id=274685 Attachment 168746: Patch https://bugzilla.mozilla.org/attachment.cgi?id=168746&action=edit ...

superreview granted: [Bug 245751] Can't drag scrollbars in Print Preview anymore (after bug 245024's patch landed) : [Attachment 150428] Proposed patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 245751: Can't drag scrollbars in Print Preview anymore (after bug 245024's patch landed) http://bugzilla.mozilla.org/show_bug.cgi?id=245751 Attachment 150428: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=150428&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Maybe, maybe not, but none of this printing code is "safe" to start with, so I don...

superreview cancelled: [Bug 261717] Can't copy Website header (URL) in RSS message's header : [Attachment 165556] patch that enables a context menu to copy the URL (now localizable)
Scott MacGregor <mscott@mozilla.org> has cancelled David Fraser <davidf@sjsoft.com>'s request for superreview: Bug 261717: Can't copy Website header (URL) in RSS message's header https://bugzilla.mozilla.org/show_bug.cgi?id=261717 Attachment 165556: patch that enables a context menu to copy the URL (now localizable) https://bugzilla.mozilla.org/attachment.cgi?id=165556&action=edit ...

superreview requested: [Bug 261717] Can't copy Website header (URL) in RSS message's header : [Attachment 165556] patch that enables a context menu to copy the URL (now localizable)
David Fraser <davidf@sjsoft.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 261717: Can't copy Website header (URL) in RSS message's header https://bugzilla.mozilla.org/show_bug.cgi?id=261717 Attachment 165556: patch that enables a context menu to copy the URL (now localizable) https://bugzilla.mozilla.org/attachment.cgi?id=165556&action=edit ------- Additional Comments from David Fraser <davidf@sjsoft.com> Requesting review for this. It's a fairly straight forward patch, the main thing is whether it's correct to add ...

superreview granted: [Bug 272250] make distclean from mozilla does not clean mozilla/camino/build : [Attachment 169648] Adressing pink's comment.
Mike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 272250: make distclean from mozilla does not clean mozilla/camino/build https://bugzilla.mozilla.org/show_bug.cgi?id=272250 Attachment 169648: Adressing pink's comment. https://bugzilla.mozilla.org/attachment.cgi?id=169648&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview granted: [Bug 230598] RFE: Add Solaris patchchecker to Mozilla : [Attachment 140723] New patch per bsmedberg's comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Roland Mainz <roland.mainz@nrubsig.org>'s request for superreview: Bug 230598: RFE: Add Solaris patchchecker to Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=230598 Attachment 140723: New patch per bsmedberg's comments http://bugzilla.mozilla.org/attachment.cgi?id=140723&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: xpfe/bootstrap/init.d/README > Mozilla/FireBird/ThunderiBird/SunBird. "FireFox" and "ThunderBird" (spelling). sr=bzba...

superreview denied: [Bug 198515] When print a plugin, browser give the wrong file pointer to plugin. : [Attachment 127915] New patch per bz's and roc+moz's IRC comments
Boris Zbarsky <bzbarsky@mit.edu> has denied Roland Mainz (not reading bugmail) <Roland.Mainz@informatik.med.uni-giessen.de>'s request for superreview: Bug 198515: When print a plugin, browser give the wrong file pointer to plugin. http://bugzilla.mozilla.org/show_bug.cgi?id=198515 Attachment 127915: New patch per bz's and roc+moz's IRC comments http://bugzilla.mozilla.org/attachment.cgi?id=127915&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: gfx/public/nsIRenderingContext.h First thing is that you want...

superreview requested: [Bug 290292] [Postscript] Text will beyond the end of table cell when printing or previewing in xft enabled mozilla. : [Attachment 181729] patch with jshin1987's comments
Jungshik Shin <jshin1987@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 290292: [Postscript] Text will beyond the end of table cell when printing or previewing in xft enabled mozilla. https://bugzilla.mozilla.org/show_bug.cgi?id=290292 Attachment 181729: patch with jshin1987's comments https://bugzilla.mozilla.org/attachment.cgi?id=181729&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> r=jshin thanks for the patch. >+ origin_x += (face->glyph->advance.x) * x_scale ; nit: pls, get...

superreview granted: [Bug 235188] RFE: Mozilla should have an option to run X11 in threadsafe mode : [Attachment 142952] Patch for 2004-03-03-trunk per blizzard's comments
Christopher Blizzard <blizzard@mozilla.org> has granted Roland Mainz <roland.mainz@nrubsig.org>'s request for superreview: Bug 235188: RFE: Mozilla should have an option to run X11 in threadsafe mode http://bugzilla.mozilla.org/show_bug.cgi?id=235188 Attachment 142952: Patch for 2004-03-03-trunk per blizzard's comments http://bugzilla.mozilla.org/attachment.cgi?id=142952&action=edit ...

superreview granted: [Bug 283437] [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" : [Attachment 175792] Patch with kherron+mozilla's comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Leon Sha <leon.sha@sun.com>'s request for superreview: Bug 283437: [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" https://bugzilla.mozilla.org/show_bug.cgi?id=283437 Attachment 175792: Patch with kherron+mozilla's comments. https://bugzilla.mozilla.org/attachment.cgi?id=175792&action=edit ...

superreview granted: [Bug 283437] [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" : [Attachment 176857] Patch with kherron+mozilla's comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Leon Sha <leon.sha@sun.com>'s request for superreview: Bug 283437: [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" https://bugzilla.mozilla.org/show_bug.cgi?id=283437 Attachment 176857: Patch with kherron+mozilla's comments. https://bugzilla.mozilla.org/attachment.cgi?id=176857&action=edit ...

Web resources about - superreview granted: [Bug 270079] Mozilla can not print the URL in the header and footer. : [Attachment 168382] Patch with bz's comments - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/13/2016 5:20:32 PM