superreview granted: [Bug 263844] Javascript window.close() on popup not working when popup is opened in tab : [Attachment 162257] set opener on opened windows diverted into tabs

Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 263844: Javascript window.close() on popup not working when popup is opened
in tab
https://bugzilla.mozilla.org/show_bug.cgi?id=263844

Attachment 162257: set opener on opened windows diverted into tabs
https://bugzilla.mozilla.org/attachment.cgi?id=162257&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky.	Dan, thanks for doing this!

I really wish we could factor some of this code that's being copied from
windowwatcher all over, thoug.	Maybe we need some utility functions somewhere
that this and windowwatcher would both call?
0
bugzilla
10/16/2004 4:24:30 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
800 Views

Similar Articles

[PageSpeed] 40

Reply:

Similar Artilces:

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Peter Van der Beken <peterv@propagandism.org> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: dom/src/base/nsGlobalWindow.cpp >=================================...

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wind
Johnny Stenback <jst@mozilla.jstenback.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview granted: [Bug 263960] popup blocker fails to stop synthetic click popup in single window mode : [Attachment 161999] abort tab opening if window is a disallowed popup
Johnny Stenback <jst@mozilla.jstenback.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 263960: popup blocker fails to stop synthetic click popup in single window mode https://bugzilla.mozilla.org/show_bug.cgi?id=263960 Attachment 161999: abort tab opening if window is a disallowed popup https://bugzilla.mozilla.org/attachment.cgi?id=161999&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst too! ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wi
Dan M <danm.moz@gmail.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ...

superreview granted: [Bug 348183] scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeping it open : [Attachment 233097] alternative, low
Brian Ryner <bryner@gmail.com> has granted Seth Spitzer [:ss] <sspitzer@mozilla.com>'s request for superreview: Bug 348183: scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeping it open https://bugzilla.mozilla.org/show_bug.cgi?id=348183 Attachment 233097: alternative, low-risk patch until everything is sorted out https://bugzilla.mozilla.org/attachment.cgi?id=233097&action=edit ...

superreview granted: [Bug 263844] window.close() not working on new windows opened into tabs : [Attachment 163514] Danm's fix plus a tabbrowser.xml fix to prevent the crashes introduced in the initia
Brian Ryner (IBM) <bryner@brianryner.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 263844: window.close() not working on new windows opened into tabs https://bugzilla.mozilla.org/show_bug.cgi?id=263844 Attachment 163514: Danm's fix plus a tabbrowser.xml fix to prevent the crashes introduced in the initial landing of the fix for this bug. https://bugzilla.mozilla.org/attachment.cgi?id=163514&action=edit ------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com> >+ // There's only...

superreview requested: [Bug 263960] popup blocker fails to stop synthetic click popup in single window mode : [Attachment 161999] abort tab opening if window is a disallowed popup
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 263960: popup blocker fails to stop synthetic click popup in single window mode https://bugzilla.mozilla.org/show_bug.cgi?id=263960 Attachment 161999: abort tab opening if window is a disallowed popup https://bugzilla.mozilla.org/attachment.cgi?id=161999&action=edit ...

superreview granted: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 279495: A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] https://bugzilla.mozilla.org/show_bug.cgi?id=279495 Attachment 172585: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Ugh, I can't explain how this worked... not w/o digging through old code I ...

superreview granted: [Bug 232933] javascript window.open('file or bookmark', '_self') does nothing.. : [Attachment 140810] popup blocker once again tolerates window.open targeted to _self, _top et.al
Boris Zbarsky <bzbarsky@mit.edu> has granted Dan M <danm-moz@comcast.net>'s request for superreview: Bug 232933: javascript window.open('file or bookmark', '_self') does nothing.. http://bugzilla.mozilla.org/show_bug.cgi?id=232933 Attachment 140810: popup blocker once again tolerates window.open targeted to _self, _top et.al. http://bugzilla.mozilla.org/attachment.cgi?id=140810&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Doh! sr=bzbarsky ...

superreview granted: [Bug 338718] open/close a popup-window using javascript does not work properly : [Attachment 224015] fix
Boris Zbarsky <bzbarsky@mit.edu> has granted superreview: Bug 338718: open/close a popup-window using javascript does not work properly https://bugzilla.mozilla.org/show_bug.cgi?id=338718 Attachment 224015: fix https://bugzilla.mozilla.org/attachment.cgi?id=224015&action=edit ...

superreview requested: [Bug 348183] scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeing it open : [Attachment 233097] low risk patch u
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Brian Ryner <bryner@gmail.com> for superreview: Bug 348183: scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeing it open https://bugzilla.mozilla.org/show_bug.cgi?id=348183 Attachment 233097: low risk patch until everything is sorted out https://bugzilla.mozilla.org/attachment.cgi?id=233097&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> I'm still nervous about changing nsGlobalWindow.cp...

superreview granted: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 188996] no autohide var patch v0.1g
jag (Peter Annema) <jag@tty.nl> has granted Ian Neal (away 16th July - 21st July) <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows https://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 188996: no autohide var patch v0.1g https://bugzilla.mozilla.org/attachment.cgi?id=188996&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Nice! ...

superreview requested: [Bug 263844] window.close() not working on new windows opened into tabs : [Attachment 163514] Danm's fix plus a tabbrowser.xml fix to prevent the crashes introduced in the init
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 263844: window.close() not working on new windows opened into tabs https://bugzilla.mozilla.org/show_bug.cgi?id=263844 Attachment 163514: Danm's fix plus a tabbrowser.xml fix to prevent the crashes introduced in the initial landing of the fix for this bug. https://bugzilla.mozilla.org/attachment.cgi?id=163514&action=edit ...

Web resources about - superreview granted: [Bug 263844] Javascript window.close() on popup not working when popup is opened in tab : [Attachment 162257] set opener on opened windows diverted into tabs - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 2/6/2016 1:51:51 AM