superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments

Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz
<dveditz@cruzio.com>'s request for superreview:
Bug 263366: execute() doesn't check if exection succeeded or not, and claims it
did even if that's not the case
https://bugzilla.mozilla.org/show_bug.cgi?id=263366

Attachment 162166: fix review comments
https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit

------- Additional Comments from Daniel Veditz <dveditz@cruzio.com>
Carrying over r/sr, seeking branch approval. jst wants this for the plugin
finder
0
bugzilla
10/15/2004 5:55:17 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
587 Views

Similar Articles

[PageSpeed] 30

Reply:

Similar Artilces:

superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 161418] patch for aviary branch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 161418: patch for aviary branch https://bugzilla.mozilla.org/attachment.cgi?id=161418&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - In nsInstallFileOpItem::NativeFileOpFileExe... rv = process->Run(mBlock...

superreview requested: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 161395] Catch errors from executing files
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 161395: Catch errors from executing files https://bugzilla.mozilla.org/attachment.cgi?id=161395&action=edit ...

superreview denied: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 161395] Catch errors from executing files
Daniel Veditz <dveditz@cruzio.com> has denied Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 161395: Catch errors from executing files https://bugzilla.mozilla.org/attachment.cgi?id=161395&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> A non-blocking process--a very common case if you're launching a "wrapped in...

superreview requested: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 161418] patch for aviary branch
Daniel Veditz <dveditz@cruzio.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 161418: patch for aviary branch https://bugzilla.mozilla.org/attachment.cgi?id=161418&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 282615] DOMSerializer's security checks don't take capabilities into account. : [Attachment 174606] Fix (diff -w for reviews)
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 282615: DOMSerializer's security checks don't take capabilities into account. https://bugzilla.mozilla.org/show_bug.cgi?id=282615 Attachment 174606: Fix (diff -w for reviews) https://bugzilla.mozilla.org/attachment.cgi?id=174606&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171298] fix with smaug's comments
Darin Fisher (IBM) <darin@meer.net> has granted aaronr@us.ibm.com's request for superreview: Bug 278433: setvalue element doesn't use @value as context https://bugzilla.mozilla.org/show_bug.cgi?id=278433 Attachment 171298: fix with smaug's comments https://bugzilla.mozilla.org/attachment.cgi?id=171298&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> "valueAttr" over "valueattr" is generally preferred in mozilla code. ...

superreview requested: [Bug 282615] DOMSerializer's security checks don't take capabilities into account. : [Attachment 174606] Fix (diff -w for reviews)
Johnny Stenback <jst@mozilla.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 282615: DOMSerializer's security checks don't take capabilities into account. https://bugzilla.mozilla.org/show_bug.cgi?id=282615 Attachment 174606: Fix (diff -w for reviews) https://bugzilla.mozilla.org/attachment.cgi?id=174606&action=edit ...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 163330: corrects neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit ...

superreview granted: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Mike Connor <mconnor@steelgryphon.com>'s request for superreview: Bug 229737: [RFE] Favicons for XUL error pages https://bugzilla.mozilla.org/show_bug.cgi?id=229737 Attachment 193389: address Neil's comments, fix seamonkey's check https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >- var url = getWebNavigation().currentURI.spec >+ var url = document.documentURI.spec ...

superreview granted: [Bug 250493] nsHTMLFramesetFrame::Init doesn't check for failure : [Attachment 167891] fixes bug mentioned in Comment 14
Boris Zbarsky (out of town Dec 10 -- Jan 2) <bzbarsky@mit.edu> has granted Zbigniew Braniecki <gandalf@firefox.pl>'s request for superreview: Bug 250493: nsHTMLFramesetFrame::Init doesn't check for failure https://bugzilla.mozilla.org/show_bug.cgi?id=250493 Attachment 167891: fixes bug mentioned in Comment 14 https://bugzilla.mozilla.org/attachment.cgi?id=167891&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 10 -- Jan 2) <bzbarsky@mit.edu> >@@ -395,18 +408,31 @@ >nsHTMLFramesetFrame::Init(nsPresContext* > kidSC = ...

Web resources about - superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/3/2016 8:48:02 PM