superreview granted: [Bug 259076] proxy mode setting in gnome-network-preferences is not treated well by Mozilla : [Attachment 160322] patch to extend gconf proxy settings

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Wolfgang Rosenauer
<mozilla@rosenauer.org>'s request for superreview:
Bug 259076: proxy mode setting in gnome-network-preferences is not treated well
by Mozilla
https://bugzilla.mozilla.org/show_bug.cgi?id=259076

Attachment 160322: patch to extend gconf proxy settings
https://bugzilla.mozilla.org/attachment.cgi?id=160322&action=edit
0
bugzilla
2/2/2005 1:17:08 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
570 Views

Similar Articles

[PageSpeed] 3

Reply:

Similar Artilces:

superreview requested: [Bug 259076] proxy mode setting in gnome-network-preferences is not treated well by Mozilla : [Attachment 160322] patch to extend gconf proxy settings
Wolfgang Rosenauer <mozilla@rosenauer.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 259076: proxy mode setting in gnome-network-preferences is not treated well by Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=259076 Attachment 160322: patch to extend gconf proxy settings https://bugzilla.mozilla.org/attachment.cgi?id=160322&action=edit ...

superreview granted: [Bug 253008] Set network.proxy.share_proxy_settings if IE has a single proxy set up. : [Attachment 154306] patch
Darin Fisher (IBM) <darin@meer.net> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 253008: Set network.proxy.share_proxy_settings if IE has a single proxy set up. https://bugzilla.mozilla.org/show_bug.cgi?id=253008 Attachment 154306: patch https://bugzilla.mozilla.org/attachment.cgi?id=154306&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr=darin ...

superreview granted: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 314082] Mac OSX implementation of system proxy settings
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted James Bunton <jamesbunton@fastmail.fm>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 314082: Mac OSX implementation of system proxy settings - #6 https://bugzilla.mozilla.org/attachment.cgi?id=314082&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> excellent! ...

superreview canceled: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313576] Mac OSX implementation of system proxy settings
H=C3=A5kan Waara <hwaara@gmail.com> has canceled Robert O'Callahan (:roc) (= reduced activity March 18 to April 9) <roc@ocallahan.org>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313576: Mac OSX implementation of system proxy settings - #2 https://bugzilla.mozilla.org/attachment.cgi?id=3D313576&action=3Dedit ------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com> Here's a much cleaned up version. I've sanitized the C...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313576] Mac OSX implementation of system proxy settings
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 313576: Mac OSX implementation of system proxy settings - #2 https://bugzilla.mozilla.org/attachment.cgi?id=313576&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@o...

superreview canceled: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313868] Mac OSX implementation of system proxy settings
James Bunton <jamesbunton@fastmail.fm> has canceled H=C3=A5kan Waara <hwaara@gmail.com>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313868: Mac OSX implementation of system proxy settings - #4 https://bugzilla.mozilla.org/attachment.cgi?id=3D313868&action=3Dedit ------- Additional Comments from James Bunton <jamesbunton@fastmail.fm> Thanks Roc. Consistency is indeed important :)=0D =0D Changes:=0D * Made suggested changes to the build sys...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 314082] Mac OSX implementation of system proxy settings
James Bunton <jamesbunton@fastmail.fm> has asked for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 314082: Mac OSX implementation of system proxy settings - #6 https://bugzilla.mozilla.org/attachment.cgi?id=314082&action=edit ------- Additional Comments from James Bunton <jamesbunton@fastmail.fm> Sorry, I obviously didn't "get" the flags :) Changes: * Flattened out Init() * mContext needs to be around for the life of mSystemDynamicStore * break in...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313868] Mac OSX implementation of system proxy settings
H=C3=A5kan Waara <hwaara@gmail.com> has asked Robert O'Callahan (:roc) (red= uced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313868: Mac OSX implementation of system proxy settings - #4 https://bugzilla.mozilla.org/attachment.cgi?id=3D313868&action=3Dedit ------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com> Good work= ...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 314082] Mac OSX implementation of system proxy settings
James Bunton <jamesbunton@fastmail.fm> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 314082: Mac OSX implementation of system proxy settings - #6 https://bugzilla.mozilla.org/attachment.cgi?id=314082&action=edit ...

superreview granted: [Bug 84732] Installer proxy info (all-proxy.js) shouldn't be saved in Mozilla : [Attachment 148177] turns off all-proxy.js when install via proxy
Daniel Veditz <dveditz@cruzio.com> has granted benc@chuang.net's request for superreview: Bug 84732: Installer proxy info (all-proxy.js) shouldn't be saved in Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=84732 Attachment 148177: turns off all-proxy.js when install via proxy http://bugzilla.mozilla.org/attachment.cgi?id=148177&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> ok by me sr=dveditz ...

superreview canceled: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313624] Patch v3
H=C3=A5kan Waara <hwaara@gmail.com> has canceled H=C3=A5kan Waara <hwaara@g= mail.com>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313624: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D313624&action=3Dedit= ...

superreview granted: [Bug 280742] ignore_host GCONF key is not read in firefox proxy settings : [Attachment 206288] patch v2 for trunk
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted timeless@gmail.com <timeless@bemail.org>'s request for superreview: Bug 280742: ignore_host GCONF key is not read in firefox proxy settings https://bugzilla.mozilla.org/show_bug.cgi?id=280742 Attachment 206288: patch v2 for trunk https://bugzilla.mozilla.org/attachment.cgi?id=206288&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> I should let you know that I have a new gconf prefs backend that fixes a lot of problems in the current code and adds a...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313624] Patch v3
H=C3=A5kan Waara <hwaara@gmail.com> has asked Robert O'Callahan (:roc) (red= uced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313624: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D313624&action=3Dedit ------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com> Here's a much cleaned up version. I've sanitized the CF stuff, generalized methods, and other things, so this patc...

superreview granted: [Bug 444157] [Proxy] Migrate SeaMonkey's Proxies preferences to new pref window : [Attachment 331983] pref-proxies patch v0.2d
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 444157: [Proxy] Migrate SeaMonkey's Proxies preferences to new pref window https://bugzilla.mozilla.org/show_bug.cgi?id=444157 Attachment 331983: pref-proxies patch v0.2d https://bugzilla.mozilla.org/attachment.cgi?id=331983&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> That said, showing it on startup is not a problem, but remember to check that the element exists first - only the browser window ...

superreview granted: [Bug 444157] [Proxy] Migrate SeaMonkey's Proxies preferences to new pref window : [Attachment 332132] pref-proxies patch v0.2e
Ian Neal <iann_bugzilla@blueyonder.co.uk> has granted superreview: Bug 444157: [Proxy] Migrate SeaMonkey's Proxies preferences to new pref window https://bugzilla.mozilla.org/show_bug.cgi?id=444157 Attachment 332132: pref-proxies patch v0.2e https://bugzilla.mozilla.org/attachment.cgi?id=332132&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v0.2d: * Added check for existence of "network-proxy-system" element Carrying forward sr= ...

superreview granted: [Bug 290435] proxy settings are disabled after switching profiles : [Attachment 181939] fix a bug in the previous patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Boying Lu <brian.lu@sun.com>'s request for superreview: Bug 290435: proxy settings are disabled after switching profiles https://bugzilla.mozilla.org/show_bug.cgi?id=290435 Attachment 181939: fix a bug in the previous patch https://bugzilla.mozilla.org/attachment.cgi?id=181939&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Yes, but who will see the event first? ...

superreview canceled: [Bug 66057] Proxy: $http_proxy should influence proxy settings : [Attachment 293620] Updated Unix patch
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has canceled Michael Ventnor <ventnor.bugzilla@yahoo.com.au>'s request for superreview: Bug 66057: Proxy: $http_proxy should influence proxy settings https://bugzilla.mozilla.org/show_bug.cgi?id=66057 Attachment 293620: Updated Unix patch https://bugzilla.mozilla.org/attachment.cgi?id=293620&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> I really must remember the ifdefs since we cater to more than just Linux... ...

superreview requested: [Bug 66057] Proxy: $http_proxy should influence proxy settings : [Attachment 293620] Updated Unix patch
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 66057: Proxy: $http_proxy should influence proxy settings https://bugzilla.mozilla.org/show_bug.cgi?id=66057 Attachment 293620: Updated Unix patch https://bugzilla.mozilla.org/attachment.cgi?id=293620&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> Roc's old Unix patch carried through over a year of bitrot. I didn't bring along the Mac stuff since I don't understand Mac, and I'll d...

superreview requested: [Bug 66057] Proxy: $http_proxy should influence proxy settings : [Attachment 293721] Updated Unix patch 1.1
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 66057: Proxy: $http_proxy should influence proxy settings https://bugzilla.mozilla.org/show_bug.cgi?id=66057 Attachment 293721: Updated Unix patch 1.1 https://bugzilla.mozilla.org/attachment.cgi?id=293721&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> I really must remember the ifdefs since we cater to more than just Linux... ...

superreview granted: [Bug 229371] deCOMtaminate nsIPresContext : [Attachment 140351] patch for LoadImage, StopImagesFor, Set/GetContainer, Set/GetLinkHandler, Set/GetVisibleArea, Set/GetPageDim, GetL
David Baron <dbaron@dbaron.org> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 229371: deCOMtaminate nsIPresContext http://bugzilla.mozilla.org/show_bug.cgi?id=229371 Attachment 140351: patch for LoadImage, StopImagesFor, Set/GetContainer, Set/GetLinkHandler, Set/GetVisibleArea, Set/GetPageDim, GetLanguage http://bugzilla.mozilla.org/attachment.cgi?id=140351&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> >Index: layout/base/src/nsPresContext.cpp >@@ -706,8 +707,7 @@ void > nsPresConte...

superreview granted: [Bug 50380] Proxy: Option to set all servers to the same hostname : [Attachment 135971] patch v3
Brian Ryner (away until Dec 30) <bryner@brianryner.com> has granted Jerry <jerry.tan@sun.com>'s request for superreview: Bug 50380: Proxy: Option to set all servers to the same hostname http://bugzilla.mozilla.org/show_bug.cgi?id=50380 Attachment 135971: patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=135971&action=edit ...

superreview granted: [Bug 290435] proxy settings are disabled after switching profiles : [Attachment 181521] a new patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Boying Lu <brian.lu@sun.com>'s request for superreview: Bug 290435: proxy settings are disabled after switching profiles https://bugzilla.mozilla.org/show_bug.cgi?id=290435 Attachment 181521: a new patch https://bugzilla.mozilla.org/attachment.cgi?id=181521&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> This sorta looks right although I'm worried that you might need to call SavePrefFile(null); maybe someone who knows the code b...

superreview requested: [Bug 84732] Installer proxy info (all-proxy.js) shouldn't be saved in Mozilla : [Attachment 148177] turns off all-proxy.js when install via proxy
benc@chuang.net has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 84732: Installer proxy info (all-proxy.js) shouldn't be saved in Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=84732 Attachment 148177: turns off all-proxy.js when install via proxy http://bugzilla.mozilla.org/attachment.cgi?id=148177&action=edit ...

superreview granted: [Bug 444157] Migrate SeaMonkey's Proxies preferences to new pref window : [Attachment 329258] pref-proxies patch v0.2a
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 444157: Migrate SeaMonkey's Proxies preferences to new pref window https://bugzilla.mozilla.org/show_bug.cgi?id=3D444157 Attachment 329258: pref-proxies patch v0.2a https://bugzilla.mozilla.org/attachment.cgi?id=3D329258&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> There's a lot of nits but they're all small ones :-)=0D =0D >+ buttons=3D"accept,cancel,help"=0D I don...

Web resources about - superreview granted: [Bug 259076] proxy mode setting in gnome-network-preferences is not treated well by Mozilla : [Attachment 160322] patch to extend gconf proxy settings - netscape.mozilla.reviewers

Resources last updated: 2/24/2016 8:00:32 PM