superreview cancelled: [Bug 257690] CreateGeneratedFrameFor() doesn't add the generated content as anonymous content : [Attachment 157632] Mark tell the presshell about anonymous content for generateJohnny Stenback <jst@mozilla.jstenback.com> has cancelled Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 257690: CreateGeneratedFrameFor() doesn't add the generated content as
anonymous content
http://bugzilla.mozilla.org/show_bug.cgi?id=257690
Attachment 157632: Mark tell the presshell about anonymous content for
generated frames.
http://bugzilla.mozilla.org/attachment.cgi?id=157632&action=edit
...
superreview requested: [Bug 257690] CreateGeneratedFrameFor() doesn't add the generated content as anonymous content : [Attachment 157632] Mark tell the presshell about anonymous content for generateJohnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky (no tree
till Sept 10) <bzbarsky@mit.edu> for superreview:
Bug 257690: CreateGeneratedFrameFor() doesn't add the generated content as
anonymous content
http://bugzilla.mozilla.org/show_bug.cgi?id=257690
Attachment 157632: Mark tell the presshell about anonymous content for
generated frames.
http://bugzilla.mozilla.org/attachment.cgi?id=157632&action=edit
...
superreview granted: [Bug 251844] [FIX]<object> blocked by content policy doesn't show alternate content : [Attachment 153492] PatchJohnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 251844: [FIX]<object> blocked by content policy doesn't show alternate
content
http://bugzilla.mozilla.org/show_bug.cgi?id=251844
Attachment 153492: Patch
http://bugzilla.mozilla.org/attachment.cgi?id=153492&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
sr=jst
...
superreview granted: [Bug 226954] doesn't show the 'contents' frame : [Attachment 136666] Partial patchDavid Baron <dbaron@dbaron.org> has granted Boris Zbarsky (not in town, no
tree) <bz-vacation@mit.edu>'s request for superreview:
Bug 226954: doesn't show the 'contents' frame
http://bugzilla.mozilla.org/show_bug.cgi?id=226954
Attachment 136666: Partial patch
http://bugzilla.mozilla.org/attachment.cgi?id=136666&action=edit
------- Additional Comments from David Baron <dbaron@dbaron.org>
r+sr=dbaron. sorry for the delay
...
superreview granted: [Bug 229722] 64bit safe code for mozilla/content (WinXP AMD64) : [Attachment 138166] mozilla/content diffsJohnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 229722: 64bit safe code for mozilla/content (WinXP AMD64)
http://bugzilla.mozilla.org/show_bug.cgi?id=229722
Attachment 138166: mozilla/content diffs
http://bugzilla.mozilla.org/attachment.cgi?id=138166&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
r+sr=jst
...
superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review commentsBoris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s
request for superreview:
Bug 280713: ContinueInterruptedParsing doesn't set the current context's
scanner's mIncremental member correctly
https://bugzilla.mozilla.org/show_bug.cgi?id=280713
Attachment 173997: updated to review comments
https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a....
...
superreview granted: [Bug 292944] ###!!! ASSERTION: Can't execute uncompiled method: 'mIsCompiled', file r:/mozilla/content/xbl/src/nsXBLProtoImplMethod.cpp, line 270 : [Attachment 182748] Proposed pJohnny Stenback <jst@mozilla.org> has granted Boris Zbarsky (gone June 3 --
June 30) <bzbarsky@mit.edu>'s request for superreview:
Bug 292944: ###!!! ASSERTION: Can't execute uncompiled method: 'mIsCompiled',
file r:/mozilla/content/xbl/src/nsXBLProtoImplMethod.cpp, line 270
https://bugzilla.mozilla.org/show_bug.cgi?id=292944
Attachment 182748: Proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=182748&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.org>
r+sr=jst
...
superreview granted: [Bug 232129] imap protocol logging doesn't handle long lines : [Attachment 139853] fix that doesn't add newlinesScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 232129: imap protocol logging doesn't handle long lines
http://bugzilla.mozilla.org/show_bug.cgi?id=232129
Attachment 139853: fix that doesn't add newlines
http://bugzilla.mozilla.org/attachment.cgi?id=139853&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
cool. thanks for the clarification.
...
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nondRobert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview:
Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title
in defs
https://bugzilla.mozilla.org/show_bug.cgi?id=340083
Attachment 224205: don't create frames for content we don't handle, don't
invalidate nondisplay content
https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit
...
superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review commentsDaniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz
<dveditz@cruzio.com>'s request for superreview:
Bug 263366: execute() doesn't check if exection succeeded or not, and claims it
did even if that's not the case
https://bugzilla.mozilla.org/show_bug.cgi?id=263366
Attachment 162166: fix review comments
https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit
------- Additional Comments from Daniel Veditz <dveditz@cruzio.com>
Carrying over r/sr, seeking branch approval. jst wants this for the plugin
finder
...
superreview granted: [Bug 207865] ASSERTION: unable to normalize attribute name: 'NS_SUCCEEDED(rv)', file i:/build/mozilla/content/xul/content/src/nsXULElement.cpp, line 1301 : [Attachment 134761] fDarin Fisher <darin@meer.net> has granted timeless@myrealbox.com
<timeless@bemail.org>'s request for superreview:
Bug 207865: ASSERTION: unable to normalize attribute name: 'NS_SUCCEEDED(rv)',
file i:/build/mozilla/content/xul/content/src/nsXULElement.cpp, line 1301
http://bugzilla.mozilla.org/show_bug.cgi?id=207865
Attachment 134761: fix xul
http://bugzilla.mozilla.org/attachment.cgi?id=134761&action=edit
...
superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review commentScott MacGregor <mscott@mozilla.org> has granted Scott MacGregor
<mscott@mozilla.org>'s request for superreview:
Bug 285138: Spellchecker doesn't skip quoted text in plain text editor
https://bugzilla.mozilla.org/show_bug.cgi?id=285138
Attachment 179753: fix based on daniel's review comment
https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit
...
superreview granted: [Bug 236541] "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used : [Attachment 208411] Patch for the core code per comment 38.Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 236541: "do this automatically for files like this" doesn't work when
Content-Disposition:attachment is used
https://bugzilla.mozilla.org/show_bug.cgi?id=236541
Attachment 208411: Patch for the core code per comment 38.
https://bugzilla.mozilla.org/attachment.cgi?id=208411&action=edit
...
superreview granted: [Bug 310833] Template builder doesn't free constructed content when menulists are in use : [Attachment 198418] back out xul template builder changes, re-write thunderbird prefs tDavid Bienvenu <bienvenu@nventure.com> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 310833: Template builder doesn't free constructed content when menulists
are in use
https://bugzilla.mozilla.org/show_bug.cgi?id=310833
Attachment 198418: back out xul template builder changes, re-write thunderbird
prefs to not use the template builder
https://bugzilla.mozilla.org/attachment.cgi?id=198418&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
+ if (preference.value == abURI)
+ {
...
superreview granted: [Bug 401559] GetFirst/LastChild doesn' t ensure contents generatedJohnny Stenback (:jst) <jst@mozilla.org> has granted Smaug
<Olli.Pettay@gmail.com>'s request for superreview:
Bug 401559: GetFirst/LastChild doesn't ensure contents generated
https://bugzilla.mozilla.org/show_bug.cgi?id=401559
Attachment 286564: proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=286564&action=edit
...