superreview granted: [Bug 255366] File picker calls crash mozilla (open file, file attach, file browser, etc) : [Attachment 159629] Make our prototype for _gtk_file_chooser_dialog_new_fn() match real

Johnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 255366: File picker calls crash mozilla (open file, file attach, file
browser, etc)
https://bugzilla.mozilla.org/show_bug.cgi?id=255366

Attachment 159629: Make our prototype for _gtk_file_chooser_dialog_new_fn()
match reality (patch by bryner)
https://bugzilla.mozilla.org/attachment.cgi?id=159629&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
Chris, was this done this way intentionally, or would this be more appropriate
here?
0
bugzilla
9/21/2004 10:15:52 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
873 Views

Similar Articles

[PageSpeed] 8

Reply:

Similar Artilces:

superreview granted: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 153467] set the attachment name as the leaf name of the file
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 153467: set the attachment name as the leaf name of the file http://bugzilla.mozilla.org/attachment.cgi?id=153467&action=edit ...

superreview denied: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 148287] Set the real name to an eudora imported attached file.
Scott MacGregor <mscott@mozilla.org> has denied Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 148287: Set the real name to an eudora imported attached file. http://bugzilla.mozilla.org/attachment.cgi?id=148287&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Yann, is the fileName argument that gets passed into AddAttachment already...

superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Well, that kinda sucks. ...

superreview granted: [Bug 339843] [BeOS] mozilla/browser/app needs resource file for BeOS : [Attachment 223953] Patch to include resource file in Makefile
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 339843: [BeOS] mozilla/browser/app needs resource file for BeOS https://bugzilla.mozilla.org/show_bug.cgi?id=339843 Attachment 223953: Patch to include resource file in Makefile https://bugzilla.mozilla.org/attachment.cgi?id=223953&action=edit ...

superreview granted: [Bug 225125] open / save dialog (file picker) causes crash with files with characters outside the repertoire of the current locale encoding in their names : [Attachment 137696]
Darin Fisher <darin@meer.net> has granted Jungshik Shin <jshin@mailaps.org>'s request for superreview: Bug 225125: open / save dialog (file picker) causes crash with files with characters outside the repertoire of the current locale encoding in their names http://bugzilla.mozilla.org/show_bug.cgi?id=225125 Attachment 137696: a patch http://bugzilla.mozilla.org/attachment.cgi?id=137696&action=edit ...

superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but I didn't verify general correctness of the win32 mumbo-jumbo (I don't know enough about win32 to do that). ...

superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: xpfe/components/bookmarks/src/nsBookmarksService.cpp The changes to this are fine. File a bug on firefox t...

superreview granted: [Bug 241212] Message window for .EML file needs envelope panel : [Attachment 193489] enable opening of attachments from .eml files opened in stand-along window
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 241212: Message window for .EML file needs envelope panel https://bugzilla.mozilla.org/show_bug.cgi?id=241212 Attachment 193489: enable opening of attachments from .eml files opened in stand-along window https://bugzilla.mozilla.org/attachment.cgi?id=193489&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I don't know what the answer is to Neil's comment about using LOAD_FLAGS_LINK. I know everywhe...

superreview granted: [Bug 272541] Browser prompts to download attachment file (multipart file?) : [Attachment 167552] Proposed patch
Darin Fisher (IBM) <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 272541: Browser prompts to download attachment file (multipart file?) https://bugzilla.mozilla.org/show_bug.cgi?id=272541 Attachment 167552: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=167552&action=edit ...

superreview granted: [Bug 309241] a tmp file should be created if open an attachment of an local eml file : [Attachment 197131] patchv2
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 309241: a tmp file should be created if open an attachment of an local eml file https://bugzilla.mozilla.org/show_bug.cgi?id=309241 Attachment 197131: patchv2 https://bugzilla.mozilla.org/attachment.cgi?id=197131&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> With biesi's nit, looks great. ...

superreview granted: [Bug 441785] crash when closing open rdf files or right click on tree after opening rdf files [@ nsXULTemplateQueryProcessorRDF::CheckIsSeparator] : [Attachment 329614] Patch v3 w
Johnny Stenback (:jst, jst@mozilla.com) <jst@mozilla.org> has granted Mike Kaplinskiy <mike.kaplinskiy@gmail.com>'s request for superreview: Bug 441785: crash when closing open rdf files or right click on tree after opening rdf files [@ nsXULTemplateQueryProcessorRDF::CheckIsSeparator] https://bugzilla.mozilla.org/show_bug.cgi?id=441785 Attachment 329614: Patch v3 w/ semi-working crashtest https://bugzilla.mozilla.org/attachment.cgi?id=329614&action=edit ...

superreview requested: [Bug 36619] [HLP][FILE]calling click() on file upload control should bring up file picker : [Attachment 178686] Allows click() to launch filepicker
Stephen Deken <stephen@diary-x.com> has asked Stephen Deken <stephen@diary-x.com> for superreview: Bug 36619: [HLP][FILE]calling click() on file upload control should bring up file picker https://bugzilla.mozilla.org/show_bug.cgi?id=36619 Attachment 178686: Allows click() to launch filepicker https://bugzilla.mozilla.org/attachment.cgi?id=178686&action=edit ------- Additional Comments from Stephen Deken <stephen@diary-x.com> (sheepishly flagging patch for review) ...

superreview denied: [Bug 36619] [HLP][FILE]calling click() on file upload control should bring up file picker : [Attachment 178686] Allows click() to launch filepicker
Johnny Stenback <jst@mozilla.org> has denied Stephen Deken <stephen@diary-x.com>'s request for superreview: Bug 36619: [HLP][FILE]calling click() on file upload control should bring up file picker https://bugzilla.mozilla.org/show_bug.cgi?id=36619 Attachment 178686: Allows click() to launch filepicker https://bugzilla.mozilla.org/attachment.cgi?id=178686&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> This looks good in general, but we should be dispatching a synthetic click event at the button (an anonymous child of the <...

superreview requested: [Bug 36619] [HLP][FILE]calling click() on file upload control should bring up file picker : [Attachment 178686] Allows click() to launch filepicker #2
Stephen Deken <stephen@diary-x.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 36619: [HLP][FILE]calling click() on file upload control should bring up file picker https://bugzilla.mozilla.org/show_bug.cgi?id=36619 Attachment 178686: Allows click() to launch filepicker https://bugzilla.mozilla.org/attachment.cgi?id=178686&action=edit ------- Additional Comments from Stephen Deken <stephen@diary-x.com> Boris, thanks for not making well-deserved fun of me. Flagged for review by the DOM owners, addtl review by callion. Sorry for the spa...

Web resources about - superreview granted: [Bug 255366] File picker calls crash mozilla (open file, file attach, file browser, etc) : [Attachment 159629] Make our prototype for _gtk_file_chooser_dialog_new_fn() match real - netscape.mozilla.reviewers

Resources last updated: 11/27/2015 2:31:49 PM