superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192062] patch v3

Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s
request for superreview:
Bug 253234: [patch]No Option to set Junk Mail as Read
https://bugzilla.mozilla.org/show_bug.cgi?id=253234

Attachment 192062: patch v3
https://bugzilla.mozilla.org/attachment.cgi?id=192062&action=edit

------- Additional Comments from Jens Bannmann <jens.b@web.de>
I replaced analyzeMessageForJunk() with an object that keeps track of pending
messages and implements the listener. That didn't shorten the code, but its
workings should be far more obvious now.
0
bugzilla
8/9/2005 6:42:34 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
395 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192063] patch v3.1
Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192063: patch v3.1 https://bugzilla.mozilla.org/attachment.cgi?id=192063&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> .... now without dump() statements. ...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192118] backend patch
David Bienvenu <bienvenu@nventure.com> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192118: backend patch https://bugzilla.mozilla.org/attachment.cgi?id=192118&action=edit ...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 190879] patch v2
Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 190879: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=190879&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> Addressing review comments. Additionally, I added a comment explaining how analyzeMessageForJunk() works and how it's called, and changed some broken indentation. This patch was tested both wi...

superreview cancelled: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192119] frontend patch
Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192119: frontend patch https://bugzilla.mozilla.org/attachment.cgi?id=192119&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> The front-end part is fixed both on branch and trunk (prefs -> privcacy -> junk), so the front-end patch should be obsolete. ...

superreview requested: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192118] backend patch
Jens Bannmann <jens.b@web.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192118: backend patch https://bugzilla.mozilla.org/attachment.cgi?id=192118&action=edit ...

superreview requested: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192119] frontend patch
Jens Bannmann <jens.b@web.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192119: frontend patch https://bugzilla.mozilla.org/attachment.cgi?id=192119&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> Carrying over r=dmose. Scott, can you have a look at this? It adds a radio button labelled "Mark messages determined to be Junk as read" in the junk mail controls, below the "Move incomin...

superreview granted: [Bug 253234] No Option to set Junk Mail as Read : [Attachment 160621] same changes to chrome as in the seamonkey patch
David Bienvenu <bienvenu@nventure.com> has granted Eyal Rozenberg <eyalroz@technion.ac.il>'s request for superreview: Bug 253234: No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 160621: same changes to chrome as in the seamonkey patch https://bugzilla.mozilla.org/attachment.cgi?id=160621&action=edit ...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 190235] unbitrotted version of #160621
Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 190235: unbitrotted version of #160621 https://bugzilla.mozilla.org/attachment.cgi?id=190235&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> Unbitrotting the patch; carrying over sr=bienvenu. ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview requested: [Bug 253234] No Option to set Junk Mail as Read : [Attachment 160621] same changes to chrome as in the seamonkey patch
Eyal Rozenberg <eyalroz@technion.ac.il> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 253234: No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 160621: same changes to chrome as in the seamonkey patch https://bugzilla.mozilla.org/attachment.cgi?id=160621&action=edit ------- Additional Comments from Eyal Rozenberg <eyalroz@technion.ac.il> Feature seems to be working (finally managed to build tbird), so it's review time. ...

superreview granted: [Bug 204339] [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header : [Attachment 169079] patch: support for interpreting mail-followup-to and mail
Henry Jia <Henry.Jia@sun.com> has granted Daniel Faber <mail@daniel-faber.de>'s request for superreview: Bug 204339: [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header https://bugzilla.mozilla.org/show_bug.cgi?id=204339 Attachment 169079: patch: support for interpreting mail-followup-to and mail-reply-to - v2 https://bugzilla.mozilla.org/attachment.cgi?id=169079&action=edit ...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

superreview granted: [Bug 193625] Option to mark incoming junk mail as read : [Attachment 145509] proposed patch v9
David Bienvenu <bienvenu@nventure.com> has granted Eyal Rozenberg <eyalroz@technion.ac.il>'s request for superreview: Bug 193625: Option to mark incoming junk mail as read http://bugzilla.mozilla.org/show_bug.cgi?id=193625 Attachment 145509: proposed patch v9 http://bugzilla.mozilla.org/attachment.cgi?id=145509&action=edit ...

superreview requested: [Bug 204339] [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header : [Attachment 169079] patch: support for interpreting mail-followup-to and ma #4
Daniel Faber <mail@daniel-faber.de> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 204339: [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header https://bugzilla.mozilla.org/show_bug.cgi?id=204339 Attachment 169079: patch: support for interpreting mail-followup-to and mail-reply-to - v2 https://bugzilla.mozilla.org/attachment.cgi?id=169079&action=edit ...

Web resources about - superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192062] patch v3 - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/11/2016 7:17:12 PM