superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173795] equivalent for firefox

Darin Fisher <darin@meer.net> has granted T Rowley (IBM) <tor@acm.org>'s
request for superreview:
Bug 250936: Non distributed image formats opens many mozilla windows until
crashed (infinite/eternal window opening loop)
https://bugzilla.mozilla.org/show_bug.cgi?id=250936

Attachment 173795: equivalent for firefox
https://bugzilla.mozilla.org/attachment.cgi?id=173795&action=edit

------- Additional Comments from Darin Fisher <darin@meer.net>
>Index: nsBrowserContentHandler.js

> const nsIPrefBranch	       = Components.interfaces.nsIPrefBranch;
> const nsIPrefLocalizedString = Components.interfaces.nsIPrefLocalizedString;
> const nsISupportsString      = Components.interfaces.nsISupportsString;
> const nsIWebNavigation       = Components.interfaces.nsIWebNavigation;
> const nsIWindowMediator      = Components.interfaces.nsIWindowMediator;
> const nsIWindowWatcher       = Components.interfaces.nsIWindowWatcher;
....
>+	var catMan = Components.classes["@mozilla.org/categorymanager;1"]
>+		     .getService(Components.interfaces.nsICategoryManager);

so, this file appears to like to define interfaces up front.
how about doing the same for nsICategoryManager?  then you 
could write:

      var catMan = Components.classes["@mozilla.org/categorymanager;1"]
			     .getService(nsICategoryManager);

which is a bit more readable.


sr=darin with or without this change
0
bugzilla
2/19/2005 12:11:24 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
695 Views

Similar Articles

[PageSpeed] 34

Reply:

Similar Artilces:

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173795] equivalent for firefox
T Rowley (IBM) <tor@acm.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173795: equivalent for firefox https://bugzilla.mozilla.org/attachment.cgi?id=173795&action=edit ...

superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patch
T Rowley (IBM) <tor@acm.org> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173746: patch https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit ...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173746: patch https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit ...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed : [Attachment 152994] Patch nsModule to register only supported image formats
timeless@myrealbox.com (working) <timeless@bemail.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed http://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 152994: Patch nsModule to register only supported image formats http://bugzilla.mozilla.org/attachment.cgi?id=152994&action=edit ...

superreview cancelled: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed : [Attachment 152994] Patch nsModule to register only supported image formats
Christian Biesinger (unique:bi) <cbiesinger@gmx.at> has cancelled timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed http://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 152994: Patch nsModule to register only supported image formats http://bugzilla.mozilla.org/attachment.cgi?id=152994&action=edit ...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed : [Attachment 152994] Patch nsModule to register only supported image formats #2
timeless@myrealbox.com (working) <timeless@bemail.org> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed http://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 152994: Patch nsModule to register only supported image formats http://bugzilla.mozilla.org/attachment.cgi?id=152994&action=edit ...

superreview granted: [Bug 284661] JavaScript-based extension opens chrome window -- window looks strange then Mozilla crashes [@ nsFontMetricsXft::FindFont] : [Attachment 179023] fix
Christopher Blizzard <blizzard@mozilla.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 284661: JavaScript-based extension opens chrome window -- window looks strange then Mozilla crashes [@ nsFontMetricsXft::FindFont] https://bugzilla.mozilla.org/show_bug.cgi?id=284661 Attachment 179023: fix https://bugzilla.mozilla.org/attachment.cgi?id=179023&action=edit ...

superreview granted: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
neil@parkwaycc.co.uk <neil@httl.net> has granted Stefan <stefanh@inbox.com>'s request for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview granted: [Bug 83313] "Open File" menu command nonfunctional when no Mozilla windows are open : [Attachment 171700] patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 83313: "Open File" menu command nonfunctional when no Mozilla windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=83313 Attachment 171700: patch https://bugzilla.mozilla.org/attachment.cgi?id=171700&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Looks good, assuming it's been tested. ...

superreview requested: [Bug 284661] JavaScript-based extension opens chrome window -- window looks strange then Mozilla crashes [@ nsFontMetricsXft::FindFont] : [Attachment 179023] fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 284661: JavaScript-based extension opens chrome window -- window looks strange then Mozilla crashes [@ nsFontMetricsXft::FindFont] https://bugzilla.mozilla.org/show_bug.cgi?id=284661 Attachment 179023: fix https://bugzilla.mozilla.org/attachment.cgi?id=179023&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> This fixes the problem. We just need to be sure to resize the transparency bitmap i...

superreview granted: [Bug 196670] JNG images crash Mozilla on Windows[@ mng_add_chunk ] : [Attachment 129051] Patch to work around Microsoft compiler bug that causes JNG crash
<rbs@maths.uq.edu.au> has granted Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org>'s request for superreview: Bug 196670: JNG images crash Mozilla on Windows[@ mng_add_chunk ] http://bugzilla.mozilla.org/show_bug.cgi?id=196670 Attachment 129051: Patch to work around Microsoft compiler bug that causes JNG crash http://bugzilla.mozilla.org/attachment.cgi?id=129051&action=edit ------- Additional Comments from <rbs@maths.uq.edu.au> sr=rbs ...

superreview granted: [Bug 196670] JNG images crash Mozilla on Windows[@ mng_add_chunk ] : [Attachment 134570] Revised patch to work around MS compiler bug that crashes JNG
<rbs@maths.uq.edu.au> has granted Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org>'s request for superreview: Bug 196670: JNG images crash Mozilla on Windows[@ mng_add_chunk ] http://bugzilla.mozilla.org/show_bug.cgi?id=196670 Attachment 134570: Revised patch to work around MS compiler bug that crashes JNG http://bugzilla.mozilla.org/attachment.cgi?id=134570&action=edit ------- Additional Comments from <rbs@maths.uq.edu.au> sr=rbs ...

superreview granted: [Bug 287979] Infinite loop caused by the way we expose native objects as IAccessibles : [Attachment 178763] 1) The child of the Mozilla plugin window container is the window owni
Johnny Stenback <jst@mozilla.org> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 287979: Infinite loop caused by the way we expose native objects as IAccessibles https://bugzilla.mozilla.org/show_bug.cgi?id=287979 Attachment 178763: 1) The child of the Mozilla plugin window container is the window owning the plugin, 2) Null plugins are no longer native objects, and this solves the infinite loop in a more generic way anyway https://bugzilla.mozilla.org/attachment.cgi?id=178763&action=edit ------- Additional Comments from ...

superreview granted: [Bug 263844] Javascript window.close() on popup not working when popup is opened in tab : [Attachment 162257] set opener on opened windows diverted into tabs
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 263844: Javascript window.close() on popup not working when popup is opened in tab https://bugzilla.mozilla.org/show_bug.cgi?id=263844 Attachment 162257: set opener on opened windows diverted into tabs https://bugzilla.mozilla.org/attachment.cgi?id=162257&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky. Dan, thanks for doing this! I really wish we could factor some of this code that's being copied f...

Web resources about - superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173795] equivalent for firefox - netscape.mozilla.reviewers

Resources last updated: 11/26/2015 9:08:22 AM