superreview granted: [Bug 250006] Remove tabbable from dom interfaces & clean up tab navigation code : [Attachment 153053] Clean up GetNextTabbableContent(). Remove tabbable property from DOM interfa

Johnny Stenback <jst@mozilla.jstenback.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 250006: Remove tabbable from dom interfaces & clean up tab navigation code
http://bugzilla.mozilla.org/show_bug.cgi?id=250006

Attachment 153053: Clean up GetNextTabbableContent(). Remove tabbable property
from DOM interfaces. Gets rid of some ugly callbacks. Clean up spurious focus
outlines (bug 250858.) 
http://bugzilla.mozilla.org/attachment.cgi?id=153053&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
- In nsEventStateManager::TabIndexFrom():

+   nsAutoString tabIndexStr;
+   aFrom->GetAttr(kNameSpaceID_None, nsHTMLAtoms::tabindex, tabIndexStr);
+   if (!tabIndexStr.IsEmpty()) {
+     PRInt32 ec, tabIndexVal = tabIndexStr.ToInteger(&ec);
+     if (NS_SUCCEEDED(ec))
+	*aOutIndex = tabIndexVal;

Don't we want to check for the tabindex attribute only for HTML and XUL (and
SVG?), doesn't seem like it's right to check for any random namespaced element.
Or is this only called if the element is focusable?

sr=jst
0
bugzilla
7/22/2004 11:23:12 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
391 Views

Similar Articles

[PageSpeed] 14

Reply:

Similar Artilces:

superreview requested: [Bug 250006] Remove tabbable from dom interfaces & clean up tab navigation code : [Attachment 153053] Clean up GetNextTabbableContent(). Remove tabbable property from DOM inter
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 250006: Remove tabbable from dom interfaces & clean up tab navigation code http://bugzilla.mozilla.org/show_bug.cgi?id=250006 Attachment 153053: Clean up GetNextTabbableContent(). Remove tabbable property from DOM interfaces. Gets rid of some ugly callbacks. Clean up spurious focus outlines (bug 250858.) http://bugzilla.mozilla.org/attachment.cgi?id=153053&action=edit ...

superreview granted: [Bug 250006] Remove tabbable from dom interfaces & clean up tab navigation code : [Attachment 154368] Neil's fix, which I believe makes sense
Johnny Stenback <jst@mozilla.jstenback.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 250006: Remove tabbable from dom interfaces & clean up tab navigation code http://bugzilla.mozilla.org/show_bug.cgi?id=250006 Attachment 154368: Neil's fix, which I believe makes sense http://bugzilla.mozilla.org/attachment.cgi?id=154368&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview requested: [Bug 250006] Remove tabbable from dom interfaces & clean up tab navigation code : [Attachment 154368] Neil's fix, which I believe makes sense
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 250006: Remove tabbable from dom interfaces & clean up tab navigation code http://bugzilla.mozilla.org/show_bug.cgi?id=250006 Attachment 154368: Neil's fix, which I believe makes sense http://bugzilla.mozilla.org/attachment.cgi?id=154368&action=edit ...

superreview requested: [Bug 250006] Remove tabbable from dom interfaces & clean up tab navigation code : [Attachment 154368] Neil's fix, which I believe makes sense #2
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 250006: Remove tabbable from dom interfaces & clean up tab navigation code http://bugzilla.mozilla.org/show_bug.cgi?id=250006 Attachment 154368: Neil's fix, which I believe makes sense http://bugzilla.mozilla.org/attachment.cgi?id=154368&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I claim this patch as mine as per comment #11, seeking reviews. ...

superreview granted: [Bug 240309] Remove \n from JavaScript [error:\n|warning:\n] : [Attachment 145942] Remove extra '\n's and clean this code up a bit (debug only).
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 240309: Remove \n from JavaScript [error:\n|warning:\n] http://bugzilla.mozilla.org/show_bug.cgi?id=240309 Attachment 145942: Remove extra '\n's and clean this code up a bit (debug only). http://bugzilla.mozilla.org/attachment.cgi?id=145942&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview granted: [Bug 351443] Remove unused code from mozilla/security/nss/lib/jar : [Attachment 236819] Patch to remove unused code
Alexei Volkov <alexei.volkov.bugs@sun.com> has granted Ehsan Akhgari <ehsan.akhgari@gmail.com>'s request for superreview: Bug 351443: Remove unused code from mozilla/security/nss/lib/jar https://bugzilla.mozilla.org/show_bug.cgi?id=351443 Attachment 236819: Patch to remove unused code https://bugzilla.mozilla.org/attachment.cgi?id=236819&action=edit ...

superreview granted: [Bug 339421] Remove the CardChild rdf property from address book. : [Attachment 223554] Remove the redundant code
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 339421: Remove the CardChild rdf property from address book. https://bugzilla.mozilla.org/show_bug.cgi?id=339421 Attachment 223554: Remove the redundant code https://bugzilla.mozilla.org/attachment.cgi?id=223554&action=edit ...

superreview granted: [Bug 281744] Remove dead code and silly plugin code : [Attachment 173910] Remove silly code
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 281744: Remove dead code and silly plugin code https://bugzilla.mozilla.org/show_bug.cgi?id=281744 Attachment 173910: Remove silly code https://bugzilla.mozilla.org/attachment.cgi?id=173910&action=edit ...

superreview granted: [Bug 335450] Remove our extensions to the SVG DOM interfaces : [Attachment 219812] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Jonathan Watt <jwatt@jwatt.org>'s request for superreview: Bug 335450: Remove our extensions to the SVG DOM interfaces https://bugzilla.mozilla.org/show_bug.cgi?id=335450 Attachment 219812: patch https://bugzilla.mozilla.org/attachment.cgi?id=219812&action=edit ...

superreview granted: [Bug 340152] Remove nsISVGMarkerFrame interface : [Attachment 224238] remove interface
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340152: Remove nsISVGMarkerFrame interface https://bugzilla.mozilla.org/show_bug.cgi?id=340152 Attachment 224238: remove interface https://bugzilla.mozilla.org/attachment.cgi?id=224238&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Make PaintMark and RegionMark nonvirtual, and r+sr=roc ...

superreview granted: [Bug 341021] Remove nsISVGOuterSVGFrame interface : [Attachment 225088] remove interface
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 341021: Remove nsISVGOuterSVGFrame interface https://bugzilla.mozilla.org/show_bug.cgi?id=341021 Attachment 225088: remove interface https://bugzilla.mozilla.org/attachment.cgi?id=225088&action=edit ...

superreview granted: [Bug 398706] DOM Inspector DOM tree viewer context menu does not have access keys : [ Attachment 293527] Remove the duplicate menu item
neil@parkwaycc.co.uk <neil@httl.net> has granted Ehsan Akhgari <ehsan.akhgari@gmail.com>'s request for superreview: Bug 398706: DOM Inspector DOM tree viewer context menu does not have access keys https://bugzilla.mozilla.org/show_bug.cgi?id=398706 Attachment 293527: Remove the duplicate menu item https://bugzilla.mozilla.org/attachment.cgi?id=293527&action=edit ...

superreview granted: [Bug 351510] Remove USE_MOZ_THREAD code from mozilla/security/lib/jar : [Attachment 237308] Remove usage of USE_MOZ_THREAD and correct manifest.mn (revised)
Alexei Volkov <alexei.volkov.bugs@sun.com> has granted Ehsan Akhgari <ehsan.akhgari@gmail.com>'s request for superreview: Bug 351510: Remove USE_MOZ_THREAD code from mozilla/security/lib/jar https://bugzilla.mozilla.org/show_bug.cgi?id=351510 Attachment 237308: Remove usage of USE_MOZ_THREAD and correct manifest.mn (revised) https://bugzilla.mozilla.org/attachment.cgi?id=237308&action=edit ...

superreview granted: [Bug 266603] Crash when quickly alt+tabbing between Mozilla and HPR : [Attachment 163779] Remove unneeded code.
Henry Jia <Henry.Jia@sun.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 266603: Crash when quickly alt+tabbing between Mozilla and HPR https://bugzilla.mozilla.org/show_bug.cgi?id=266603 Attachment 163779: Remove unneeded code. https://bugzilla.mozilla.org/attachment.cgi?id=163779&action=edit ...

Web resources about - superreview granted: [Bug 250006] Remove tabbable from dom interfaces & clean up tab navigation code : [Attachment 153053] Clean up GetNextTabbableContent(). Remove tabbable property from DOM interfa - netscape.mozilla.reviewers

Resources last updated: 1/4/2016 2:38:10 PM