superreview granted: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer

Darin Fisher (IBM) <darin@meer.net> has granted Christian Persch
<chpe@gnome.org>'s request for superreview:
Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after
g_object_unref()ing it
http://bugzilla.mozilla.org/show_bug.cgi?id=249903

Attachment 152362: updated patch as requested by the reviewer
http://bugzilla.mozilla.org/attachment.cgi?id=152362&action=edit

------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
>Index: nsGNOMERegistry.cpp

>+  return isEnabled ? PR_TRUE : PR_FALSE;

    return isEnabled != FALSE;


sr=darin with that change.
0
bugzilla
7/7/2004 1:14:32 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
456 Views

Similar Articles

[PageSpeed] 1

Reply:

Similar Artilces:

superreview requested: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (out of town June 14 -- July 11, no email then) <bzbarsky@mit.edu> for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152362: updated patch as requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=152362&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Carrying forward bryner's r+, and asking for sr ...

superreview requested: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152359] proposed fix
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (out of town June 14 -- July 11, no email then) <bzbarsky@mit.edu> for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152359: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=152359&action=edit ...

superreview cancelled: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152359] proposed fix
Christian Persch <chpe@gnome.org> has cancelled Christian Persch <chpe@gnome.org>'s request for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152359: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=152359&action=edit ...

superreview granted: [Bug 227986] EmbedPrompter should use GtkComboBox on gtk+ 2.4 : [Attachment 137398] updated patch with the changes requested by the reviewer
Christopher Blizzard <blizzard@mozilla.org> has granted Christopher Blizzard <blizzard@mozilla.org>'s request for superreview: Bug 227986: EmbedPrompter should use GtkComboBox on gtk+ 2.4 http://bugzilla.mozilla.org/show_bug.cgi?id=227986 Attachment 137398: updated patch with the changes requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=137398&action=edit ...

superreview granted: [Bug 172077] Need a way for embedders to disable all plugins : [Attachment 151288] updated patch with change requested by the reviewer
Scott MacGregor <mscott@mozilla.org> has granted Christian Persch <chpe@gnome.org>'s request for superreview: Bug 172077: Need a way for embedders to disable all plugins http://bugzilla.mozilla.org/show_bug.cgi?id=172077 Attachment 151288: updated patch with change requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=151288&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> plussing since bz said this is ok :) ...

superreview granted: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 163203] Updated patch addressing review comments
Mike Pinkerton <pinkerton@aol.net> has granted Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 250386: Camino should look for user defined earchURLList.plist first before using the default list. https://bugzilla.mozilla.org/show_bug.cgi?id=250386 Attachment 163203: Updated patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=163203&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> + NSString *defaultSearchEngineList = [[NSBundle mainBundle] pathForResource:@"SearchU...

superreview requested: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 163203] Updated patch addressing review comments
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 250386: Camino should look for user defined earchURLList.plist first before using the default list. https://bugzilla.mozilla.org/show_bug.cgi?id=250386 Attachment 163203: Updated patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=163203&action=edit ------- Additional Comments from Ludovic Hirlimann <qa-mozilla@hirlimann.net> asking for sr ...

superreview granted: [Bug 361901] Save Page menuitem label missing from File menu when DM is open : [Attachment 247269] Updated patch that addresses review comments (and not using strres.js)
Stefan <stefanh@bluebottle.com> has granted superreview: Bug 361901: Save Page menuitem label missing from File menu when DM is open https://bugzilla.mozilla.org/show_bug.cgi?id=361901 Attachment 247269: Updated patch that addresses review comments (and not using strres.js) https://bugzilla.mozilla.org/attachment.cgi?id=247269&action=edit ------- Additional Comments from Stefan <stefanh@bluebottle.com> This fixes the review comments and is without strres.js. I think we should do this for trunk as well - I'll try to fix the rest of the issues in the 1.9. Anyw...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 293819: patch, v.1.4, updated based on review comments https://bugzilla.mozilla.org/attachment.cgi?id=293819&action=edit ...

superreview requested: [Bug 172077] Need a way for embedders to disable all plugins : [Attachment 151288] updated patch with change requested by the reviewer
Christian Persch <chpe@gnome.org> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 172077: Need a way for embedders to disable all plugins http://bugzilla.mozilla.org/show_bug.cgi?id=172077 Attachment 151288: updated patch with change requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=151288&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> carrying forward bzbarsky's r+, and asking for sr ...

superreview granted: [Bug 230466] Saving an attachment does not bring up a stand alone progress window : [Attachment 139947] updated patch with review comments
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 230466: Saving an attachment does not bring up a stand alone progress window http://bugzilla.mozilla.org/show_bug.cgi?id=230466 Attachment 139947: updated patch with review comments http://bugzilla.mozilla.org/attachment.cgi?id=139947&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward the sr ...

superreview requested: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for review
Randell Jesup <rjesup@wgate.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 193011: Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 http://bugzilla.mozilla.org/show_bug.cgi?id=193011 Attachment 129377: Updated patch for review http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit ...

superreview requested: [Bug 205893] ImageLib uses GDI handles inappropriately; malicious page can crash mozilla, windows : [Attachment 142279] Patch to use DIB sections, updated
Stefan Ring <sring@gmx.net> has asked tor@acm.org for superreview: Bug 205893: ImageLib uses GDI handles inappropriately; malicious page can crash mozilla, windows http://bugzilla.mozilla.org/show_bug.cgi?id=205893 Attachment 142279: Patch to use DIB sections, updated http://bugzilla.mozilla.org/attachment.cgi?id=142279&action=edit ...

superreview requested: [Bug 360109] make suiterunner help use SeaMonkey theme icons : [Attachment 246927] patch v2.1: classic+modern patch, updated to match new bug 361096 patch
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 360109: make suiterunner help use SeaMonkey theme icons https://bugzilla.mozilla.org/show_bug.cgi?id=360109 Attachment 246927: patch v2.1: classic+modern patch, updated to match new bug 361096 patch https://bugzilla.mozilla.org/attachment.cgi?id=246927&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This patch is updated to match recent changes in my patch for bug 361096 - we're using the :not() stuff as well for the overrides, an...

Web resources about - superreview granted: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer - netscape.mozilla.reviewers

Resources last updated: 12/29/2015 6:06:20 AM