superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup

Robert O'Callahan <roc@ocallahan.org> has granted neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761

Attachment 149404: Cleanup
http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit
0
bugzilla
5/28/2004 2:31:37 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
518 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Whoops, I accidentally mixed up part of this with another patch. Someone please ...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Robert O'Callahan <roc@ocallahan.org> has granted Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> + if (mComboBoxFrame != nsnull) { should be + if (...

superreview cancelled: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Simon Paquet (back in business) <bugzilla@babylonsounds.com> has cancelled Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ------- Additional Comments from Simon Paquet (back in business) <bugzilla@babylonsounds.com> ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149525] Work around focus issue
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Richard Suitor <rsuitor@acm.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149525: Work around focus issue http://bugzilla.mozilla.org/attachment.cgi?id=149525&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview granted: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu>'s request for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> looks quite straighforward :-) ...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview granted: [Bug 283345] Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode : [Attachment 175337] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 283345: Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode https://bugzilla.mozilla.org/show_bug.cgi?id=283345 Attachment 175337: Patch https://bugzilla.mozilla.org/attachment.cgi?id=175337&action=edit ...

superreview requested: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> roc, what do you think? ...

superreview granted: [Bug 391994] [FIX]Building a <select> via DOM doesn' t select the right options
Jonas Sicking <jonas@sicking.cc> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 391994: [FIX]Building a <select> via DOM doesn't select the right options https://bugzilla.mozilla.org/show_bug.cgi?id=391994 Attachment 276446: Fix https://bugzilla.mozilla.org/attachment.cgi?id=276446&action=edit ...

superreview granted: [Bug 277724] [FIX]<select> and <textarea> don't restore disabled state : [Attachment 245370] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 277724: [FIX]<select> and <textarea> don't restore disabled state https://bugzilla.mozilla.org/show_bug.cgi?id=277724 Attachment 245370: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245370&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> - In nsHTMLTextAreaElement::BeforeSetAttr(): + if (aNotify && aNameSpaceID == kNameSpaceID_None && + aName == nsHTMLAtoms::disabled) { +...

superreview granted: [Bug 239275] select object's onchange event fires without change : [Attachment 164657] patch that isn't malformed
Brian Ryner (IBM) <bryner@brianryner.com> has granted Brian Ryner (IBM) <bryner@brianryner.com>'s request for superreview: Bug 239275: select object's onchange event fires without change https://bugzilla.mozilla.org/show_bug.cgi?id=239275 Attachment 164657: patch that isn't malformed https://bugzilla.mozilla.org/attachment.cgi?id=164657&action=edit ...

Web resources about - superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup - netscape.mozilla.reviewers

Resources last updated: 12/27/2015 6:06:48 AM