superreview granted: [Bug 117738] {ib} <dl> within <font> nested in <table> is ignored : [Attachment 170839] patch v1Johnny Stenback <jst@mozilla.jstenback.com> has granted Blake Kaplan
<mrbkap@gmail.com>'s request for superreview:
Bug 117738: {ib} <dl> within <font> nested in <table> is ignored
https://bugzilla.mozilla.org/show_bug.cgi?id=117738
Attachment 170839: patch v1
https://bugzilla.mozilla.org/attachment.cgi?id=170839&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
+ eHTMLTags thePrevTag = eHTMLTag_unknown;
+
+ for(thePos = aContext.GetCount() - 1; thePos >= aIndex; thePos--) {
+ thePrevTag = a...
superreview requested: [Bug 117738] {ib} <dl> within <font> nested in <table> is ignored : [Attachment 170839] patch v1Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback
<jst@mozilla.jstenback.com> for superreview:
Bug 117738: {ib} <dl> within <font> nested in <table> is ignored
https://bugzilla.mozilla.org/show_bug.cgi?id=117738
Attachment 170839: patch v1
https://bugzilla.mozilla.org/attachment.cgi?id=170839&action=edit
...
superreview granted: [Bug 290081] font size can override <hN> tags if more than one <font> is opened incorrectly : [Attachment 180559] patch v1rbs@maths.uq.edu.au has granted Blake Kaplan <mrbkap@gmail.com>'s request for
superreview:
Bug 290081: font size can override <hN> tags if more than one <font> is opened
incorrectly
https://bugzilla.mozilla.org/show_bug.cgi?id=290081
Attachment 180559: patch v1
https://bugzilla.mozilla.org/attachment.cgi?id=180559&action=edit
------- Additional Comments from rbs@maths.uq.edu.au
sr=rbs
+ while (count-- > 0) {
To speedup understanding, I would have preferred (in this context)
+ while (--count >= 0) {
but...
...
superreview granted: [Bug 293070] [FIX]Ordered lists (<ol> tags) inside <font> display all 0s : [Attachment 183742] PatchDavid Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky (gone June
3 -- June 30) <bzbarsky@mit.edu>'s request for superreview:
Bug 293070: [FIX]Ordered lists (<ol> tags) inside <font> display all 0s
https://bugzilla.mozilla.org/show_bug.cgi?id=293070
Attachment 183742: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=183742&action=edit
...
superreview requested: [Bug 293070] Ordered lists (<ol> tags) inside <font> display all 0s : [Attachment 183742] PatchBoris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has asked David Baron
<dbaron@mozillafoundation.org> for superreview:
Bug 293070: Ordered lists (<ol> tags) inside <font> display all 0s
https://bugzilla.mozilla.org/show_bug.cgi?id=293070
Attachment 183742: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=183742&action=edit
------- Additional Comments from Boris Zbarsky (gone June 3 -- June 30)
<bzbarsky@mit.edu>
We're looking at the wrong content node when we hit the <font>'s blockframe as
we're recursively renumberi...
superreview granted: [Bug 204615] Editor hangs when pasting a list fragment <LI> in <DL>, <UL> or <OL> : [Attachment 171288] patch v1Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz
<dveditz@cruzio.com>'s request for superreview:
Bug 204615: Editor hangs when pasting a list fragment <LI> in <DL>, <UL> or
<OL>
https://bugzilla.mozilla.org/show_bug.cgi?id=204615
Attachment 171288: patch v1
https://bugzilla.mozilla.org/attachment.cgi?id=171288&action=edit
------- Additional Comments from Daniel Veditz <dveditz@cruzio.com>
sr=dveditz. Really should have an editor peer review, but I guess this is
trivial enough.
...
superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 185098: Font style ignored if <option selected="selected"> in a <select>
that contains an optgroup
http://bugzilla.mozilla.org/show_bug.cgi?id=185098
Attachment 154999: Patch rev. 1
http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Yeah, this is reasonable. r+sr=bzbarsky.
For future reference, using more context and the -p option makes the diff...
superreview granted: [Bug 293224] [FIX]Matrix from getScreenCTM should be to initial viewport space : [Attachment 194961] patchT Rowley (IBM) <tor@acm.org> has granted Jonathan Watt
<jonathan.watt@strath.ac.uk>'s request for superreview:
Bug 293224: [FIX]Matrix from getScreenCTM should be to initial viewport space
https://bugzilla.mozilla.org/show_bug.cgi?id=293224
Attachment 194961: patch - include currentScale and Translate for
<svg><svg></svg></svg>
https://bugzilla.mozilla.org/attachment.cgi?id=194961&action=edit
...
superreview granted: [Bug 238989] whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags : [Attachment 145302] This should fix itPeter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 238989: whitespace after a </b> tag is ignored when enclosed inside
<fieldset></fieldset> tags
http://bugzilla.mozilla.org/show_bug.cgi?id=238989
Attachment 145302: This should fix it
http://bugzilla.mozilla.org/attachment.cgi?id=145302&action=edit
------- Additional Comments from Peter Van der Beken <peterv@propagandism.org>
Fine by me, although I don't really understand why we'd want kOmitWS at all.
...
superreview granted: [Bug 237658] In <pref-fonts.js>, "Warning: redeclaration of var dataEls" : [Attachment 146099] (Av1d) <pref-fonts.js>jag (Peter Annema) <jag@tty.nl> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 237658: In <pref-fonts.js>, "Warning: redeclaration of var dataEls"
http://bugzilla.mozilla.org/show_bug.cgi?id=237658
Attachment 146099: (Av1d) <pref-fonts.js>
http://bugzilla.mozilla.org/attachment.cgi?id=146099&action=edit
...
superreview granted: [Bug 226955] Bug 197315, </xpfe/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 138662] (Bv1b) <about.*>Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s
request for superreview:
Bug 226955: Bug 197315, </xpfe/*> files: Convert <window class="dialog"> to
<dialog>
http://bugzilla.mozilla.org/show_bug.cgi?id=226955
Attachment 138662: (Bv1b) <about.*>
http://bugzilla.mozilla.org/attachment.cgi?id=138662&action=edit
------- Additional Comments from Alec Flett <alecf@flett.org>
that's more like it.
assuming we don't need the id's for the frames,
sr=alecf
...
superreview granted: [Bug 226956] Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 136897] (Av3) <sendProgress.*>David Bienvenu <bienvenu@nventure.com> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 226956: Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to
<dialog>
http://bugzilla.mozilla.org/show_bug.cgi?id=226956
Attachment 136897: (Av3) <sendProgress.*>
http://bugzilla.mozilla.org/attachment.cgi?id=136897&action=edit
...
superreview granted: [Bug 226955] Bug 197315, </xpfe/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 136899] (Av2b) <pageInfo.*>jag (Peter Annema) <jag@tty.nl> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 226955: Bug 197315, </xpfe/*> files: Convert <window class="dialog"> to
<dialog>
http://bugzilla.mozilla.org/show_bug.cgi?id=226955
Attachment 136899: (Av2b) <pageInfo.*>
http://bugzilla.mozilla.org/attachment.cgi?id=136899&action=edit
------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
sr=jag
...
superreview granted: [Bug 226955] Bug 197315, </xpfe/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 141447] (Cv1) <pageInfo.*> .accesskey/.key additionjag (Peter Annema) <jag@tty.nl> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 226955: Bug 197315, </xpfe/*> files: Convert <window class="dialog"> to
<dialog>
http://bugzilla.mozilla.org/show_bug.cgi?id=226955
Attachment 141447: (Cv1) <pageInfo.*> .accesskey/.key addition
http://bugzilla.mozilla.org/attachment.cgi?id=141447&action=edit
------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
sr=jag
...