superreview granted: [Bug 236365] ftp date is off by one year : [Attachment 157769] A patch to mozilla\netwerk\streamconv\converters\ParseFTPList.cpp to fix the off-by-one-year bug

Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> has granted Boris
Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu>'s request for superreview:
Bug 236365: ftp date is off by one year
http://bugzilla.mozilla.org/show_bug.cgi?id=236365

Attachment 157769: A patch to
mozilla\netwerk\streamconv\converters\ParseFTPList.cpp to fix the
off-by-one-year bug
http://bugzilla.mozilla.org/attachment.cgi?id=157769&action=edit

------- Additional Comments from Boris Zbarsky (no tree till Sept 10)
<bzbarsky@mit.edu>
Darin, what do you think?  The reasoning makes sense to me, so...  Though it
may be better to do <<5 than *100.
0
bugzilla
9/3/2004 5:12:57 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
512 Views

Similar Articles

[PageSpeed] 3

Reply:

Similar Artilces:

superreview granted: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Would be nice to have this in cairo as well. Someone else's problem I guess. ...

superreview requested: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This should be the last patch, honest! ;) ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

superreview granted: [Bug 232120] Now NetBSD have pthread support, but mozilla can't properly configure : [Attachment 139837] patch to fix this bug
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 232120: Now NetBSD have pthread support, but mozilla can't properly configure http://bugzilla.mozilla.org/show_bug.cgi?id=232120 Attachment 139837: patch to fix this bug http://bugzilla.mozilla.org/attachment.cgi?id=139837&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> sr=darin ...

superreview granted: [Bug 300027] [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 300027: [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text https://bugzilla.mozilla.org/show_bug.cgi?id=300027 Attachment 188859: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=188859&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Looks good to me, sr=darin ...

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178870] patch stage 1, review nits fixed
Robert Kaiser <kairo@kairo.at> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 178870: patch stage 1, review nits fixed https://bugzilla.mozilla.org/attachment.cgi?id=178870&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> OK, this is the stage 1 patch with the review nits fixed. I still need input if it builds OK on windows and mac before I check it in though (linux was tes...

superreview granted: [Bug 124282] ASSERTION: no m_path, see bugs #57659 and #72317: 'm_path', file /home/timeless/mozilla/mailnews/news/src/nsNNTPProtocol.cpp, line 2180 : [Attachment 69104] Patch wh
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 124282: ASSERTION: no m_path, see bugs #57659 and #72317: 'm_path', file /home/timeless/mozilla/mailnews/news/src/nsNNTPProtocol.cpp, line 2180 https://bugzilla.mozilla.org/show_bug.cgi?id=124282 Attachment 69104: Patch which updates the assertion to point to bug 73920 and bug 72320. https://bugzilla.mozilla.org/attachment.cgi?id=69104&action=edit ...

superreview granted: [Bug 309307] WARNING: NS_ENSURE_TRUE(scount != 0) failed, file ../../../../../mozilla/parser/htmlparser/src/nsDTDUtils.cpp, line 297 : [Attachment 197879] Fix the bogus patch
Johnny Stenback <jst@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 309307: WARNING: NS_ENSURE_TRUE(scount != 0) failed, file .../../../../../mozilla/parser/htmlparser/src/nsDTDUtils.cpp, line 297 https://bugzilla.mozilla.org/show_bug.cgi?id=309307 Attachment 197879: Fix the bogus patch https://bugzilla.mozilla.org/attachment.cgi?id=197879&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 268480] ###!!! ASSERTION: cannot set user:pass on no-auth url: 'Error', file r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121 : [Attachment 165241] v1 patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 268480: ###!!! ASSERTION: cannot set user:pass on no-auth url: 'Error', file r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121 https://bugzilla.mozilla.org/show_bug.cgi?id=268480 Attachment 165241: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=165241&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky. Thanks! ...

superreview requested: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Brendan Eich <brendan@mozilla.org> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ...

superreview granted: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

superreview cancelled: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has cancelled Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ...

superreview granted: [Bug 274264] Japanese attachment file name garbled, after fix for Bug 243504 and Bug 263462 : [Attachment 170900] updated patch
Darin Fisher (IBM) <darin@meer.net> has granted Jungshik Shin <jshin@i18nl10n.com>'s request for superreview: Bug 274264: Japanese attachment file name garbled, after fix for Bug 243504 and Bug 263462 https://bugzilla.mozilla.org/show_bug.cgi?id=274264 Attachment 170900: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=170900&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr=darin ...

Web resources about - superreview granted: [Bug 236365] ftp date is off by one year : [Attachment 157769] A patch to mozilla\netwerk\streamconv\converters\ParseFTPList.cpp to fix the off-by-one-year bug - netscape.mozilla.reviewers

Resources last updated: 1/18/2016 3:53:42 AM