superreview granted: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Mike
Connor <mconnor@steelgryphon.com>'s request for superreview:
Bug 229737: [RFE] Favicons for XUL error pages
https://bugzilla.mozilla.org/show_bug.cgi?id=229737

Attachment 193389: address Neil's comments, fix seamonkey's check
https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
>-  var url = getWebNavigation().currentURI.spec
>+  var url = document.documentURI.spec
Actually you need
var url = content.document.documentURI;
0
bugzilla
8/21/2005 11:46:53 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
680 Views

Similar Articles

[PageSpeed] 35

Reply:

Similar Artilces:

superreview requested: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check
Mike Connor <mconnor@steelgryphon.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 229737: [RFE] Favicons for XUL error pages https://bugzilla.mozilla.org/show_bug.cgi?id=229737 Attachment 193389: address Neil's comments, fix seamonkey's check https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit ------- Additional Comments from Mike Connor <mconnor@steelgryphon.com> this addresses all but the 256 color-safe issue, which is an edge case ...

superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 162166: fix review comments https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over r/sr, seeking branch approval. jst wants this for the plugin finder ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 263182] Page Info (Security tab) doesn't explain mixed secure/insecure : [Attachment 193950] Patch with Neil's comments addressed
Gavin Sharp <gavin.sharp@gmail.com> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 263182: Page Info (Security tab) doesn't explain mixed secure/insecure https://bugzilla.mozilla.org/show_bug.cgi?id=263182 Attachment 193950: Patch with Neil's comments addressed https://bugzilla.mozilla.org/attachment.cgi?id=193950&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 326676] Fix default index setting.
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=3D370306 Attachment 326676: Fix default index setting. https://bugzilla.mozilla.org/attachment.cgi?id=3D326676&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ else=0D >+ result.searchResult =3D ACR.RESULT_NOMATCH;=0D I don't sup...

superreview granted: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's comments
Scott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 232722: change 'character coding' to 'character encoding' http://bugzilla.mozilla.org/show_bug.cgi?id=232722 Attachment 140854: Addressed jshin's comments http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> sorry, I didn't notice this bug had two patches in it needing review. ...

superreview granted: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, chang
Johnny Stenback <jst@mozilla.jstenback.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change http://bugzilla.mozilla.org/show_bug.cgi?id=242760 Attachment 147787: store rc's so ifs can check, drop temporary comptr, change comment, check alloc http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - element->Append...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 163330: corrects neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit ...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Looks good. That said, s...

superreview denied: [Bug 68841] We don't underline accesskeys for XUL checkboxes or radiobuttons : [Attachment 158802] Address Neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has denied Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 68841: We don't underline accesskeys for XUL checkboxes or radiobuttons http://bugzilla.mozilla.org/show_bug.cgi?id=68841 Attachment 158802: Address Neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=158802&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >-[scriptable, uuid(f68136d6-1dd1-11b2-a184-a55a337e8507)] >+[scriptable, uuid(c9...

superreview requested: [Bug 68841] We don't underline accesskeys for XUL checkboxes or radiobuttons : [Attachment 158802] Address Neil's comments
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 68841: We don't underline accesskeys for XUL checkboxes or radiobuttons http://bugzilla.mozilla.org/show_bug.cgi?id=68841 Attachment 158802: Address Neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=158802&action=edit ...

superreview granted: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ...

superreview granted: [Bug 92686] Return inserts line break, should insert paragraph break : [Attachment 156598] fix #3, in answer to brade's and akkana's comments
Johnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 92686: Return inserts line break, should insert paragraph break https://bugzilla.mozilla.org/show_bug.cgi?id=92686 Attachment 156598: fix #3, in answer to brade's and akkana's comments https://bugzilla.mozilla.org/attachment.cgi?id=156598&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst (and marking brade's r+ too, I'll attach a patch that fixes the issue she comme...

superreview granted: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ...

superreview granted: [Bug 282615] DOMSerializer's security checks don't take capabilities into account. : [Attachment 174606] Fix (diff -w for reviews)
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 282615: DOMSerializer's security checks don't take capabilities into account. https://bugzilla.mozilla.org/show_bug.cgi?id=282615 Attachment 174606: Fix (diff -w for reviews) https://bugzilla.mozilla.org/attachment.cgi?id=174606&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

superreview requested: [Bug 68841] We don't underline accesskeys for XUL checkboxes or radiobuttons : [Attachment 158882] Addresses Neil's 2nd set of comments
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 68841: We don't underline accesskeys for XUL checkboxes or radiobuttons http://bugzilla.mozilla.org/show_bug.cgi?id=68841 Attachment 158882: Addresses Neil's 2nd set of comments http://bugzilla.mozilla.org/attachment.cgi?id=158882&action=edit ...

superreview cancelled: [Bug 68841] We don't underline accesskeys for XUL checkboxes or radiobuttons : [Attachment 158882] Addresses Neil's 2nd set of comments
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 68841: We don't underline accesskeys for XUL checkboxes or radiobuttons http://bugzilla.mozilla.org/show_bug.cgi?id=68841 Attachment 158882: Addresses Neil's 2nd set of comments http://bugzilla.mozilla.org/attachment.cgi?id=158882&action=edit ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview cancelled: [Bug 301737] Support multiple selection for xul:listbox : [Attachment 190356] Address Neil's comments, although I don't know what ctrl+shift is supposed to do
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 301737: Support multiple selection for xul:listbox https://bugzilla.mozilla.org/show_bug.cgi?id=301737 Attachment 190356: Address Neil's comments, although I don't know what ctrl+shift is supposed to do https://bugzilla.mozilla.org/attachment.cgi?id=190356&action=edit ...

superreview requested: [Bug 301737] Support multiple selection for xul:listbox : [Attachment 190356] Address Neil's comments, although I don't know what ctrl+shift is supposed to do
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 301737: Support multiple selection for xul:listbox https://bugzilla.mozilla.org/show_bug.cgi?id=301737 Attachment 190356: Address Neil's comments, although I don't know what ctrl+shift is supposed to do https://bugzilla.mozilla.org/attachment.cgi?id=190356&action=edit ...

superreview granted: [Bug 225809] Don't fall back to insecure authentication if "use secure authentication" is checked : [Attachment 136279] patch addressing mscott's comments
Lorenzo Colitti <lorenzo@colitti.com> has granted Lorenzo Colitti <lorenzo@colitti.com>'s request for superreview: Bug 225809: Don't fall back to insecure authentication if "use secure authentication" is checked http://bugzilla.mozilla.org/show_bug.cgi?id=225809 Attachment 136279: patch addressing mscott's comments http://bugzilla.mozilla.org/attachment.cgi?id=136279&action=edit ------- Additional Comments from Lorenzo Colitti <lorenzo@colitti.com> Carrying forward r= and sr= ...

superreview granted: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
Johnny Stenback <jst@mozilla.org> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst either way... ...

superreview granted: [Bug 206018] ldap connections not close properly, LDAP/SSL triggers internal failure error message. : [Attachment 141830] fix addressing Dan's comments
David Bienvenu <bienvenu@nventure.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 206018: ldap connections not close properly, LDAP/SSL triggers internal failure error message. http://bugzilla.mozilla.org/show_bug.cgi?id=206018 Attachment 141830: fix addressing Dan's comments http://bugzilla.mozilla.org/attachment.cgi?id=141830&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> carrying forward mscott's sr. ...

Web resources about - superreview granted: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check - netscape.mozilla.reviewers

Resources last updated: 3/26/2016 8:08:23 AM