superreview granted: [Bug 228017] UI Consistency: "make default search engine" dialog's button choice is counter-intuitive : [Attachment 145808] correct patch

Alec Flett <alecf@flett.org> has granted Andreas Kunz <durbacher@gmx.de>'s
request for superreview:
Bug 228017: UI Consistency: "make default search engine" dialog's button choice
is counter-intuitive
http://bugzilla.mozilla.org/show_bug.cgi?id=228017

Attachment 145808: correct patch
http://bugzilla.mozilla.org/attachment.cgi?id=145808&action=edit

------- Additional Comments from Alec Flett <alecf@flett.org>
ugh, I think this should be &, not + - obviously it doesn't make a difference
in this case, but this is a bitmask, right?
sr=alecf with & or with a good explanation as to why you're using +
0
bugzilla
4/19/2004 6:46:05 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
404 Views

Similar Articles

[PageSpeed] 10

Reply:

Similar Artilces:

superreview requested: [Bug 228017] UI Consistency: "make default search engine" dialog's button choice is counter-intuitive : [Attachment 145808] correct patch
Andreas Kunz <durbacher@gmx.de> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228017: UI Consistency: "make default search engine" dialog's button choice is counter-intuitive http://bugzilla.mozilla.org/show_bug.cgi?id=228017 Attachment 145808: correct patch http://bugzilla.mozilla.org/attachment.cgi?id=145808&action=edit ------- Additional Comments from Andreas Kunz <durbacher@gmx.de> Requesting sr= from alecf. ...

superreview granted: [Bug 337106] Appending "Search" to the search engine's name doesn't always work well (grey text in the search bar) : [Attachment 224769] Updates the strings
Mike Connor <mconnor@mozilla.com> has granted Joe Hughes <joe@retrovirus.com>'s request for superreview: Bug 337106: Appending "Search" to the search engine's name doesn't always work well (grey text in the search bar) https://bugzilla.mozilla.org/show_bug.cgi?id=337106 Attachment 224769: Updates the strings https://bugzilla.mozilla.org/attachment.cgi?id=224769&action=edit ...

superreview granted: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patch
Darin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 241209: "Show File Location" and "Launch File" buttons (on download progress dialog) don't work http://bugzilla.mozilla.org/show_bug.cgi?id=241209 Attachment 147465: patch http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr=darin ...

superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...

superreview granted: [Bug 283437] [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" : [Attachment 175792] Patch with kherron+mozilla's comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Leon Sha <leon.sha@sun.com>'s request for superreview: Bug 283437: [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" https://bugzilla.mozilla.org/show_bug.cgi?id=283437 Attachment 175792: Patch with kherron+mozilla's comments. https://bugzilla.mozilla.org/attachment.cgi?id=175792&action=edit ...

superreview granted: [Bug 283437] [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" : [Attachment 176857] Patch with kherron+mozilla's comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Leon Sha <leon.sha@sun.com>'s request for superreview: Bug 283437: [Postscript] If the page size is not set correctly, there will be a PostScript error "configurationerror" https://bugzilla.mozilla.org/show_bug.cgi?id=283437 Attachment 176857: Patch with kherron+mozilla's comments. https://bugzilla.mozilla.org/attachment.cgi?id=176857&action=edit ...

superreview granted: [Bug 429718] custom search engine plugin can't be added on 10.4.11; reported as "unavailable" or "unknown format" : [Attachment 320213] Patch
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted superreview: Bug 429718: custom search engine plugin can't be added on 10.4.11; reported as "unavailable" or "unknown format" https://bugzilla.mozilla.org/show_bug.cgi?id=429718 Attachment 320213: Patch https://bugzilla.mozilla.org/attachment.cgi?id=320213&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Reference this bug in the comment so it's clear to someone why we are doing that; sr=smorgan with that change. ...

superreview requested: [Bug 277798] nsIWindowWatcher.openWindow inconsistently applies "dialog" feature : [Attachment 170835] make "dialog" the consistent default
Benjamin Smedberg <bsmedberg@covad.net> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 277798: nsIWindowWatcher.openWindow inconsistently applies "dialog" feature https://bugzilla.mozilla.org/show_bug.cgi?id=277798 Attachment 170835: make "dialog" the consistent default https://bugzilla.mozilla.org/attachment.cgi?id=170835&action=edit ...

superreview granted: [Bug 301688] Disabled buttons shoudn't have a "default button" look&feel : [Attachment 190112] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano (use mozilla.mano@ for email) <bugs.mano@sent.com>'s request for superreview: Bug 301688: Disabled buttons shoudn't have a "default button" look&feel https://bugzilla.mozilla.org/show_bug.cgi?id=301688 Attachment 190112: patch https://bugzilla.mozilla.org/attachment.cgi?id=190112&action=edit ...

superreview granted: [Bug 195224] [views/filter/search] Remove "More" and "Fewer" buttons and add + and
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 195224: [views/filter/search] Remove "More" and "Fewer" buttons and add + and - buttons per line https://bugzilla.mozilla.org/show_bug.cgi?id=195224 Attachment 183120: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=183120&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >+ <listcol flex="&searchTermListButtonsFlexV...

superreview granted: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...

superreview granted: [Bug 157067] Inconsistency in appearance of "Move Up" and "Move Down" buttons : [Attachment 145778] Makes buttons and access keys in Filter List consistent with the rest of Seamo
Scott MacGregor <mscott@mozilla.org> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 157067: Inconsistency in appearance of "Move Up" and "Move Down" buttons http://bugzilla.mozilla.org/show_bug.cgi?id=157067 Attachment 145778: Makes buttons and access keys in Filter List consistent with the rest of Seamonkey http://bugzilla.mozilla.org/attachment.cgi?id=145778&action=edit ...

superreview granted: [Bug 220451] Popup Manager's "Allowed Sites" dialog doesn't persist size and position : [Attachment 132310] Patch
Alec Flett <alecf@flett.org> has granted Stefan Borggraefe <borggraefe@despammed.com>'s request for superreview: Bug 220451: Popup Manager's "Allowed Sites" dialog doesn't persist size and position http://bugzilla.mozilla.org/show_bug.cgi?id=220451 Attachment 132310: Patch http://bugzilla.mozilla.org/attachment.cgi?id=132310&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview granted: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 227622] Add a "Do this automatically from now on" checkbox, v3
Scott MacGregor <mscott@mozilla.org> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox https://bugzilla.mozilla.org/show_bug.cgi?id=198936 Attachment 227622: Add a "Do this automatically from now on" checkbox, v3 https://bugzilla.mozilla.org/attachment.cgi?id=227622&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> +pref("mail.askBeforePurge", true); I'd probably...

Web resources about - superreview granted: [Bug 228017] UI Consistency: "make default search engine" dialog's button choice is counter-intuitive : [Attachment 145808] correct patch - netscape.mozilla.reviewers

What life lessons are counter-intuitive or go against common sense or wisdom? - Quora
The more you learn, the less you know. I think this is true across the board that the more you learn about something, the more your horizons ...

Paul Graham Offers Counter-Intuitive Advice To Startups: 'Do Things That Don't Scale'
Paul Graham, co-founder of top startup accelerator program Y Combinator, has some counter-intuitive advice for founders: do things that don't ...

The Most Counter Intuitive Model To Provide Energy And Sustainability To Small Businesses
When Alexander Bazhinov launched his startup company at UVA's i.Lab incubator at the Darden School of Business, he had a dream: to help small ...

In perhaps the most counter-intuitive scientific finding of recent time, researchers have discovered
In perhaps the most counter-intuitive scientific finding of recent time, researchers have discovered a volcano lurking beneath Antarctica . [ ...

Cloud Concerns: Survey Reveals Some Counter-Intuitive Results
Saugatuck s 2013 Cloud Survey found significant variations in the top concerns that business and IT executives had with regard to the adoption ...

The Counter-Intuitive Way to Win Big in a Game Show
You are on a game show, and get to choose between three doors. Behind one is a grand prize. Behind the others there's nothing. But there's a ...

Counter Intuitive Nudges
... binge drinking and electricity consumption , so why didn’t it work for organ donation? Here’s another peculiar nudge in NYC : A counterintuitive ...

Counter Intuitive
A young chef serves up old-school Parisian fare in a a former butcher shop.

Making sense of Obama’s counter-intuitive approach to negotiations with Iran
(Paul Mirengoff) Last week, President Obama and British Prime Minister Cameron pleaded with Congress not to pass new sanctions legislation against ...

Reason Highlights From RNC Week, and a Counter-intuitive Note of Cockeyed Optimism
The Republican National Convention packed up its booze tents and elaborate security superstructures in the wee hours this morning, as the nation's ...

Resources last updated: 12/6/2015 5:49:41 AM