superreview granted: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away

David Baron <dbaron@dbaron.org> has granted Darin Fisher <darin@meer.net>'s
request for superreview:

Bug 224723: NS_ASSERTION(boxObject, "no box object!"); timer fired after tree
was destroyed
http://bugzilla.mozilla.org/show_bug.cgi?id=224723

Attachment 134790: cancel the timer if the tree goes away
http://bugzilla.mozilla.org/attachment.cgi?id=134790&action=edit

------- Additional Comments from David Baron <dbaron@dbaron.org>
If you use boolean logic rather than nesting ifs, sr=dbaron.
0
bugzilla
11/12/2003 11:10:57 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
393 Views

Similar Articles

[PageSpeed] 56

Reply:

Similar Artilces:

superreview requested: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away
timeless@myrealbox.com <timeless@bemail.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 224723: NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed http://bugzilla.mozilla.org/show_bug.cgi?id=224723 Attachment 134790: cancel the timer if the tree goes away http://bugzilla.mozilla.org/attachment.cgi?id=134790&action=edit ...

superreview requested: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away #2
Darin Fisher <darin@meer.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 224723: NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed http://bugzilla.mozilla.org/show_bug.cgi?id=224723 Attachment 134790: cancel the timer if the tree goes away http://bugzilla.mozilla.org/attachment.cgi?id=134790&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> i defer to dbaron (or one of the other layout sr's). ...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 146534] (Av2) <tree.xml>
jag (Peter Annema) <jag@tty.nl> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 146534: (Av2) <tree.xml> http://bugzilla.mozilla.org/attachment.cgi?id=146534&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> var c = this.currentIndex; - var l = this.treeBoxObject.view.rowCount - 1; + var l = this.v...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 147569] (Av2b) <tree.xml>
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 147569: (Av2b) <tree.xml> http://bugzilla.mozilla.org/attachment.cgi?id=147569&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping: {{ (Av2) <tree.xml> patch 2004-04-19 15:57 PDT varga: review+ jag: super...

superreview canceled: [Bug 424641] Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" : [Attachment 318390] The fix v2
Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com> has canceled Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com>'s request for superreview: Bug 424641: Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" https://bugzilla.mozilla.org/show_bug.cgi?id=424641 Attachment 318390: The fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=318390&action=edit ------- Additional Comments from Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com> Thi...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156642] (Bv1a) <tree.xml> (/Toolkit part)
Mike Connor (really busy through end of Sept) <mconnor@steelgryphon.com> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" https://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156642: (Bv1a) <tree.xml> (/Toolkit part) https://bugzilla.mozilla.org/attachment.cgi?id=156642&action=edit ------- Additional Comments from Mike Connor (really busy through end of Sept) <mconnor@steelgryp...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156684] (Av2c) <tree.xml> (SeaMonkey part)
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156684: (Av2c) <tree.xml> (SeaMonkey part) http://bugzilla.mozilla.org/attachment.cgi?id=156684&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping: {{ (Av2) <tree.xml> patch 2004-04-19 15:57 PDT varga: re...

superreview granted: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Blake Ross <firefox@blakeross.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ...

superreview granted: [Bug 285911] XPrint hardcodes english string with literal "Mozilla" : [Attachment 183036] Just remove "Mozilla" from the string
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 285911: XPrint hardcodes english string with literal "Mozilla" https://bugzilla.mozilla.org/show_bug.cgi?id=285911 Attachment 183036: Just remove "Mozilla" from the string https://bugzilla.mozilla.org/attachment.cgi?id=183036&action=edit ...

superreview cancelled: [Bug 287713] Remove hard-coded "Mozilla" in Help .rdf files : [Attachment 178583] Replace "Mozilla" with &brandShortName; in .rdf files
Stefan <stefan_h@hem.utfors.se> has cancelled Stefan <stefan_h@hem.utfors.se>'s request for superreview: Bug 287713: Remove hard-coded "Mozilla" in Help .rdf files https://bugzilla.mozilla.org/show_bug.cgi?id=287713 Attachment 178583: Replace "Mozilla" with &brandShortName; in .rdf files https://bugzilla.mozilla.org/attachment.cgi?id=178583&action=edit ------- Additional Comments from Stefan <stefan_h@hem.utfors.se> Removing the obsolete request. ...

superreview cancelled: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has cancelled Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ...

superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...

superreview cancelled: [Bug 61911] typeof(/regExp/) should return "object", not "function" : [Attachment 241749] cleanup
Brendan Eich <brendan@mozilla.org> has cancelled Brian Crowder <crowder@fiverocks.com>'s request for superreview: Bug 61911: typeof(/regExp/) should return "object", not "function" https://bugzilla.mozilla.org/show_bug.cgi?id=61911 Attachment 241749: cleanup https://bugzilla.mozilla.org/attachment.cgi?id=241749&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Cool, a one-liner. r+me (no super-review required or even optional typically in js/src -- occasionally someone requests it, but most often cuz bug...

superreview requested: [Bug 171575] Implement "find bookmark" : [Attachment 178832] implement "show in tree"
vladimir@pobox.com has asked Mike Connor <mconnor@steelgryphon.com> for superreview: Bug 171575: Implement "find bookmark" https://bugzilla.mozilla.org/show_bug.cgi?id=171575 Attachment 178832: implement "show in tree" https://bugzilla.mozilla.org/attachment.cgi?id=178832&action=edit ------- Additional Comments from vladimir@pobox.com The patch looks good, thanks! One concern I have is with special-casing the showintree command in bookmarksTree.xml, and just adding it to the end of the menu, etc. Not sure if that's a good plan from a UI perspect...

Web resources about - superreview granted: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away - netscape.mozilla.reviewers

Resources last updated: 1/18/2016 9:16:02 AM