superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes

Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich
<brendan@mozilla.org>'s request for superreview:

Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ]
http://bugzilla.mozilla.org/show_bug.cgi?id=215798

Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes
http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
I wasn't able to test this or run with it, but the change looks good. Hopefully
someone else is able to verify that this fixes the crash.

sr=jst

0
bugzilla
9/17/2003 6:23:16 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
650 Views

Similar Articles

[PageSpeed] 25

Reply:

Similar Artilces:

superreview requested: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Brendan Eich <brendan@mozilla.org> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ js_CloseTokenStream] : [Attachment 131712] proposed fix
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ js_CloseTokenStream] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131712: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=131712&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver (But why doesn't that bite us all the time? Just lucky, and helped by the mostly-single-threaded engine use?) ...

superreview requested: [Bug 215798] Running Venkman crashes Mozilla [@ js_CloseTokenStream] : [Attachment 131712] proposed fix
Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 215798: Running Venkman crashes Mozilla [@ js_CloseTokenStream] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131712: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=131712&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Looking for either or both rginda and shaver to review. More the merrier, for drivers' warm fuzzies. /be ...

superreview granted: [Bug 300027] [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 300027: [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text https://bugzilla.mozilla.org/show_bug.cgi?id=300027 Attachment 188859: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=188859&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Looks good to me, sr=darin ...

superreview granted: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Would be nice to have this in cairo as well. Someone else's problem I guess. ...

superreview granted: [Bug 311646] Fix compile warnings in mozilla/xpinstall : [Attachment 198912] Patch
Benjamin Smedberg [:bs] <benjamin@smedbergs.us> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 311646: Fix compile warnings in mozilla/xpinstall https://bugzilla.mozilla.org/show_bug.cgi?id=311646 Attachment 198912: Patch https://bugzilla.mozilla.org/attachment.cgi?id=198912&action=edit ...

superreview granted: [Bug 425253] stack overflow Marquee testcase from bug 239840 is crashing [@ ntdll.dll] Mozilla again : [Attachment 314446] fix
David Baron [:dbaron] <dbaron@mozilla.com> has granted Robert O'Callahan (:= roc) (reduced activity March 18 to April 9) <roc@ocallahan.org>'s request for superreview: Bug 425253: stack overflow Marquee testcase from bug 239840 is crashing [@ ntdll.dll] Mozilla again https://bugzilla.mozilla.org/show_bug.cgi?id=3D425253 Attachment 314446: fix https://bugzilla.mozilla.org/attachment.cgi?id=3D314446&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> + virtual nsMargin GetDesiredScrollbarSizes(nsPresContext* aPres...

superreview granted: [Bug 232095] [FIX]JS syntax error in XBL binding used twice crashes Mozilla : [Attachment 139958] Possible fix
Brian Ryner <bryner@brianryner.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 232095: [FIX]JS syntax error in XBL binding used twice crashes Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=232095 Attachment 139958: Possible fix http://bugzilla.mozilla.org/attachment.cgi?id=139958&action=edit ...

superreview granted: [Bug 232120] Now NetBSD have pthread support, but mozilla can't properly configure : [Attachment 139837] patch to fix this bug
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 232120: Now NetBSD have pthread support, but mozilla can't properly configure http://bugzilla.mozilla.org/show_bug.cgi?id=232120 Attachment 139837: patch to fix this bug http://bugzilla.mozilla.org/attachment.cgi?id=139837&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> sr=darin ...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

superreview cancelled: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has cancelled Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ...

superreview granted: [Bug 236365] ftp date is off by one year : [Attachment 157769] A patch to mozilla\netwerk\streamconv\converters\ParseFTPList.cpp to fix the off-by-one-year bug
Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> has granted Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu>'s request for superreview: Bug 236365: ftp date is off by one year http://bugzilla.mozilla.org/show_bug.cgi?id=236365 Attachment 157769: A patch to mozilla\netwerk\streamconv\converters\ParseFTPList.cpp to fix the off-by-one-year bug http://bugzilla.mozilla.org/attachment.cgi?id=157769&action=edit ------- Additional Comments from Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> Darin, what do you think? The reasoning makes s...

superreview granted: [Bug 235435] Mozilla 1.7a tends to crash when I attempt to display its Preference Panel. : [Attachment 142186] patch to fix
Johnny Stenback <jst@mozilla.jstenback.com> has granted Jonas Sicking <bugmail@sicking.cc>'s request for superreview: Bug 235435: Mozilla 1.7a tends to crash when I attempt to display its Preference Panel. http://bugzilla.mozilla.org/show_bug.cgi?id=235435 Attachment 142186: patch to fix http://bugzilla.mozilla.org/attachment.cgi?id=142186&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> r+sr=jst ...

superreview granted: [Bug 240627] Add debug warning in Mozilla for Ctrl+Shift+[A-F] shortcuts : [Attachment 198804] Updated for crash fix
Boris Zbarsky <bzbarsky@mit.edu> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 240627: Add debug warning in Mozilla for Ctrl+Shift+[A-F] shortcuts https://bugzilla.mozilla.org/show_bug.cgi?id=240627 Attachment 198804: Updated for crash fix https://bugzilla.mozilla.org/attachment.cgi?id=198804&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Oh, yikes. The comment about using the GetOwnerDoc() URI stands, though (and then the URI doesn't have to be an nsCOMPtr). ...

Web resources about - superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes - netscape.mozilla.reviewers

Resources last updated: 1/14/2016 8:53:40 PM