superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 146534] (Av2) <tree.xml>

jag (Peter Annema) <jag@tty.nl> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error:
this.treeBoxObject.selection has no properties"
http://bugzilla.mozilla.org/show_bug.cgi?id=211046

Attachment 146534: (Av2) <tree.xml>
http://bugzilla.mozilla.org/attachment.cgi?id=146534&action=edit

------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
	  var c = this.currentIndex;
-	  var l = this.treeBoxObject.view.rowCount - 1;
+	   var l = this.view.rowCount - 1;
	  if (c == l)

and

	  var c = this.currentIndex;
-	  try { if (c+1 == this.treeBoxObject.view.rowCount)
-	    return;
+	   try {
+	     if (c+1 == this.view.rowCount)
+	       return;

Indentation nit in several places. Looks like whoever wrote this code in the
first place only indented one space after the <![CDATA[.

Jan, wanna fix that (in a separate checkin perhaps)?

And I agree, get rid of the () around the onset return.

sr=jag with that.
0
bugzilla
5/3/2004 2:19:13 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
445 Views

Similar Articles

[PageSpeed] 23

Reply:

Similar Artilces:

superreview requested: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 146534] (Av2) <tree.xml>
Serge GAUTHERIE <gautheri@noos.fr> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 146534: (Av2) <tree.xml> http://bugzilla.mozilla.org/attachment.cgi?id=146534&action=edit ...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 147569] (Av2b) <tree.xml>
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 147569: (Av2b) <tree.xml> http://bugzilla.mozilla.org/attachment.cgi?id=147569&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping: {{ (Av2) <tree.xml> patch 2004-04-19 15:57 PDT varga: review+ jag: super...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156684] (Av2c) <tree.xml> (SeaMonkey part)
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156684: (Av2c) <tree.xml> (SeaMonkey part) http://bugzilla.mozilla.org/attachment.cgi?id=156684&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping: {{ (Av2) <tree.xml> patch 2004-04-19 15:57 PDT varga: re...

superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156642] (Bv1a) <tree.xml> (/Toolkit part)
Mike Connor (really busy through end of Sept) <mconnor@steelgryphon.com> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" https://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156642: (Bv1a) <tree.xml> (/Toolkit part) https://bugzilla.mozilla.org/attachment.cgi?id=156642&action=edit ------- Additional Comments from Mike Connor (really busy through end of Sept) <mconnor@steelgryp...

superreview requested: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156642] (Bv1a) <tree.xml> (/Toolkit part)
[Checked in: Comment n] Serge GAUTHERIE <gautheri@noos.fr> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156642: (Bv1a) <tree.xml> (/Toolkit part) [Checked in: Comment n] http://bugzilla.mozilla.org/attachment.cgi?id=156642&action=edit ...

superreview requested: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156642] (Bv1a) <tree.xml> (/Toolkit part) #2
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Mike Connor (really busy through end of Sept) <mconnor@steelgryphon.com> for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" https://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156642: (Bv1a) <tree.xml> (/Toolkit part) https://bugzilla.mozilla.org/attachment.cgi?id=156642&action=edit ...

superreview granted: [Bug 121234] In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" : [Attachment 127460] Addressed timeless' comment
jag (Peter Annema) <jaggernaut@netscape.com> has granted neil@parkwaycc.co.uk is offline :-( <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 121234: In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=121234 Attachment 127460: Addressed timeless' comment http://bugzilla.mozilla.org/attachment.cgi?id=127460&action=edit ------- Additional Comments from jag (Peter Annema) <jaggernaut@netscape.com> sr=jag ...

superreview granted: [Bug 104360] In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) : [Attachment 199798
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 104360: In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) https://bugzilla.mozilla.org/show_bug.cgi?id=104360 Attachment 199798: patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=199798&action=edit ...

superreview requested: [Bug 121234] In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" : [Attachment 127438] Proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter Annema) <jaggernaut@netscape.com> for superreview: Bug 121234: In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=121234 Attachment 127438: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=127438&action=edit ...

superreview cancelled: [Bug 121234] In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" : [Attachment 127438] Proposed patch
timeless@myrealbox.com <timeless@bemail.org> has cancelled neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 121234: In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=121234 Attachment 127438: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=127438&action=edit ------- Additional Comments from timeless@myrealbox.com <timeless@bemail.org> please change as discussed ...

superreview requested: [Bug 121234] In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" : [Attachment 127460] Addressed timeless' comment
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter Annema) <jaggernaut@netscape.com> for superreview: Bug 121234: In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=121234 Attachment 127460: Addressed timeless' comment http://bugzilla.mozilla.org/attachment.cgi?id=127460&action=edit ...

superreview cancelled: [Bug 104360] In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) : [Attachment 1997
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 104360: In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) https://bugzilla.mozilla.org/show_bug.cgi?id=104360 Attachment 199761: patch https://bugzilla.mozilla.org/attachment.cgi?id=199761&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I'm not a peer for this module (so can't r=), last I checked. ...

superreview requested: [Bug 104360] In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) : [Attachment 1997 #2
Alex Vincent <ajvincent@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 104360: In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) https://bugzilla.mozilla.org/show_bug.cgi?id=104360 Attachment 199761: patch https://bugzilla.mozilla.org/attachment.cgi?id=199761&action=edit ...

superreview requested: [Bug 104360] In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) : [Attachment 1997 #3
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 104360: In <chrome://global/content/bindings/browser.xml>, "Error: this.docShell has no properties"; (When closing tabs with Site Navigation Bar showed) https://bugzilla.mozilla.org/show_bug.cgi?id=104360 Attachment 199798: patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=199798&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> This patch copies over the change to toolkit/.../browser....

Web resources about - superreview granted: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 146534] (Av2) <tree.xml> - netscape.mozilla.reviewers

Resources last updated: 12/17/2015 5:30:04 PM