superreview granted: [Bug 200644] rework port handling in permissions code : [Attachment 134773] ingore the port

Darin Fisher <darin@meer.net> has granted Dan Witte <dwitte@stanford.edu>'s
request for superreview:

Bug 200644: rework port handling in permissions code
http://bugzilla.mozilla.org/show_bug.cgi?id=200644

Attachment 134773: ingore the port
http://bugzilla.mozilla.org/attachment.cgi?id=134773&action=edit

------- Additional Comments from Darin Fisher <darin@meer.net>
code looks fine.  are there compatibility issues to worry about?  what happens
when someone goes back to an older version of moz?
0
bugzilla
11/4/2003 10:57:34 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
521 Views

Similar Articles

[PageSpeed] 51

Reply:

Similar Artilces:


superreview requested: [Bug 200644] rework port handling in permissions code : [Attachment 134773] ingore the port
Dan Witte <dwitte@stanford.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 200644: rework port handling in permissions code http://bugzilla.mozilla.org/show_bug.cgi?id=200644 Attachment 134773: ingore the port http://bugzilla.mozilla.org/attachment.cgi?id=134773&action=edit ------- Additional Comments from Dan Witte <dwitte@stanford.edu> r=me... simple patch ;) ...

superreview granted: [Bug 200644] rework port handling in permissions code : [Attachment 134777] also update the js
Darin Fisher <darin@meer.net> has granted Dan Witte <dwitte@stanford.edu>'s request for superreview: Bug 200644: rework port handling in permissions code http://bugzilla.mozilla.org/show_bug.cgi?id=200644 Attachment 134777: also update the js http://bugzilla.mozilla.org/attachment.cgi?id=134777&action=edit ...

superreview requested: [Bug 200644] rework port handling in permissions code : [Attachment 134777] also update the js
Dan Witte <dwitte@stanford.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 200644: rework port handling in permissions code http://bugzilla.mozilla.org/show_bug.cgi?id=200644 Attachment 134777: also update the js http://bugzilla.mozilla.org/attachment.cgi?id=134777&action=edit ...

superreview granted: [Bug 430413] Port Mozilla to GDK : [Attachment 317215] gfx.patch for GDK porting
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Jiny Sung <jh0421.sung@samsung.com>'s request for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 317215: gfx.patch for GDK porting https://bugzilla.mozilla.org/attachment.cgi?id=317215&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> This looks fine, but please don't nest the #ifdefs.. e.g., #ifdef MOZ_ENABLE_GTK2 #ifdef MOZ_X11 should just be #if defined(MOZ_ENABLE_GTK2) &&am...

superreview granted: [Bug 280485] Port fix of bug 277657 (textbox maxlength) : [Attachment 176667] Bug 277657 port
[Checked in: Comment 2] Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 280485: Port fix of bug 277657 (textbox maxlength) https://bugzilla.mozilla.org/show_bug.cgi?id=280485 Attachment 176667: Bug 277657 port [Checked in: Comment 2] https://bugzilla.mozilla.org/attachment.cgi?id=176667&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> r+/sr+: Component change lost the |first-review+, second-review+| flags... ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
David Bienvenu <bienvenu@nventure.com> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview requested: [Bug 430413] Port Mozilla to GDK : [Attachment 317215] gfx.patch for GDK porting
Jiny Sung <jh0421.sung@samsung.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 317215: gfx.patch for GDK porting https://bugzilla.mozilla.org/attachment.cgi?id=317215&action=edit ...

superreview canceled: [Bug 430413] Port Mozilla to GDK : [Attachment 317234] toolkit.patch for GDK porting
Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> has canceled Jiny Sung <jh0421.sung@samsung.com>'s request for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 317234: toolkit.patch for GDK porting https://bugzilla.mozilla.org/attachment.cgi?id=317234&action=edit ------- Additional Comments from Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> Caillon, could you look at this? I don't know much about gdk, and I want to make sure that switching from X to GDK will retain ...

superreview requested: [Bug 430413] Port Mozilla to GDK : [Attachment 317234] toolkit.patch for GDK porting
Jiny Sung <jh0421.sung@samsung.com> has asked Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 317234: toolkit.patch for GDK porting https://bugzilla.mozilla.org/attachment.cgi?id=317234&action=edit ...

superreview granted: [Bug 346576] Fix code comment above blacklisted ports list in netwerk/ : [Attachment 231322] Patch
Frank Wein <bugzilla@mcsmurf.de> has granted superreview: Bug 346576: Fix code comment above blacklisted ports list in netwerk/ https://bugzilla.mozilla.org/show_bug.cgi?id=346576 Attachment 231322: Patch https://bugzilla.mozilla.org/attachment.cgi?id=231322&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> brendan give rs= via IRC. ...

superreview granted: [Bug 430413] Port Mozilla to GDK : [Attachment 320147] The patch was modified with Bugzilla's style.
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Jiny Sung <jh0421.sung@samsung.com>'s request for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 320147: The patch was modified with Bugzilla's style. https://bugzilla.mozilla.org/attachment.cgi?id=320147&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> This looks fine, thanks! ...

superreview granted: [Bug 311934] socket port values are hard coded in the tests : [Attachment 203328] pass in $java and removed tabs
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has granted glen beasley <glen.beasley@sun.com>'s request for superreview: Bug 311934: socket port values are hard coded in the tests https://bugzilla.mozilla.org/show_bug.cgi?id=311934 Attachment 203328: pass in $java and removed tabs https://bugzilla.mozilla.org/attachment.cgi?id=203328&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> Changes are fine. ...

superreview granted: [Bug 285696] Check in code for rebranding Mozilla for milestone releases : [Attachment 178870] patch stage 1, review nits fixed
Robert Kaiser <kairo@kairo.at> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 285696: Check in code for rebranding Mozilla for milestone releases https://bugzilla.mozilla.org/show_bug.cgi?id=285696 Attachment 178870: patch stage 1, review nits fixed https://bugzilla.mozilla.org/attachment.cgi?id=178870&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> OK, this is the stage 1 patch with the review nits fixed. I still need input if it builds OK on windows and mac before I check it in though (linux was tes...

superreview granted: [Bug 317498] Back port JSS tests from tip to 4.1.1 to enable test failure reporting : [Attachment 207536] Missing port configuration in JSSE and JSS client/server tests
glen beasley <glen.beasley@sun.com> has granted Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 317498: Back port JSS tests from tip to 4.1.1 to enable test failure reporting https://bugzilla.mozilla.org/show_bug.cgi?id=317498 Attachment 207536: Missing port configuration in JSSE and JSS client/server tests https://bugzilla.mozilla.org/attachment.cgi?id=207536&action=edit ...

Web resources about - superreview granted: [Bug 200644] rework port handling in permissions code : [Attachment 134773] ingore the port - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/22/2016 10:54:47 AM