superreview granted: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch

David Baron <dbaron@dbaron.org> has granted Brian Ryner
<bryner@brianryner.com>'s request for superreview:

Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling
http://bugzilla.mozilla.org/show_bug.cgi?id=128673

Attachment 134273: slightly improved patch
http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit

------- Additional Comments from David Baron <dbaron@dbaron.org>
>+		  if (!IS_POWER_OF_TWO(rtcHz) || rtcHz < 2) {
>+		      fprintf(stderr, "JP_RTC_HZ must be power of two and > 2,
"

Slight disagreement here about whether 2 is OK.

writeStrStdout was replaced with a mix of puts and write -- why the difference?
 And it looks like you removed the "\n" from the first signal text.

sr=dbaron
0
bugzilla
10/29/2003 11:45:16 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
298 Views

Similar Articles

[PageSpeed] 55

Reply: