superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 162844] Updated patch for Mozilla

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc
Desperrier <jmdesp@alussinan.org>'s request for superreview:
Bug 123006: Keyword substitution with %s doesn't escape characters
https://bugzilla.mozilla.org/show_bug.cgi?id=123006

Attachment 162844: Updated patch for Mozilla
https://bugzilla.mozilla.org/attachment.cgi?id=162844&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
>+	    shortcutURL  = shortcutURL.match(/%[sS]/) ?
shortcutURL.replace(/%s/g, encodeURIComponent(text))
Nit: you should only have one space before the =
Nit: you should use regexp.test(string), not match
Nit: you wrapped a line but it was still over 80 characters.
Either wrap it harder or don't wrap it at all.
>+								  
..replace(/%S/g, text)
>+						      : null;
r+sr=me only once all three nits are fixed.
0
bugzilla
10/21/2004 7:53:01 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
377 Views

Similar Articles

[PageSpeed] 59

Reply: