superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh

Wan-Teh Chang <wtchang@redhat.com> has denied Sandeep Konchady
<Sandeep.Konchady@Sun.COM>'s request for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550

Attachment 193985: Updated changes to files based on review feedback from
Wan-Teh
https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit

------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
Sandeep,

Some of the changes in this patch are wrong.

1. coreconf/import.pl

Just remove the $var{ZIP} assignment because $var{ZIP}
is not used.  Don't replace the assignment by a new
one.

2. coreconf/jdk.mk

The changes to this file are fine, so you may go ahead
and check them in first.  However, I have a question.
Should we simply remove the use of the JDK_VERSION
variable, now that we require JDK 1.4 as the minimum?

3. coreconf/release.pl

The changes to this file are wrong.  You removed the
support for zip completely.  We still need support for
zip in this file.  Our strategy should be "prefer jar
but allow zip".  At Red Hat we still build NSPR and NSS
as separate components, so we can't assume that jar is
available in the build environment for NSPR and NSS. I
know you can make that assumption at Sun because you are
building NSPR, NSS, and JSS as a single component.

4. jss/build_java.pl

You said this change is a first step to moving the
generated jars to platform specific OBJ directories
as suggested by me, but this change does not accomplish
that.  You changed $class_jar from one platform independent
directory ($cmdline_vars{SOURCE_PREFIX}, or mozilla/dist)
to another platform independent directory
($cmdline_vars{SOURCE_RELEASE_PREFIX}, or mozilla/dist/release/no-policy).
How will this change prevent the jars from getting overwritten
when we generate 32 and 64 bit jars on the same platform?

5. jss/org/mozilla/jss/tests/all.pl

Why do you change the initial value of $truncate_lib_path
from 1 to 0?  If you do this, you can simply remove all
uses of $truncate_lib_path because its value will be 0 on
all platforms.

     $java = "$ENV{JAVA_HOME}/jre/bin/java$exe_suffix";
     (-f $java) or die "'$java' does not exist\n";
     $java = $java . $ENV{NATIVE_FLAG};
+    if ($osname eq "SunOS") {
+	 my $cpu = `/usr/bin/isainfo -n`;
+	 if($ENV{USE_64}) {
+	     if( $cpu == "amd64" ) {
+		 $java = "$ENV{JAVA_HOME}/jre/bin/amd64/java$exe_suffix";
+	     } else {
+		 $java = $java . " -d64 ";
+	     }
+	 }
+    } else {
+	 if($ENV{USE_64}) {
+	     $java = $java . " -d64 ";
+	 }
     }

Nit: move the line
    my $cpu = `/usr/bin/isainfo -n`;
into the if($ENV{USE_64}) block because the $cpu variable is only
used in that block.

Does the value of $java for the $cpu == "amd64" case need
$ENV{NATIVE_FLAG}?  (I don't know what $ENV{NATIVE_FLAG} is.)

I suggest rewriting the above like this:

    $java = "$ENV{JAVA_HOME}/jre/bin/java$exe_suffix";
    my $java_64bit = 0;
    if ($osname eq "SunOS") {
	if ($ENV{USE_64}) {
	    my $cpu = `/usr/bin/isainfo -n`;
	    if ($cpu == "amd64") {
		$java = "$ENV{JAVA_HOME}/jre/bin/amd64/java$exe_suffix";
		$java_64bit = 1;
	    }
	}
    }
    (-f $java) or die "'$java' does not exist\n";
    $java = $java . $ENV{NATIVE_FLAG};

    if ($ENV{USE_64} && !$java_64bit) {
	$java = $java . " -d64";
    }
0
bugzilla
9/6/2005 7:03:20 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
384 Views

Similar Articles

[PageSpeed] 41

Reply:

Similar Artilces:

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 193985: Updated changes to files based on review feedback from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> 1. coreconf/import.pl Removed $var{ZIP} 2. coreconf/jdk.mk Replaced spaces with tabs to stick to the ex...

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 195812] Modifications as per Wan-Teh's suggestions
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 195812: Modifications as per Wan-Teh's suggestions https://bugzilla.mozilla.org/attachment.cgi?id=195812&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> 1. coreconf/import.pl Just remove the $var{ZIP} assignment because $var{ZIP} is not used. Don't replace the assignment by ...

superreview granted: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 195812] Modifications as per Wan-Teh's suggestions
Wan-Teh Chang <wtchang@redhat.com> has granted Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 195812: Modifications as per Wan-Teh's suggestions https://bugzilla.mozilla.org/attachment.cgi?id=195812&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. >@@ -241,16 +243,21 @@ > > # (3) specify "linker" information > JAVA_CPU = i386 >-...

superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192550] Modifications to release.pl and import.pl to comply with original layout
Wan-Teh Chang <wtchang@redhat.com> has denied Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 192550: Modifications to release.pl and import.pl to comply with original layout https://bugzilla.mozilla.org/attachment.cgi?id=192550&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> This patch has some problems. Most are minor, but one or two are serious, hence the review-. ...

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192550] Modifications to release.pl and import.pl to comply with original layout
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 192550: Modifications to release.pl and import.pl to comply with original layout https://bugzilla.mozilla.org/attachment.cgi?id=192550&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> Updated coreconf/release.pl and coreconf/import.pl to comply with original layout structure. ...

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192522] Modified coreconf/jdk.mk, build_all.pl and all.sh to switch to 64 bit compilation fo
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked glen beasley <glen.beasley@sun.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 192522: Modified coreconf/jdk.mk, build_all.pl and all.sh to switch to 64 bit compilation for AMD64 https://bugzilla.mozilla.org/attachment.cgi?id=192522&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> Two modifications are included in this bug. [1] Based on Glen's finding that co...

superreview cancelled: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192522] Modified coreconf/jdk.mk, build_all.pl and all.sh to switch to 64 bit compilation fo
glen beasley <glen.beasley@sun.com> has cancelled Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 192522: Modified coreconf/jdk.mk, build_all.pl and all.sh to switch to 64 bit compilation for AMD64 https://bugzilla.mozilla.org/attachment.cgi?id=192522&action=edit ...

superreview cancelled: [Bug 313176] allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 : [Attachment 201764] applied Wan-Teh review changes
Nelson Bolyard <nelson@bolyard.com> has cancelled glen beasley <glen.beasley@sun.com>'s request for superreview: Bug 313176: allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 https://bugzilla.mozilla.org/show_bug.cgi?id=313176 Attachment 201764: applied Wan-Teh review changes https://bugzilla.mozilla.org/attachment.cgi?id=201764&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> 1) Minor stylistic inconsistency: Some java comments begin with a capital letter, like this one: > /** >+ ...

superreview granted: [Bug 223909] copy and paste windows clipboard images : [Attachment 238256] updated widget changes based on review feedback
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 223909: copy and paste windows clipboard images https://bugzilla.mozilla.org/show_bug.cgi?id=223909 Attachment 238256: updated widget changes based on review feedback https://bugzilla.mozilla.org/attachment.cgi?id=238256&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Breaking out the widget changes. Carrying forward stu's r and vlad's sr. Next up, editor. ...

superreview requested: [Bug 313176] allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 : [Attachment 201764] applied Wan-Teh review changes
glen beasley <glen.beasley@sun.com> has asked for superreview: Bug 313176: allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 https://bugzilla.mozilla.org/show_bug.cgi?id=313176 Attachment 201764: applied Wan-Teh review changes https://bugzilla.mozilla.org/attachment.cgi?id=201764&action=edit ...

superreview denied: [Bug 191839] Content Policy API (nsIContentPolicy) sucks rocks : [Attachment 133624] for review
Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu> has denied Tim <riceman+bmo@mail.rit.edu>'s request for superreview: Bug 191839: Content Policy API (nsIContentPolicy) sucks rocks http://bugzilla.mozilla.org/show_bug.cgi?id=191839 Attachment 133624: for review - base changes and updates to existing callers http://bugzilla.mozilla.org/attachment.cgi?id=133624&action=edit ------- Additional Comments from Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu> >Index: content/base/public/nsContentErrors.h >+/** Error codes for content po...

superreview requested: [Bug 313176] allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 : [Attachment 201764] applied Wan-Teh review changes #2
glen beasley <glen.beasley@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 313176: allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 https://bugzilla.mozilla.org/show_bug.cgi?id=313176 Attachment 201764: applied Wan-Teh review changes https://bugzilla.mozilla.org/attachment.cgi?id=201764&action=edit ...

superreview granted: [Bug 314098] getProvider().toString() returns "Mozilla-JSS version 3.3" in JSS 4.x : [Attachment 203558] Modified the computation of JSS_VERSION based on Wan-Teh's suggestion
Wan-Teh Chang <wtchang@redhat.com> has granted Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 314098: getProvider().toString() returns "Mozilla-JSS version 3.3" in JSS 4.x https://bugzilla.mozilla.org/show_bug.cgi?id=314098 Attachment 203558: Modified the computation of JSS_VERSION based on Wan-Teh's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=203558&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. ...

superreview requested: [Bug 314098] getProvider().toString() returns "Mozilla-JSS version 3.3" in JSS 4.x : [Attachment 203558] Modified the computation of JSS_VERSION based on Wan-Teh's suggestion
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 314098: getProvider().toString() returns "Mozilla-JSS version 3.3" in JSS 4.x https://bugzilla.mozilla.org/show_bug.cgi?id=314098 Attachment 203558: Modified the computation of JSS_VERSION based on Wan-Teh's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=203558&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> Modified the computation of JSS_VERSION based on Wan-Teh's suggestion. This...

Web resources about - superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/30/2015 8:00:35 PM