superreview denied: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch

Mike Pinkerton <pinkerton@aol.net> has denied Mike Pinkerton
<pinkerton@aol.net>'s request for superreview:
Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view.
https://bugzilla.mozilla.org/show_bug.cgi?id=266356

Attachment 163739: Proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=163739&action=edit

------- Additional Comments from Mike Pinkerton <pinkerton@aol.net>
actually i'd like a better fix for this.

if the separator button is only enabled for bookmarks, then just call the
|-setEnabled:| once. pull the 

[mAddSeparatorButton setEnabled:(kBookmarkMenuContainerIndex == inRowIndex)];

out of the if statement and always call it.
0
bugzilla
11/2/2004 6:06:17 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
452 Views

Similar Articles

[PageSpeed] 43

Reply:

Similar Artilces:

superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch
Mike Pinkerton <pinkerton@aol.net> has granted Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 163739: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=163739&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 163739: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=163739&action=edit ...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...

superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...

superreview denied: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 219662: "OK" button doesn't activate in "Link Properties" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=219662 Attachment 236543: patch https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> > <textbox id="hrefInput" type="autocomplete" > searchSessions="history" timeout="50" m...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview cancelled: [Bug 331055] Add a repeating button : [Attachment 215782] This patch doesn't change the button frame, and uses the syntax <button type="repeat"/>
Neil Deakin <enndeakin@sympatico.ca> has cancelled Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 331055: Add a repeating button https://bugzilla.mozilla.org/show_bug.cgi?id=331055 Attachment 215782: This patch doesn't change the button frame, and uses the syntax <button type="repeat"/> https://bugzilla.mozilla.org/attachment.cgi?id=215782&action=edit ...

superreview granted: [Bug 301688] Disabled buttons shoudn't have a "default button" look&feel : [Attachment 190112] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano (use mozilla.mano@ for email) <bugs.mano@sent.com>'s request for superreview: Bug 301688: Disabled buttons shoudn't have a "default button" look&feel https://bugzilla.mozilla.org/show_bug.cgi?id=301688 Attachment 190112: patch https://bugzilla.mozilla.org/attachment.cgi?id=190112&action=edit ...

superreview requested: [Bug 301688] Disabled buttons shoudn't have a "default button" look&feel : [Attachment 190112] patch
Asaf Romano (use mozilla.mano@ for email) <bugs.mano@sent.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 301688: Disabled buttons shoudn't have a "default button" look&feel https://bugzilla.mozilla.org/show_bug.cgi?id=301688 Attachment 190112: patch https://bugzilla.mozilla.org/attachment.cgi?id=190112&action=edit ...

superreview requested: [Bug 195224] [views/filter/search] Remove "More" and "Fewer" buttons and add + and
Scott MacGregor <mscott@mozilla.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 195224: [views/filter/search] Remove "More" and "Fewer" buttons and add + and - buttons per line https://bugzilla.mozilla.org/show_bug.cgi?id=195224 Attachment 183120: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=183120&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> New patch based on the latest set of feedback: 1) Menulists now have a width of 12em; 2) dialogs ...

superreview granted: [Bug 195224] [views/filter/search] Remove "More" and "Fewer" buttons and add + and
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 195224: [views/filter/search] Remove "More" and "Fewer" buttons and add + and - buttons per line https://bugzilla.mozilla.org/show_bug.cgi?id=195224 Attachment 183120: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=183120&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >+ <listcol flex="&searchTermListButtonsFlexV...

superreview requested: [Bug 195224] [views/filter/search] Remove "More" and "Fewer" buttons and add + and
Scott MacGregor <mscott@mozilla.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 195224: [views/filter/search] Remove "More" and "Fewer" buttons and add + and - buttons per line https://bugzilla.mozilla.org/show_bug.cgi?id=195224 Attachment 182113: updated patch that no longer has the clipping issue shown in the screen shots https://bugzilla.mozilla.org/attachment.cgi?id=182113&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This patch is Stefan's original p...

superreview cancelled: [Bug 195224] [views/filter/search] Remove "More" and "Fewer" buttons and add + and
Scott MacGregor <mscott@mozilla.org> has cancelled Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 195224: [views/filter/search] Remove "More" and "Fewer" buttons and add + and - buttons per line https://bugzilla.mozilla.org/show_bug.cgi?id=195224 Attachment 182113: updated patch that no longer has the clipping issue shown in the screen shots https://bugzilla.mozilla.org/attachment.cgi?id=182113&action=edit ...

superreview cancelled: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226713] Add a "Do this automatically from now on" checkbox
Jens Bannmann <jens.b@web.de> has cancelled Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox https://bugzilla.mozilla.org/show_bug.cgi?id=198936 Attachment 226713: Add a "Do this automatically from now on" checkbox https://bugzilla.mozilla.org/attachment.cgi?id=226713&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> Changed the dialog title to "Compact Folders" per bug 116215 comment 8 by ...

Web resources about - superreview denied: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch - netscape.mozilla.reviewers

Resources last updated: 1/16/2016 4:24:44 PM