superreview denied: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 152300] Make Mozilla build

David Baron <dbaron@dbaron.org> has denied Stephen Walker
<sdwalker@myrealbox.com>'s request for superreview:
Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005
http://bugzilla.mozilla.org/show_bug.cgi?id=249782

Attachment 152300: Make Mozilla build
http://bugzilla.mozilla.org/attachment.cgi?id=152300&action=edit

------- Additional Comments from David Baron <dbaron@dbaron.org>
>	      AC_MSG_ERROR([This version of the MSVC compiler, $CC_VERSION , is
unsupported.])

I'm somewhat skeptical whether giving an error on an unknown compiler is a good
idea in the first place.  It probably is in practice, though.

>Index: xpcom/io/nsLocalFileWin.cpp
>     // search for first slash after the drive (or volume) name
>-    unsigned char* slash = _mbschr(path, '\\');
>+    unsigned char* slash = NS_CONST_CAST(unsigned char*, _mbschr(path,
'\\'));

The initial assignment to |path| should use BeginWriting() instead of get(),
and |path| should also be non-const.  You may need some NS_CONST_CAST
gymnastics because of the C-ish (rather than C++-ish with 2 overloaded forms
varying in const-ness) signature of _mbsstr, but you should give the variables
the right constness.

>@@ -759,7 +759,7 @@
>-	  unsigned char * doubleDot = _mbsstr(nodePath, (unsigned char
*)"\\..");
>+	  unsigned char * doubleDot = NS_CONST_CAST(unsigned char *,
_mbsstr(nodePath, (unsigned char *)"\\.."));

doubleDot should be |const unsigned char*|.

>Index: directory/c-sdk/build.mk

A brief explanation of these changes would be useful.  How do you know they
won't break older versions?
0
bugzilla
7/18/2004 3:20:21 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
562 Views

Similar Articles

[PageSpeed] 0

Reply:

Similar Artilces:

superreview requested: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 152300] Make Mozilla build
Stephen Walker <sdwalker@myrealbox.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 http://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 152300: Make Mozilla build http://bugzilla.mozilla.org/attachment.cgi?id=152300&action=edit ...

superreview denied: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 204580] embed manifest files with check for mt.exe
Julien Pierre <julien.pierre.bugs@sun.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 https://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 204580: embed manifest files with check for mt.exe - patch#3 (security/NSS) https://bugzilla.mozilla.org/attachment.cgi?id=204580&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch does not apply to the tip of NSS or to the current branch, NSS_3_11_BRANCH . ...

superreview denied: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 209053] Un-bitrotted embed manifest files with check for mt.exe
Ryan VanderMeulen <ryanvm@gmail.com> has denied Ryan VanderMeulen <ryanvm@gmail.com>'s request for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 https://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 209053: Un-bitrotted embed manifest files with check for mt.exe - patch#3 (security/NSS) https://bugzilla.mozilla.org/attachment.cgi?id=209053&action=edit ------- Additional Comments from Ryan VanderMeulen <ryanvm@gmail.com> Un-bitrotted version of attachment 208970 split into seperate parts per bsmedberg's reques...

superreview requested: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005
Kai Engert (:kaie) <kengert@redhat.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 https://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 247764: Remove NSS workarounds https://bugzilla.mozilla.org/attachment.cgi?id=247764&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I think this patch is needed to fix bug 370693 - on Linux! I'm not sure yet whether it will be sufficient to fix that other bug, bu...

superreview cancelled: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005
Kai Engert (:kaie) <kengert@redhat.com> has cancelled Kai Engert (:kaie) <kengert@redhat.com>'s request for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 https://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 247764: Remove NSS workarounds https://bugzilla.mozilla.org/attachment.cgi?id=247764&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I decided to take this patch over to bug 370693, because another change is required. ...

superreview denied: [Bug 272250] make distclean from mozilla does not clean mozilla/camino/build : [Attachment 169383] make distclean work
Mike Pinkerton <pinkerton@aol.net> has denied Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 272250: make distclean from mozilla does not clean mozilla/camino/build https://bugzilla.mozilla.org/show_bug.cgi?id=272250 Attachment 169383: make distclean work https://bugzilla.mozilla.org/attachment.cgi?id=169383&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> $(DIST)/camino doesn't exist. ...

superreview requested: [Bug 272250] make distclean from mozilla does not clean mozilla/camino/build : [Attachment 169383] make distclean work
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 272250: make distclean from mozilla does not clean mozilla/camino/build https://bugzilla.mozilla.org/show_bug.cgi?id=272250 Attachment 169383: make distclean work https://bugzilla.mozilla.org/attachment.cgi?id=169383&action=edit ------- Additional Comments from Ludovic Hirlimann <qa-mozilla@hirlimann.net> setting r+ since i did not wrote the patch. ...

superreview requested: [Bug 232742] Mozilla incl. firebird does not build on Amd64 cpu : [Attachment 140309] This patch makes mozilla build on amd64 under gentoo linux
Roland Mainz <roland.mainz@nrubsig.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 232742: Mozilla incl. firebird does not build on Amd64 cpu http://bugzilla.mozilla.org/show_bug.cgi?id=232742 Attachment 140309: This patch makes mozilla build on amd64 under gentoo linux http://bugzilla.mozilla.org/attachment.cgi?id=140309&action=edit ------- Additional Comments from Roland Mainz <roland.mainz@nrubsig.org> Requesting r= from wtc for the NSPR and NSS changes per bryner's suggestion... ...

superreview granted: [Bug 272250] make distclean from mozilla does not clean mozilla/camino/build : [Attachment 169648] Adressing pink's comment.
Mike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 272250: make distclean from mozilla does not clean mozilla/camino/build https://bugzilla.mozilla.org/show_bug.cgi?id=272250 Attachment 169648: Adressing pink's comment. https://bugzilla.mozilla.org/attachment.cgi?id=169648&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview requested: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public
Aaron Leventhal <aaronleventhal@moonset.net> has asked Alec Flett <alecf@flett.org> for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ...

superreview granted: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public
Brian Ryner (IBM) <bryner@brianryner.com> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ...

superreview requested: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ...

superreview requested: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public #3
Darin Fisher (IBM) <darin@meer.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> I'm sorry, I don't know this code well enough to provide you with a reasonable review. Since focus stuff is involved, I'm goi...

superreview requested: [Bug 424641] Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" : [Attachment 318390] The fix v2
Mark Banner <bugzilla@standard8.plus.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 424641: Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" https://bugzilla.mozilla.org/show_bug.cgi?id=424641 Attachment 318390: The fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=318390&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> I'm happy this should work on all platforms. I'll request toolkit revi...

Web resources about - superreview denied: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 152300] Make Mozilla build - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/20/2015 12:10:18 PM