superreview denied: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 148287] Set the real name to an eudora imported attached file.

Scott MacGregor <mscott@mozilla.org> has denied Scott MacGregor
<mscott@mozilla.org>'s request for superreview:
Bug 242953: an Imported eudora attached file is always named "Attached File"
instead of its real name
http://bugzilla.mozilla.org/show_bug.cgi?id=242953

Attachment 148287: Set the real name to an eudora imported attached file.
http://bugzilla.mozilla.org/attachment.cgi?id=148287&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
Yann, 

is the fileName argument that gets passed into AddAttachment already just the
filename or is it really a full path? 

If it is just the file name, then we can use that diirectly without iterating
over the string right?

If it is a full path, we should really take the path, turn it into a nsIFile
then ask the file to give us the leaf name instead of trying to walk the path
and figuring it out on our own.
0
bugzilla
6/29/2004 11:08:38 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
1176 Views

Similar Articles

[PageSpeed] 32

Reply:

Similar Artilces:

superreview granted: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 153467] set the attachment name as the leaf name of the file
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 153467: set the attachment name as the leaf name of the file http://bugzilla.mozilla.org/attachment.cgi?id=153467&action=edit ...

superreview requested: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 153467] set the attachment name as the leaf name of the fil
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 153467: set the attachment name as the leaf name of the file http://bugzilla.mozilla.org/attachment.cgi?id=153467&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I've given up on trying to get the whitespace to work in these import files. They were a...

superreview granted: [Bug 242948] Attached files not imported from French Eudora : [Attachment 147907] Enable attached files from French Eudora mailboxes to be correctly imported
Scott MacGregor <mscott@mozilla.org> has granted Seth Spitzer (not reading bugmail) <sspitzer@mozilla.org>'s request for superreview: Bug 242948: Attached files not imported from French Eudora https://bugzilla.mozilla.org/show_bug.cgi?id=242948 Attachment 147907: Enable attached files from French Eudora mailboxes to be correctly imported https://bugzilla.mozilla.org/attachment.cgi?id=147907&action=edit ...

superreview requested: [Bug 242948] Attached files not imported from French Eudora : [Attachment 147907] Enable attached files from French Eudora mailboxes to be correctly imported
Seth Spitzer (not reading bugmail) <sspitzer@mozilla.org> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 242948: Attached files not imported from French Eudora https://bugzilla.mozilla.org/show_bug.cgi?id=242948 Attachment 147907: Enable attached files from French Eudora mailboxes to be correctly imported https://bugzilla.mozilla.org/attachment.cgi?id=147907&action=edit ------- Additional Comments from Seth Spitzer (not reading bugmail) <sspitzer@mozilla.org> seek sr= from mscott ...

superreview canceled: [Bug 421763] bookmarks import and restore only allow files named .html and .json : [Attachment 315453] Adds "All Files" filter option when choosing "Bookmark Restore" file
Dietrich Ayala <dietrich@mozilla.com> has canceled Jason Harvey <jason@alioth.us>'s request for superreview: Bug 421763: bookmarks import and restore only allow files named .html and .json https://bugzilla.mozilla.org/show_bug.cgi?id=421763 Attachment 315453: Adds "All Files" filter option when choosing "Bookmark Restore" file https://bugzilla.mozilla.org/attachment.cgi?id=315453&action=edit ------- Additional Comments from Dietrich Ayala <dietrich@mozilla.com> r=me, thanks ...

superreview requested: [Bug 421763] bookmarks restore only allows you to consider files named .html : [Attachment 315453] Adds "All Files" filter option when choosing "Bookmark Restore" file
Jason Harvey <jason@alioth.us> has asked Dietrich Ayala <dietrich@mozilla.com> for superreview: Bug 421763: bookmarks restore only allows you to consider files named .html https://bugzilla.mozilla.org/show_bug.cgi?id=421763 Attachment 315453: Adds "All Files" filter option when choosing "Bookmark Restore" file https://bugzilla.mozilla.org/attachment.cgi?id=315453&action=edit ------- Additional Comments from Jason Harvey <jason@alioth.us> Added an "All Files" filter option to the file chooser interface. The "JSON" option...

superreview granted: [Bug 154332] Forwarding a ".EML" attachment adds additional ".EML" to file name. : [Attachment 212403] proposed fix
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+bugzilla@cc.hut.fi>'s request for superreview: Bug 154332: Forwarding a ".EML" attachment adds additional ".EML" to file name. https://bugzilla.mozilla.org/show_bug.cgi?id=154332 Attachment 212403: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=212403&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> yeah, let's try it on the trunk - I'm a little worried about this as well. ...

superreview denied: [Bug 177968] Screen names do not get imported : [Attachment 188225] Allow import of screen name from ldif files
Dan Mosedale <dmose@mozilla.org> has denied Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 177968: Screen names do not get imported https://bugzilla.mozilla.org/show_bug.cgi?id=177968 Attachment 188225: Allow import of screen name from ldif files https://bugzilla.mozilla.org/attachment.cgi?id=188225&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> I'd like to propose that any patch that touches the attribute here should at least make us internally consistent. Since nscpaimscreenname has been us...

superreview cancelled: [Bug 311387] Cannot open local file from "Index of file://" if its file name contains non-ASCII character : [Attachment 198715] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 311387: Cannot open local file from "Index of file://" if its file name contains non-ASCII character https://bugzilla.mozilla.org/show_bug.cgi?id=311387 Attachment 198715: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=198715&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Darin: If the pref is set false in default setting, ...

superreview requested: [Bug 311387] Cannot open local file from "Index of file://" if its file name contains non-ASCII character : [Attachment 198715] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 311387: Cannot open local file from "Index of file://" if its file name contains non-ASCII character https://bugzilla.mozilla.org/show_bug.cgi?id=311387 Attachment 198715: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=198715&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This fixes this bug. ...

superreview requested: [Bug 311387] Cannot open local file from "Index of file://" if its file name contains non-ASCII character : [Attachment 198798] Patch rv1.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 311387: Cannot open local file from "Index of file://" if its file name contains non-ASCII character https://bugzilla.mozilla.org/show_bug.cgi?id=311387 Attachment 198798: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=198798&action=edit ...

superreview granted: [Bug 255366] File picker calls crash mozilla (open file, file attach, file browser, etc) : [Attachment 159629] Make our prototype for _gtk_file_chooser_dialog_new_fn() match real
Johnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 255366: File picker calls crash mozilla (open file, file attach, file browser, etc) https://bugzilla.mozilla.org/show_bug.cgi?id=255366 Attachment 159629: Make our prototype for _gtk_file_chooser_dialog_new_fn() match reality (patch by bryner) https://bugzilla.mozilla.org/attachment.cgi?id=159629&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Chris, was this done this way intentionally...

superreview cancelled: [Bug 177968] Screen names do not get imported : [Attachment 188225] Allow import of screen name from ldif files
Dan Mosedale <dmose@mozilla.org> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 177968: Screen names do not get imported https://bugzilla.mozilla.org/show_bug.cgi?id=177968 Attachment 188225: Allow import of screen name from ldif files https://bugzilla.mozilla.org/attachment.cgi?id=188225&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Turns out that the only use of "mozilla_aimscreenname" in the tree, according to lxr, is in a comment in nsIAddrDatabase.idl. The addressboo...

superreview requested: [Bug 177968] Screen names do not get imported : [Attachment 188225] Allow import of screen name from ldif files
Mark Banner <bugzilla@standard8.demon.co.uk> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 177968: Screen names do not get imported https://bugzilla.mozilla.org/show_bug.cgi?id=177968 Attachment 188225: Allow import of screen name from ldif files https://bugzilla.mozilla.org/attachment.cgi?id=188225&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Now that we don't have as much duplicated ldif code, here's the patch to fix the importing of the screenname (we already export it). works for both t...

Web resources about - superreview denied: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 148287] Set the real name to an eudora imported attached file. - netscape.mozilla.reviewers

Resources last updated: 1/18/2016 8:30:50 PM