superreview denied: [Bug 216559] fill="currentColor" does not work. : [Attachment 165858] Patch for CSS3 currentColor

David Baron <dbaron@mozilla.org> has denied Scooter Morris
<scootermorris@comcast.net>'s request for superreview:
Bug 216559: fill="currentColor" does not work.
https://bugzilla.mozilla.org/show_bug.cgi?id=216559

Attachment 165858: Patch for CSS3 currentColor
https://bugzilla.mozilla.org/attachment.cgi?id=165858&action=edit

------- Additional Comments from David Baron <dbaron@mozilla.org>
SetColor needs to set aInherited to PR_TRUE in the new case that you're adding,
with a comment something like:

 // The data computed from this can't be shared in the rule tree because they
could be used on a node with a different color.

Other than that this looks OK.
0
bugzilla
11/25/2004 1:09:10 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
164 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview requested: [Bug 216559] fill="currentColor" does not work. : [Attachment 165858] Patch for CSS3 currentColor
Scooter Morris <scootermorris@comcast.net> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 216559: fill="currentColor" does not work. https://bugzilla.mozilla.org/show_bug.cgi?id=216559 Attachment 165858: Patch for CSS3 currentColor https://bugzilla.mozilla.org/attachment.cgi?id=165858&action=edit ...

superreview granted: [Bug 216559] fill="currentColor" does not work. : [Attachment 167493] Updated patch for CSS3 currentColor including dbaron's requested change
David Baron <dbaron@mozilla.org> has granted Scooter Morris <scootermorris@comcast.net>'s request for superreview: Bug 216559: fill="currentColor" does not work. https://bugzilla.mozilla.org/show_bug.cgi?id=216559 Attachment 167493: Updated patch for CSS3 currentColor including dbaron's requested change https://bugzilla.mozilla.org/attachment.cgi?id=167493&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> >Index: content/base/src/nsRuleNode.cpp >+ // The data computed from this can't be shared in the...

superreview requested: [Bug 216559] fill="currentColor" does not work. : [Attachment 167493] Updated patch for CSS3 currentColor including dbaron's requested change
Scooter Morris <scootermorris@comcast.net> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 216559: fill="currentColor" does not work. https://bugzilla.mozilla.org/show_bug.cgi?id=216559 Attachment 167493: Updated patch for CSS3 currentColor including dbaron's requested change https://bugzilla.mozilla.org/attachment.cgi?id=167493&action=edit ...

superreview denied: [Bug 44980] Proxy: ignore "*" characters in "no proxy for" : [Attachment 11158] Patch for this bug
Darin Fisher (IBM) <darin@meer.net> has denied timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 44980: Proxy: ignore "*" characters in "no proxy for" http://bugzilla.mozilla.org/show_bug.cgi?id=44980 Attachment 11158: Patch for this bug http://bugzilla.mozilla.org/attachment.cgi?id=11158&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr- we must not block the UI thread waiting for slow DNS servers to respond. we currently do so for PAC, and that is unfortunate. ...

superreview granted: [Bug 215590] "Copy Link Location", "Delete", "Select All" in history sidebar do not work/are inactive/greyed out : [Attachment 139200] patch
Alec Flett <alecf@flett.org> has granted Andreas Kunz <durbacher@gmx.de>'s request for superreview: Bug 215590: "Copy Link Location", "Delete", "Select All" in history sidebar do not work/are inactive/greyed out http://bugzilla.mozilla.org/show_bug.cgi?id=215590 Attachment 139200: patch http://bugzilla.mozilla.org/attachment.cgi?id=139200&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> does this also update the "delete domain" option too? ...

superreview requested: [Bug 215590] "Copy Link Location", "Delete", "Select All" in history sidebar do not work/are inactive/greyed out : [Attachment 139200] patch
Andreas Kunz <durbacher@gmx.de> has asked Alec Flett <alecf@flett.org> for superreview: Bug 215590: "Copy Link Location", "Delete", "Select All" in history sidebar do not work/are inactive/greyed out http://bugzilla.mozilla.org/show_bug.cgi?id=215590 Attachment 139200: patch http://bugzilla.mozilla.org/attachment.cgi?id=139200&action=edit ------- Additional Comments from Andreas Kunz <durbacher@gmx.de> Requesting sr= from alecf. ...

superreview denied: [Bug 194147] Selecting "Mark As" causes Quick Search not to work on "m" and "r" : [Attachment 201172] Don't display single commandkeys in mac menuitems
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has denied Stefan <stefan_h@hem.utfors.se>'s request for superreview: Bug 194147: Selecting "Mark As" causes Quick Search not to work on "m" and "r" https://bugzilla.mozilla.org/show_bug.cgi?id=194147 Attachment 201172: Don't display single commandkeys in mac menuitems https://bugzilla.mozilla.org/attachment.cgi?id=201172&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Fine, except you missed a bunch of keys; fi...

superreview denied: [Bug 303863] "No updates were found for Extensionname" should be "No updates were found" : [Attachment 193779] patch v2.0
Scott MacGregor <mscott@mozilla.org> has denied Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 303863: "No updates were found for Extensionname" should be "No updates were found" https://bugzilla.mozilla.org/show_bug.cgi?id=303863 Attachment 193779: patch v2.0 https://bugzilla.mozilla.org/attachment.cgi?id=193779&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> this patch doesn't fix the call sites which would still be trying to fill in the %S values for these strings which no l...

superreview denied: [Bug 308443] The preferences "browser.search.defaultengine" and "browser.search.defaultenginename" should be synced up : [Attachment 196138] patch
Boying Lu <brian.lu@sun.com> has denied Boying Lu <brian.lu@sun.com>'s request for superreview: Bug 308443: The preferences "browser.search.defaultengine" and "browser.search.defaultenginename" should be synced up https://bugzilla.mozilla.org/show_bug.cgi?id=308443 Attachment 196138: patch https://bugzilla.mozilla.org/attachment.cgi?id=196138&action=edit ...

superreview granted: [Bug 257338] "Delete Host" and "Delete Domain" features of the History Window do not work : [Attachment 157336] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 257338: "Delete Host" and "Delete Domain" features of the History Window do not work http://bugzilla.mozilla.org/show_bug.cgi?id=257338 Attachment 157336: Patch http://bugzilla.mozilla.org/attachment.cgi?id=157336&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> sr=me assuming bsmedberg confirms that this is the correct solut...

superreview denied: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 219662: "OK" button doesn't activate in "Link Properties" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=219662 Attachment 236543: patch https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> > <textbox id="hrefInput" type="autocomplete" > searchSessions="history" timeout="50" m...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Scott MacGregor <mscott@mozilla.org> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> this needs a toolkit module owner review so I'll ask Benjamin for that. David's on vacation, i'll do the sr. ...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

Web resources about - superreview denied: [Bug 216559] fill="currentColor" does not work. : [Attachment 165858] Patch for CSS3 currentColor - netscape.mozilla.reviewers

Resources last updated: 1/22/2016 8:26:59 PM