superreview requested: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191278] remove the incorrect spacing change to the 'if' in ReadSubjectEntry()Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 303010: Certificate upgrade can drop S/MIME certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=303010
Attachment 191278: remove the incorrect spacing change to the 'if' in
ReadSubjectEntry()
https://bugzilla.mozilla.org/attachment.cgi?id=191278&action=edit
...
superreview cancelled: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191277] Delay loading the S/MIME records on upgrade until the cert is loaded.Robert Relyea <rrelyea@redhat.com> has cancelled Robert Relyea
<rrelyea@redhat.com>'s request for superreview:
Bug 303010: Certificate upgrade can drop S/MIME certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=303010
Attachment 191277: Delay loading the S/MIME records on upgrade until the cert
is loaded.
https://bugzilla.mozilla.org/attachment.cgi?id=191277&action=edit
...
superreview requested: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191277] Delay loading the S/MIME records on upgrade until the cert is loaded.Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 303010: Certificate upgrade can drop S/MIME certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=303010
Attachment 191277: Delay loading the S/MIME records on upgrade until the cert
is loaded.
https://bugzilla.mozilla.org/attachment.cgi?id=191277&action=edit
...
superreview granted: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, changJohnny Stenback <jst@mozilla.jstenback.com> has granted timeless@myrealbox.com
(working) <timeless@bemail.org>'s request for superreview:
Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary
comptr, a comment change
http://bugzilla.mozilla.org/show_bug.cgi?id=242760
Attachment 147787: store rc's so ifs can check, drop temporary comptr, change
comment, check alloc
http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
- element->Append...
superreview requested: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, chatimeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny
Stenback <jst@mozilla.jstenback.com> for superreview:
Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary
comptr, a comment change
http://bugzilla.mozilla.org/show_bug.cgi?id=242760
Attachment 147787: store rc's so ifs can check, drop temporary comptr, change
comment, check alloc
http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit
...
superreview cancelled: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from historyneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has cancelled Andrew
Schultz <ajschult@verizon.net>'s request for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204513: try to purge invalid typed URLs from history
https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com>
I just reviewed this patch for bug 317819 ;-)
...
superreview cancelled: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is showSimon Paquet (back in business) <bugzilla@babylonsounds.com> has cancelled
Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761
Attachment 149378: Change the check for if the dropdown is shown to the correct
way
http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit
------- Additional Comments from Simon Paquet (back in business)
<bugzilla@babylonsounds.com>
...
superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this oneAndrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204552: how 'bout this one
https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit
...
superreview denied: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this oneneil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz
<ajschult@verizon.net>'s request for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204552: how 'bout this one
https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
This patch appears to be for bug 66049, and you haven't answered comment #71
correctly anyway.
...
superreview cancelled: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>Alec Flett <alecf@flett.org> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s
request for superreview:
Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE'
http://bugzilla.mozilla.org/show_bug.cgi?id=228448
Attachment 137404: (Av1) <nsInternetSearchService.cpp>
http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit
------- Additional Comments from Alec Flett <alecf@flett.org>
reviewers do not compile and test. Don't ask for a review until you've done
that much yourself.
...
superreview canceled: [Bug 190974] [IMAP] Can't manage mail by 'deleted' flag : [Attachment 300024] Original implementation plus Karsten's SeaMonkey addition.Jeff Beckley <beckley@qualcomm.com> has canceled Dale Wiggins
<dwiggins@qualcomm.com>'s request for superreview:
Bug 190974: [IMAP] Can't manage mail by 'deleted' flag
https://bugzilla.mozilla.org/show_bug.cgi?id=190974
Attachment 300024: Original implementation plus Karsten's SeaMonkey addition.
https://bugzilla.mozilla.org/attachment.cgi?id=300024&action=edit
------- Additional Comments from Jeff Beckley <beckley@qualcomm.com>
Here's a clean version of the patch with the duplicate file diff removed.
...
superreview cancelled: [Bug 217149] Thunderbird can't open .eml files or handle message/rfc822 MIME-type : [Attachment 145240] fix addressing scott's comments.Scott MacGregor <mscott@mozilla.org> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 217149: Thunderbird can't open .eml files or handle message/rfc822
MIME-type
http://bugzilla.mozilla.org/show_bug.cgi?id=217149
Attachment 145240: fix addressing scott's comments.
http://bugzilla.mozilla.org/attachment.cgi?id=145240&action=edit
...
superreview granted: [Bug 278549] Can't configure used certificate per mail identity : [Attachment 306507] Adds a S/MIME Tab to identity management of accountsneil@parkwaycc.co.uk <neil@httl.net> has granted superreview:
Bug 278549: Can't configure used certificate per mail identity
https://bugzilla.mozilla.org/show_bug.cgi?id=278549
Attachment 306507: Adds a S/MIME Tab to identity management of accounts
https://bugzilla.mozilla.org/attachment.cgi?id=306507&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
Well, I'm not sure whether my sr will count to a patch I've touched - why not
play it safe and add your review too ;-)
...
superreview canceled: [Bug 190974] [IMAP] Can't manage mail by 'deleted' flag : [Attachment 305277] Duplicate diff removedJeff Beckley <beckley@qualcomm.com> has canceled Jeff Beckley
<beckley@qualcomm.com>'s request for superreview:
Bug 190974: [IMAP] Can't manage mail by 'deleted' flag
https://bugzilla.mozilla.org/show_bug.cgi?id=190974
Attachment 305277: Duplicate diff removed
https://bugzilla.mozilla.org/attachment.cgi?id=305277&action=edit
------- Additional Comments from Jeff Beckley <beckley@qualcomm.com>
This patch adds the code to get the View popup on the toolbar to update before
it pops up, so it fixes the problem of the "Not Deleted" item sho...
superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from historyAndrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204513: try to purge invalid typed URLs from history
https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit
------- Additional Comments from Andrew Schultz <ajschult@verizon.net>
This fixes it and actually avoids purging redirected URLs (so BenB should be
happy :)). I thought it wou...
superreview cancelled: [Bug 179621] Inspector should use Editor's TransactionManager model : [Attachment 119620] Phase One patch: Transitional changes to Inspector's stack modelChristopher A. Aillon <caillon@gmail.com> has cancelled Alex Vincent
<ajvincent@juno.com>'s request for superreview:
Bug 179621: Inspector should use Editor's TransactionManager model
http://bugzilla.mozilla.org/show_bug.cgi?id=179621
Attachment 119620: Phase One patch: Transitional changes to Inspector's stack
model
http://bugzilla.mozilla.org/attachment.cgi?id=119620&action=edit
------- Additional Comments from Christopher A. Aillon <caillon@gmail.com>
I really don't understand these editor APIs enough to offer a passable review,
but it loo...
superreview requested: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's commentsneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Scott
MacGregor <mscott@mozilla.org> for superreview:
Bug 232722: change 'character coding' to 'character encoding'
http://bugzilla.mozilla.org/show_bug.cgi?id=232722
Attachment 140854: Addressed jshin's comments
http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit
...
superreview granted: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's commentsScott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 232722: change 'character coding' to 'character encoding'
http://bugzilla.mozilla.org/show_bug.cgi?id=232722
Attachment 140854: Addressed jshin's comments
http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
sorry, I didn't notice this bug had two patches in it needing review.
...
superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is showDoron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan
<roc@ocallahan.org> for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761
Attachment 149378: Change the check for if the dropdown is shown to the correct
way
http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit
...
superreview granted: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline viewMike Pinkerton <mikepinkerton@mac.com> has granted Chris Lawson
<bugzilla@chrislawson.net>'s request for superreview:
Bug 330946: Can drag bookmarks into address book collection of Show All
Bookmarks
https://bugzilla.mozilla.org/show_bug.cgi?id=330946
Attachment 224328: invalidates drop if it's going to occur on a smart folder's
outline view
https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit
------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com>
sr=pink
...
superreview requested: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline viewChris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 330946: Can drag bookmarks into address book collection of Show All
Bookmarks
https://bugzilla.mozilla.org/show_bug.cgi?id=330946
Attachment 224328: invalidates drop if it's going to occur on a smart folder's
outline view
https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit
...
superreview granted: [Bug 220773] Cancel overwrites data if an existing mime type is added or changed in helper applications : [Attachment 140372] Daniel's proposed changeBoris Zbarsky <bz-vacation@mit.edu> has granted Boris Zbarsky
<bz-vacation@mit.edu>'s request for superreview:
Bug 220773: Cancel overwrites data if an existing mime type is added or changed
in helper applications
http://bugzilla.mozilla.org/show_bug.cgi?id=220773
Attachment 140372: Daniel's proposed change
http://bugzilla.mozilla.org/attachment.cgi?id=140372&action=edit
------- Additional Comments from Boris Zbarsky <bz-vacation@mit.edu>
sr=bzbarsky
...
superreview cancelled: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220886] Addressing more of Gavin's commentsPam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google)
<pamg.bugs@gmail.com>'s request for superreview:
Bug 335441: Change tiny drop-down in browser search box into a button/drop-down
combo to the right of the search box
https://bugzilla.mozilla.org/show_bug.cgi?id=335441
Attachment 220886: Addressing more of Gavin's comments
https://bugzilla.mozilla.org/attachment.cgi?id=220886&action=edit
------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com>
(In reply to comment #33)
> + if (textBox.value && !text...
superreview cancelled: [Bug 325680] 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div : [Attachment 226219] alternative fix #2David Baron <dbaron@mozilla.com> has cancelled David Baron
<dbaron@mozilla.com>'s request for superreview:
Bug 325680: 'width: auto' incorrectly shrink wraps on blocks inside a
shrink-wrapped 'overflow'-non-'visible' div
https://bugzilla.mozilla.org/show_bug.cgi?id=325680
Attachment 226219: alternative fix #2
https://bugzilla.mozilla.org/attachment.cgi?id=226219&action=edit
...