superreview cancelled: [Bug 270342] In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" :

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Serge
GAUTHERIE <gautheri@noos.fr>'s request for superreview:
Bug 270342: In <threadPane.js>, "Warning: function MsgSortThreadPane does not
always return a value" and "Warning: function MsgToggleThreaded does not always
return a value"
https://bugzilla.mozilla.org/show_bug.cgi?id=270342

Attachment 166201: (Av1) <threadPane.js>
https://bugzilla.mozilla.org/attachment.cgi?id=166201&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
>     if (viewFlags & nsMsgViewFlagsType.kGroupBySort)
>     {
>	viewDebug("switching view to all msgs\n");
>-	return SwitchView("cmd_viewAllMsgs");
>+	SwitchView("cmd_viewAllMsgs");
>     }
> 
>-
>     dbview.sort(dbview.sortType, dbview.sortOrder);
>     UpdateSortIndicators(dbview.sortType, dbview.sortOrder);
> }
These changes won't work. The idea is not to do anything after switching the
view. You could do this in at least two ways; one way would be to readd the
return but on its own line; the second way would be to wrap the following lines
in an else block.
0
bugzilla
12/6/2004 12:05:16 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
613 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview granted: [Bug 270342] In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" : [
David Bienvenu <bienvenu@nventure.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 270342: In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=270342 Attachment 168078: (Av2b) <threadPane.js> https://bugzilla.mozilla.org/attachment.cgi?id=168078&action=edit ...

superreview requested: [Bug 270342] In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" : #2
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 270342: In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=270342 Attachment 166201: (Av1) <threadPane.js> https://bugzilla.mozilla.org/attachment.cgi?id=166201&action=edit ...

superreview requested: [Bug 270342] In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" : #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 270342: In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=270342 Attachment 168078: (Av2b) <threadPane.js> https://bugzilla.mozilla.org/attachment.cgi?id=168078&action=edit ...

superreview cancelled: [Bug 247698] In <mailWindowOverlay.js>, "Warning: function MsgOpenFromFile does not always return a value" : [Attachment 151233] (Av1) <mailWindowOverlay.js>
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 247698: In <mailWindowOverlay.js>, "Warning: function MsgOpenFromFile does not always return a value" http://bugzilla.mozilla.org/show_bug.cgi?id=247698 Attachment 151233: (Av1) <mailWindowOverlay.js> http://bugzilla.mozilla.org/attachment.cgi?id=151233&action=edit ...

superreview requested: [Bug 294989] In <editorInlineSpellCheck.js>, 4 "Warning: anonymous function does not always return a value" : [Attachment 186968] trivially remove all unused return values
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 294989: In <editorInlineSpellCheck.js>, 4 "Warning: anonymous function does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=294989 Attachment 186968: trivially remove all unused return values https://bugzilla.mozilla.org/attachment.cgi?id=186968&action=edit ------- Additional Comments from Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> All these return values are unused and can be remove...

superreview granted: [Bug 294989] In <editorInlineSpellCheck.js>, 4 "Warning: anonymous function does not always return a value" : [Attachment 186968] trivially remove all unused return values
Dan Mosedale <dmose@mozilla.org> has granted Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de>'s request for superreview: Bug 294989: In <editorInlineSpellCheck.js>, 4 "Warning: anonymous function does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=294989 Attachment 186968: trivially remove all unused return values https://bugzilla.mozilla.org/attachment.cgi?id=186968&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview requested: [Bug 247698] In <mailWindowOverlay.js>, "Warning: function MsgOpenFromFile does not always return a value" : [Attachment 151233] (Av1) <mailWindowOverlay.js>
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 247698: In <mailWindowOverlay.js>, "Warning: function MsgOpenFromFile does not always return a value" http://bugzilla.mozilla.org/show_bug.cgi?id=247698 Attachment 151233: (Av1) <mailWindowOverlay.js> http://bugzilla.mozilla.org/attachment.cgi?id=151233&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> This code was from {{ 1.189 bienvenu%nventure.com 2004-04-14 20:16 add ability to open .eml and .msg ...

superreview requested: [Bug 285588] In <globalOverlay.js>, (2) "Warning: function goQuitApplication does not always return a value" : [Attachment 177009] (Av1) <globalOverlay.js>
Serge GAUTHERIE <gautheri@noos.fr> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 285588: In <globalOverlay.js>, (2) "Warning: function goQuitApplication does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=285588 Attachment 177009: (Av1) <globalOverlay.js> https://bugzilla.mozilla.org/attachment.cgi?id=177009&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Came from {{ 1.7 ben%bengoodger.com 2003-11-30 21:40 Ensure that window closing that would cause t...

superreview granted: [Bug 285588] In <globalOverlay.js>, (2) "Warning: function goQuitApplication does not always return a value" : [Attachment 177009] (Av1) <globalOverlay.js>
Brian Ryner (IBM) <bryner@brianryner.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 285588: In <globalOverlay.js>, (2) "Warning: function goQuitApplication does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=285588 Attachment 177009: (Av1) <globalOverlay.js> https://bugzilla.mozilla.org/attachment.cgi?id=177009&action=edit ------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com> r+sr=bryner ...

superreview granted: [Bug 248275] In <am-identity-edit.js>, "Warning: function onOk does not always return a value" : [Attachment 151514] (Av1) <am-identity-edit.js>
Scott MacGregor <mscott@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 248275: In <am-identity-edit.js>, "Warning: function onOk does not always return a value" http://bugzilla.mozilla.org/show_bug.cgi?id=248275 Attachment 151514: (Av1) <am-identity-edit.js> http://bugzilla.mozilla.org/attachment.cgi?id=151514&action=edit ...

superreview requested: [Bug 248275] In <am-identity-edit.js>, "Warning: function onOk does not always return a value" : [Attachment 151514] (Av1) <am-identity-edit.js>
Serge GAUTHERIE <gautheri@noos.fr> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 248275: In <am-identity-edit.js>, "Warning: function onOk does not always return a value" http://bugzilla.mozilla.org/show_bug.cgi?id=248275 Attachment 151514: (Av1) <am-identity-edit.js> http://bugzilla.mozilla.org/attachment.cgi?id=151514&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> This code comes from {{ 1.1 <scott@scott-macgregor.org> 2004-05-12 15:02 Bug #44863 --> First cut at a UI ...

superreview granted: [Bug 349705] In <wizard.xml>, Strict "Warning: function cancel does not always return a value" : [Attachment 234985] (Av1-XPFE) <wizard.xml>
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge Gautherie <sgautherie.bz@free.fr>'s request for superreview: Bug 349705: In <wizard.xml>, Strict "Warning: function cancel does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=349705 Attachment 234985: (Av1-XPFE) <wizard.xml> https://bugzilla.mozilla.org/attachment.cgi?id=234985&action=edit ...

superreview requested: [Bug 349705] In <wizard.xml>, Strict "Warning: function cancel does not always return a value" : [Attachment 234985] (Av1-XPFE) <wizard.xml>
Serge Gautherie <sgautherie.bz@free.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 349705: In <wizard.xml>, Strict "Warning: function cancel does not always return a value" https://bugzilla.mozilla.org/show_bug.cgi?id=349705 Attachment 234985: (Av1-XPFE) <wizard.xml> https://bugzilla.mozilla.org/attachment.cgi?id=234985&action=edit ...

superreview granted: [Bug 237210] In <abCommon.js>, "Warning: function GetSelectedCardTypes does not always return a value"; plus various cleanups including a few additionnal fixes. : [Attachment 146
Scott MacGregor <mscott@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 237210: In <abCommon.js>, "Warning: function GetSelectedCardTypes does not always return a value"; plus various cleanups including a few additionnal fixes. http://bugzilla.mozilla.org/show_bug.cgi?id=237210 Attachment 146946: (Bv1b) <abCommon.js> additional cleanup http://bugzilla.mozilla.org/attachment.cgi?id=146946&action=edit ...

Web resources about - superreview cancelled: [Bug 270342] In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value" : - netscape.mozilla.reviewers

Resources last updated: 12/29/2015 6:38:10 PM