superreview cancelled: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin : [Attachment 205991] Patch rv2.0

Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has cancelled Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 111432: [FIRST] Mouse wheel scrolling doesn't work in print preview on page
margin
https://bugzilla.mozilla.org/show_bug.cgi?id=111432

Attachment 205991: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=205991&action=edit

------- Additional Comments from Masayuki Nakano (Mozilla Japan)
<masayuki@d-toybox.com>
This patch fix all wheel scroll problem on Print Preview.
This fixes the issue of the frame page.
E.g., please test on following page:
http://www.mozilla-japan.org/projects/toolkit/review.html

But I don't know this logic is correct.
> +  nsIPresShell *pPresShell = nsnull;
> +  for (PRUint32 i = 0; i < parentDoc->GetNumberOfShells(); i++) {
> +    nsIPresShell *tmpPresShell = parentDoc->GetShellAt(i);
> +    NS_ENSURE_TRUE(tmpPresShell, NS_ERROR_FAILURE);
> +    NS_ENSURE_TRUE(tmpPresShell->GetPresContext(), NS_ERROR_FAILURE);
> +    if (tmpPresShell->GetPresContext()->Type() == aPresContext->Type()) {
> +	 pPresShell = tmpPresShell;
> +	 break;
> +    }
> +  }

If a document has two or more print preview presContext, this code is wrong...
0
bugzilla
12/16/2005 3:54:25 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
374 Views

Similar Articles

[PageSpeed] 21

Reply:

Similar Artilces:

superreview requested: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin : [Attachment 205991] Patch rv2.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 111432: [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin https://bugzilla.mozilla.org/show_bug.cgi?id=111432 Attachment 205991: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=205991&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This is better than previous patch. But this patch cannot fix the case of on the frame page... Becau...

superreview cancelled: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin : [Attachment 205849] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 111432: [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin https://bugzilla.mozilla.org/show_bug.cgi?id=111432 Attachment 205849: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=205849&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This is not good. If on print preview mode, the mouse event is not fired. ...

superreview granted: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin or on frame page : [Attachment 206087] Patch rv3.0
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 111432: [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin or on frame page https://bugzilla.mozilla.org/show_bug.cgi?id=111432 Attachment 206087: Patch rv3.0 https://bugzilla.mozilla.org/attachment.cgi?id=206087&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> the GetPresShellAt code isn't great but I can't think of anything b...

superreview requested: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin : [Attachment 205849] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 111432: [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin https://bugzilla.mozilla.org/show_bug.cgi?id=111432 Attachment 205849: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=205849&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> We should always scroll root scroll view in print preview mode. ...

superreview requested: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin : [Attachment 206087] Patch rv3.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 111432: [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin https://bugzilla.mozilla.org/show_bug.cgi?id=111432 Attachment 206087: Patch rv3.0 https://bugzilla.mozilla.org/attachment.cgi?id=206087&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This patch fix all wheel scroll problem on Print Preview. This fixes the issue of the frame page. E....

superreview cancelled: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has cancelled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> "Patch B rev. 2" on bug 97283 now includes a fix for this bug too. ...

superreview cancelled: [Bug 255415] Scroll wheel doesn't work after selecting bookmark from toolbar until you move mouse. : [Attachment 196500] Find widget to scroll by walking the widget hierarchy
Mark Mentovai <mark@moxienet.com> has cancelled Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 255415: Scroll wheel doesn't work after selecting bookmark from toolbar until you move mouse. https://bugzilla.mozilla.org/show_bug.cgi?id=255415 Attachment 196500: Find widget to scroll by walking the widget hierarchy https://bugzilla.mozilla.org/attachment.cgi?id=196500&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> This patch needed to be revised slightly to accomodate a fix in bug 171680. The new patch, ...

superreview cancelled: [Bug 55751] Mnemonic doesn't work when IME is on : [Attachment 199445] Patch rv2.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 55751: Mnemonic doesn't work when IME is on https://bugzilla.mozilla.org/show_bug.cgi?id=55751 Attachment 199445: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=199445&action=edit ...

superreview granted: [Bug 212556] mouse wheel scrolling doesn't work on some other sites after window has been minimized : [Attachment 129497] patch
Johnny Stenback <jst@netscape.com> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 212556: mouse wheel scrolling doesn't work on some other sites after window has been minimized http://bugzilla.mozilla.org/show_bug.cgi?id=212556 Attachment 129497: patch http://bugzilla.mozilla.org/attachment.cgi?id=129497&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview requested: [Bug 212556] mouse wheel scrolling doesn't work on some other sites after window has been minimized : [Attachment 129497] patch
Brian Ryner <bryner@brianryner.com> has asked Johnny Stenback <jst@netscape.com> for superreview: Bug 212556: mouse wheel scrolling doesn't work on some other sites after window has been minimized http://bugzilla.mozilla.org/show_bug.cgi?id=212556 Attachment 129497: patch http://bugzilla.mozilla.org/attachment.cgi?id=129497&action=edit ...

superreview requested: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ...

superreview cancelled: [Bug 271815] GTK2 IM over-the-spot doesn't work with Chinese IM because the editor doesn't return correct caret position : [Attachment 223809] Patch rv1.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 271815: GTK2 IM over-the-spot doesn't work with Chinese IM because the editor doesn't return correct caret position https://bugzilla.mozilla.org/show_bug.cgi?id=271815 Attachment 223809: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=223809&action=edit ...

superreview cancelled: [Bug 292263] ATOK's Moji Palette that is like software keyboard doesn't work : [Attachment 182093] Patch rv1.0
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 292263: ATOK's Moji Palette that is like software keyboard doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=292263 Attachment 182093: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=182093&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I'm not qualified to review this.... Someone who knows something about IME and key events would have to look at this. ...

superreview requested: [Bug 255415] Scroll wheel doesn't work after selecting bookmark from toolbar until you move mouse. : [Attachment 196500] Find widget to scroll by walking the widget hierarchy
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 255415: Scroll wheel doesn't work after selecting bookmark from toolbar until you move mouse. https://bugzilla.mozilla.org/show_bug.cgi?id=255415 Attachment 196500: Find widget to scroll by walking the widget hierarchy https://bugzilla.mozilla.org/attachment.cgi?id=196500&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Rather than trying to get the pointed-to widget (or, in case of failure, the active widget) in nsMacEventHa...

Web resources about - superreview cancelled: [Bug 111432] [FIRST] Mouse wheel scrolling doesn't work in print preview on page margin : [Attachment 205991] Patch rv2.0 - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/4/2015 9:07:49 PM