superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin

Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this server"
https://bugzilla.mozilla.org/show_bug.cgi?id=93390

Attachment 327636: for checkin
https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit

------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk)
<wladow@gmail.com>
This patch compared to previous:
1) removes isBlockingImages() completely
2) uses serverLabel only (gets rid of shortenedserverLabel)
0
bugzilla
7/1/2008 6:21:22 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
547 Views

Similar Articles

[PageSpeed] 19

Reply:

Similar Artilces:

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=327455&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This adds separate accesskeys and as requested changes the way how we hide/unhide both menu-items (hide both first, unh...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This is updated v3 patch with neil's comments addressed: 1) shows menu-item only for schemes with hosts (FX appro...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=307048&action=edit ...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=3D310268&action=3Dedit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40)=0D > I don't like this. I think we should hide the menuitems if we can't get a= =0D > host.=0...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
neil@parkwaycc.co.uk <neil@httl.net> has denied Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, so this patch is almost ready, but I checked with L10N and we do want separate accesskeys for block and unblock. While y...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D327455&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Wow, that code looks much better now :-)=0D =0D >- gContextMenu.showItem=0D >- ("context-blocki...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
neil@parkwaycc.co.uk <neil@httl.net> has denied zug_treno@yahoo.com's reque= st for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=3D307048&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ if (scheme =3D=3D "file") {=0D >+ serverLabel =3D "localhost&qu...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=310268&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK, the menuitems aren&...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
neil@parkwaycc.co.uk <neil@httl.net> has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So, if you could fix the code to only show the menuitem for schemes with hosts, and while y...

superreview requested: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog update
Mike Connor <mconnor@myrealbox.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server" http://bugzilla.mozilla.org/show_bug.cgi?id=102269 Attachment 143120: patch v2 including dialog update http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> alec, this one is pretty trivial if you have time before freeze... ...

superreview requested: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Henrik Lynggaard Hansen <admin@mozillatranslator.org> has asked Scott MacGregor (on holiday until 01/02/2004) <mscott@mozilla.org> for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ------- Additional Comments from Henrik Lynggaard Hansen <admin@mozillatranslator.org> review please ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

Web resources about - superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin - mozilla.dev.super-review

Resources last updated: 12/20/2015 3:54:05 AM