superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5

zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for
superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this serve=
r"
https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390

Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
https://bugzilla.mozilla.org/attachment.cgi?id=3D310268&action=3Dedit

------- Additional Comments from zug_treno@yahoo.com
(In reply to comment #40)=0D
> I don't like this. I think we should hide the menuitems if we can't get a=
 =0D
> host.=0D
=0D
I think it would be better to show '(Un)Block Images from Unknown Server'
instead of hiding the menuitem. That way users can still block the images
despite the fact that SeaMonkey can't show them the hostname.=0D
=0D
> Or possibly even borrow from the Firefox code which I believe uses a=0D
> single menuitem, and works out whether it needs to block or unblock.=0D
=0D
SeaMonkey uses a single changing (un)block menuitem, Firefox uses the
notification bar to undo blocking (see Firefox bug 345349).=0D
=0D
> >+	      if (cookieContextMenu.isBlockingImages()) {=0D
> You could probably inline the code, since you already have a URI.=0D
=0D
I'm not sure what you mean by this, could you explain what I should do here=
?=0D
=0D
> >+blockImage=3DBlock Images from %S=0D
> >+unblockImage=3DUnblock Images from %S=0D
> You should also remove the old strings.=0D
=0D
It seems that the old strings are still used further down.=
0
bugzilla
3/18/2008 4:06:02 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
670 Views

Similar Articles

[PageSpeed] 11

Reply:

Similar Artilces:

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=310268&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK, the menuitems aren&...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=307048&action=edit ...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
neil@parkwaycc.co.uk <neil@httl.net> has denied zug_treno@yahoo.com's reque= st for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=3D307048&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ if (scheme =3D=3D "file") {=0D >+ serverLabel =3D "localhost&qu...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
neil@parkwaycc.co.uk <neil@httl.net> has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So, if you could fix the code to only show the menuitem for schemes with hosts, and while y...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This is updated v3 patch with neil's comments addressed: 1) shows menu-item only for schemes with hosts (FX appro...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=327455&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This adds separate accesskeys and as requested changes the way how we hide/unhide both menu-items (hide both first, unh...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This patch compared to previous: 1) removes isBlockingImages() completely 2) uses serverLabel only (gets rid ...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D327455&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Wow, that code looks much better now :-)=0D =0D >- gContextMenu.showItem=0D >- ("context-blocki...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
neil@parkwaycc.co.uk <neil@httl.net> has denied Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, so this patch is almost ready, but I checked with L10N and we do want separate accesskeys for block and unblock. While y...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 302695] Misleading message when starting Thunderbird in "Ask for Online state" mode
timeless@gmail.com <timeless@bemail.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 302695: Misleading message when starting Thunderbird in "Ask for Online state" mode - there is no "File -> Work Online" https://bugzilla.mozilla.org/show_bug.cgi?id=302695 Attachment 205036: Patch v.2 (SeaMonkey) https://bugzilla.mozilla.org/attachment.cgi?id=205036&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

Web resources about - superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 - mozilla.dev.super-review

Resources last updated: 12/28/2015 5:51:04 PM