superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a

Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 79603: Disable color controls when 'Use system color' is checked
https://bugzilla.mozilla.org/show_bug.cgi?id=79603

Attachment 313971: Label disabling patch v1.1a
https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit

------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk>
Changes since v1.1:
* Labels now have the same disabled status as their associated colorpicker.
0
bugzilla
4/6/2008 10:02:01 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
581 Views

Similar Articles

[PageSpeed] 40

Reply:

Similar Artilces:

superreview granted: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=312934&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Correct patch that doesn't try adding a second pref-appearance.js entry to jar.mn ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> This patch: * Disables the color pickers when system colors box is checked as long as picker pref is not locked. * Re-enables the col...

superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Unfortunately disabling colourpickers doesn't work correctly - the binding simply makes a bold claim that it's...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.0a - addressed review comments: * use onchange on preference. * use preference value instead of checkbox setting. * set disabled prop...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ...

superreview requested: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE]
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 58048: [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE] https://bugzilla.mozilla.org/show_bug.cgi?id=58048 Attachment 264970: patch https://bugzilla.mozilla.org/attachment.cgi?id=264970&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This patch fixes this bug and bug 255829 and improves on the fix for bug 255411. It reimplements the preference at the rule mapping...

superreview requested: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> In the Library, you cannot remove the Name column which is represented by a disabled check menu item on the column menu to the top-righ...

superreview requested: [Bug 282141] Use system colors pref uses the wrong color for default background : [Attachment 174243] Patch
Christopher A. Aillon <caillon@gmail.com> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 282141: Use system colors pref uses the wrong color for default background https://bugzilla.mozilla.org/show_bug.cgi?id=282141 Attachment 174243: Patch https://bugzilla.mozilla.org/attachment.cgi?id=174243&action=edit ------- Additional Comments from Christopher A. Aillon <caillon@gmail.com> Use base, and get rid of an extra assignment of aColor (it gets assigned 0 in the default: branch of the switch) ...

superreview granted: [Bug 419167] right/left borders don't adopt user-defined color (colour) scheme (untick 'Allow pages to choose their own colors') : [Attachment 305371] patch without the array
David Baron [:dbaron] <dbaron@mozilla.com> has granted superreview: Bug 419167: right/left borders don't adopt user-defined color (colour) sche= me (untick 'Allow pages to choose their own colors') https://bugzilla.mozilla.org/show_bug.cgi?id=3D419167 Attachment 305371: patch without the array https://bugzilla.mozilla.org/attachment.cgi?id=3D305371&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=3Ddbaron.=0D =0D Why don't we just get this one in and I'll worry about converting this code over later...

superreview requested: [Bug 287648] Unify 'request' object interface for DNS and PPS asyncResolve methods : [Attachment 179785] patch: make DNS service use nsICancelable (v1)
Darin Fisher <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 287648: Unify 'request' object interface for DNS and PPS asyncResolve methods https://bugzilla.mozilla.org/show_bug.cgi?id=287648 Attachment 179785: patch: make DNS service use nsICancelable (v1) https://bugzilla.mozilla.org/attachment.cgi?id=179785&action=edit ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

superreview requested: [Bug 241147] DecodeStructParticle fails on 'sequences' and 'choices' : [Attachment 146641] v1 patch
Darin Fisher (IBM) <darin@meer.net> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 241147: DecodeStructParticle fails on 'sequences' and 'choices' http://bugzilla.mozilla.org/show_bug.cgi?id=241147 Attachment 146641: v1 patch http://bugzilla.mozilla.org/attachment.cgi?id=146641&action=edit ...

Web resources about - superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a - mozilla.dev.super-review

Resources last updated: 1/2/2016 9:21:03 PM