superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0

Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 79603: Disable color controls when 'Use system color' is checked
https://bugzilla.mozilla.org/show_bug.cgi?id=79603

Attachment 312933: Disable and lock checking patch v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit

------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk>
This patch:
* Disables the color pickers when system colors box is checked as long as
picker pref is not locked.
* Re-enables the color pickers when system colors box is unchecked as long as
picker pref is not locked.
0
bugzilla
4/1/2008 7:50:25 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
468 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=312934&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Correct patch that doesn't try adding a second pref-appearance.js entry to jar.mn ...

superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Unfortunately disabling colourpickers doesn't work correctly - the binding simply makes a bold claim that it's...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.1: * Labels now have the same disabled status as their associated colorpicker. ...

superreview granted: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.0a - addressed review comments: * use onchange on preference. * use preference value instead of checkbox setting. * set disabled prop...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ...

superreview requested: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> In the Library, you cannot remove the Name column which is represented by a disabled check menu item on the column menu to the top-righ...

superreview requested: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE]
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 58048: [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE] https://bugzilla.mozilla.org/show_bug.cgi?id=58048 Attachment 264970: patch https://bugzilla.mozilla.org/attachment.cgi?id=264970&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This patch fixes this bug and bug 255829 and improves on the fix for bug 255411. It reimplements the preference at the rule mapping...

superreview requested: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Katakai-san, please hurry up to review this, if you can.=0D =0D Roc: Would you r+sr for this? Even if we...

superreview granted: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Michael Ventnor <ventnor.bugzilla@yahoo.com.au>'s request for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ...

superreview requested: [Bug 290920] If an element has 'font-variant: small-caps', the selection color is broken : [Attachment 181120] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 290920: If an element has 'font-variant: small-caps', the selection color is broken https://bugzilla.mozilla.org/show_bug.cgi?id=290920 Attachment 181120: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=181120&action=edit ...

superreview requested: [Bug 290920] If an element has 'font-variant: small-caps', the selection color is broken : [Attachment 181279] Patch rv2.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 290920: If an element has 'font-variant: small-caps', the selection color is broken https://bugzilla.mozilla.org/show_bug.cgi?id=290920 Attachment 181279: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=181279&action=edit ...

superreview requested: [Bug 290920] If an element has 'font-variant: small-caps', the selection color is broken : [Attachment 181296] Patch rv3.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 290920: If an element has 'font-variant: small-caps', the selection color is broken https://bugzilla.mozilla.org/show_bug.cgi?id=290920 Attachment 181296: Patch rv3.0 https://bugzilla.mozilla.org/attachment.cgi?id=181296&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Sorry. I have two mistakes. 1. You're right. The "if" check is wrong. I removed. 2. The color setti...

Web resources about - superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0 - mozilla.dev.super-review

Resources last updated: 1/18/2016 6:02:34 AM