superreview requested: [Bug 74959] implement mail "back" and "forward" #2

Karsten D=C3=BCsterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 74959: implement mail "back" and "forward"
https://bugzilla.mozilla.org/show_bug.cgi?id=3D74959

Attachment 283929: SM port, v2: addressed Neil's review comments
https://bugzilla.mozilla.org/attachment.cgi?id=3D283929&action=3Dedit

------- Additional Comments from Karsten D=C3=BCsterloh <mnyromyr@tprac.de>
Hartmut did most of the changes Neil requested, but asked me to fill in the
PopulateHistoryMenu stuff where he lacked intimate mailnews XUL/JS knowledg=
e.=0D
=0D
Hartmut, many thanks for putting together all these cumbersome details this
patch requires!=0D
=0D
Changes to hafi's patch:=0D
- reordered any back/forward stuff, so that the back code is always before =
the
forward one=0D
- clean-up of the PopulateHistoryMenu method, so that I don't think that
drawing the loop out into the Init functions is necessary anymore; also por=
ted
over a TB fix for MIME-encoded subjects and authors=
0
bugzilla
10/7/2007 9:30:07 PM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
350 Views

Similar Articles

[PageSpeed] 0

Reply:

Similar Artilces:

superreview requested: [Bug 74959] implement mail "back" and "forward"
Hartmut Figge <h.figge@gmx.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 282902: SM port https://bugzilla.mozilla.org/attachment.cgi?id=282902&action=edit ------- Additional Comments from Hartmut Figge <h.figge@gmx.de> Adaption for SM suiterunner ...

superreview granted: [Bug 74959] implement mail "back" and "forward" #2
Karsten D=C3=BCsterloh <mnyromyr@tprac.de> has granted superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=3D74959 Attachment 284384: SM port, v3: checked-in version https://bugzilla.mozilla.org/attachment.cgi?id=3D284384&action=3Dedit ------- Additional Comments from Karsten D=C3=BCsterloh <mnyromyr@tprac.de> (In reply to comment #48)=0D > >That is my fault/wish. The original TB patch has 20 items, which I feel = are too=0D > >*few*, so I recommended 50.=0D > Well, I'm n...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234956] fix enabling/disabling of forward/back buttons in stand-alone msg window
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234956: fix enabling/disabling of forward/back buttons in stand-alone msg window https://bugzilla.mozilla.org/attachment.cgi?id=234956&action=edit ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 233310] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 233310: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=233310&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this is getting to where I'd like to get it reviewed and landed... ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234697] fix the dtd entities.
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer [:ss] <sspitzer@mozilla.com> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234697: fix the dtd entities. https://bugzilla.mozilla.org/attachment.cgi?id=234697&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> use consistent names for the go nav menu item entities. ...

superreview granted: [Bug 74959] implement mail "back" and "forward"
neil@parkwaycc.co.uk <neil@httl.net> has granted Karsten D=C3=BCsterloh <mnyromyr@tprac.de>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=3D74959 Attachment 283929: SM port, v2: addressed Neil's review comments https://bugzilla.mozilla.org/attachment.cgi?id=3D283929&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >Index: mailnews/base/resources/content/mail3PaneWindowCommands.js=0D >+ case "button_goBack":=0D ...

superreview denied: [Bug 74959] implement mail "back" and "forward"
neil@parkwaycc.co.uk <neil@httl.net> has denied Hartmut Figge <h.figge@gmx.de>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=3D74959 Attachment 282902: SM port https://bugzilla.mozilla.org/attachment.cgi?id=3D282902&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ case "button_goForward":=0D >+ case "button_goBack":=0D >+ case "cmd_goForward":=0D >+ case "cmd_goBack":=0D &g...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234707] fix Neil's issue
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer [:ss] <sspitzer@mozilla.com> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234707: fix Neil's issue https://bugzilla.mozilla.org/attachment.cgi?id=234707&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> remove unneeded code as pointed out by Neil. ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234936] fix navigation in stand-alone msg window
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234936: fix navigation in stand-alone msg window https://bugzilla.mozilla.org/attachment.cgi?id=234936&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this gets navigation working in a stand-alone msg window (for both normal folders and saved searches). I'll fix updating the enabling/disabling...

superreview granted: [Bug 74959] implement mail "back" and "forward" : [Attachment 234956] fix enabling/disabling of forward/back buttons in stand-alone msg window
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234956: fix enabling/disabling of forward/back buttons in stand-alone msg window https://bugzilla.mozilla.org/attachment.cgi?id=234956&action=edit ...

superreview granted: [Bug 74959] implement mail "back" and "forward" : [Attachment 233310] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 233310: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=233310&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> woot! you should be able to use the new icons which are now on the branch and trunk for forward / back. The last two icons in: http://lxr.mozilla.org/seamo...

superreview granted: [Bug 74959] implement mail "back" and "forward" : [Attachment 234697] fix the dtd entities.
Seth Spitzer [:ss] <sspitzer@mozilla.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234697: fix the dtd entities. https://bugzilla.mozilla.org/attachment.cgi?id=234697&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> sr=sspitzer, acting sr for mailnews (while mscott is away) ...

superreview granted: [Bug 74959] implement mail "back" and "forward" : [Attachment 234707] fix Neil's issue
Seth Spitzer [:ss] <sspitzer@mozilla.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234707: fix Neil's issue https://bugzilla.mozilla.org/attachment.cgi?id=234707&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> sr=sspitzer, acting sr for mscott. ...

superreview granted: [Bug 74959] implement mail "back" and "forward" : [Attachment 234936] fix navigation in stand-alone msg window
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234936: fix navigation in stand-alone msg window https://bugzilla.mozilla.org/attachment.cgi?id=234936&action=edit ...

Web resources about - superreview requested: [Bug 74959] implement mail "back" and "forward" #2 - mozilla.dev.super-review

Resources last updated: 11/22/2015 1:30:21 AM