superreview requested: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333894] Fix regression per Neil's suggestion

Kent James (:rkent) <kent@caspia.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk
Settings" panel
https://bugzilla.mozilla.org/show_bug.cgi?id=444994

Attachment 333894: Fix regression per Neil's suggestion
https://bugzilla.mozilla.org/attachment.cgi?id=333894&action=edit

------- Additional Comments from Kent James (:rkent) <kent@caspia.com>
So this is what you had in mind, right?
0
bugzilla
8/15/2008 5:57:00 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
481 Views

Similar Articles

[PageSpeed] 22

Reply:

Similar Artilces:

superreview granted: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333894] Fix regression per Neil's suggestion
neil@parkwaycc.co.uk <neil@httl.net> has granted Kent James (:rkent) <kent@caspia.com>'s request for superreview: Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel https://bugzilla.mozilla.org/show_bug.cgi?id=444994 Attachment 333894: Fix regression per Neil's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=333894&action=edit ...

superreview requested: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333790] Stop nulling variables
Kent James (:rkent) <kent@caspia.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel https://bugzilla.mozilla.org/show_bug.cgi?id=444994 Attachment 333790: Stop nulling variables https://bugzilla.mozilla.org/attachment.cgi?id=333790&action=edit ...

superreview denied: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333790] Stop nulling variables
neil@parkwaycc.co.uk <neil@httl.net> has denied Kent James (:rkent) <kent@caspia.com>'s request for superreview: Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel https://bugzilla.mozilla.org/show_bug.cgi?id=444994 Attachment 333790: Stop nulling variables https://bugzilla.mozilla.org/attachment.cgi?id=333790&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> No, I don't think this is right. ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146706] (Ov1) </profile/*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Conrad Carlen <ccarlen@mac.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146706: (Ov1) </profile/*> http://bugzilla.mozilla.org/attachment.cgi?id=146706&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> I have no compiler: Could you (super-)review/compile/test/check in this patch ? Thanks. ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137586] (Iv1c) </xpinstall/*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Daniel Veditz <dveditz+bmo@cruzio.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137586: (Iv1c) </xpinstall/*> http://bugzilla.mozilla.org/attachment.cgi?id=137586&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 23) ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146707] (Qv1) </ipc/*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Daniel (Leaf) Nunes <leaf@mozilla.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146707: (Qv1) </ipc/*> http://bugzilla.mozilla.org/attachment.cgi?id=146707&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> I have no compiler: Could you (super-)review/compile/test/check in this patch ? Thanks. ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146706] (Pv1) </profile/*>
Serge GAUTHERIE <gautheri@noos.fr> has asked rbs@maths.uq.edu.au for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146706: (Pv1) </profile/*> http://bugzilla.mozilla.org/attachment.cgi?id=146706&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No (super-)review from <ccarlen@mac.com> since '2004-04-21' :-( *** I have no compiler: Could you (super-)rev...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146705] (Ov1) </mailnews/*> additional
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146705: (Ov1) </mailnews/*> additional http://bugzilla.mozilla.org/attachment.cgi?id=146705&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> I have no compiler: Could you (super-)review/compile/test/check in this...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1: "with no function call") : [Attachment 137553] (Iv1b) </xpinstall/*>, with no function call
Benjamin Smedberg <bsmedberg@covad.net> has asked Daniel Veditz <dveditz+bmo@cruzio.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137553: (Iv1b) </xpinstall/*>, with no function call http://bugzilla.mozilla.org/attachment.cgi?id=137553&action=edit ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146707] (Qv1) </ipc/*> #2
Daniel (Leaf) Nunes <leaf@mozilla.org> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146707: (Qv1) </ipc/*> http://bugzilla.mozilla.org/attachment.cgi?id=146707&action=edit ------- Additional Comments from Daniel (Leaf) Nunes <leaf@mozilla.org> punting super-revew to scc; this looks fine to me, scott, since, well, the variable is unused and the func...

Web resources about - superreview requested: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333894] Fix regression per Neil's suggestion - mozilla.dev.super-review

Resources last updated: 12/23/2015 1:44:05 PM