superreview requested: [Bug 435362] [FIX]cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe : [Attachment 322807] Fix the parens

Boris Zbarsky (very little time until late May) <bzbarsky@mit.edu> has asked
Jonas Sicking (:sicking) <jonas@sicking.cc> for superreview:
Bug 435362: [FIX]cross-domain javascript security restrictions incorrectly
applied to local HTML files loaded into an iframe
https://bugzilla.mozilla.org/show_bug.cgi?id=435362

Attachment 322807: Fix the parens
https://bugzilla.mozilla.org/attachment.cgi?id=322807&action=edit

------- Additional Comments from Boris Zbarsky (very little time until late
May) <bzbarsky@mit.edu>
sicking's right: the patch was missing a pair of parens.  The desired check is:


  "not external and not owner and inherit flag and (inherits or file)"
0
bugzilla
5/28/2008 5:21:47 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
514 Views

Similar Articles

[PageSpeed] 16

Reply:

Similar Artilces:

superreview granted: [Bug 435362] [FIX]cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe : [Attachment 322807] Fix the parens
Jonas Sicking (:sicking) <jonas@sicking.cc> has granted Boris Zbarsky (very little time until late May) <bzbarsky@mit.edu>'s request for superreview: Bug 435362: [FIX]cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe https://bugzilla.mozilla.org/show_bug.cgi?id=435362 Attachment 322807: Fix the parens https://bugzilla.mozilla.org/attachment.cgi?id=322807&action=edit ...

superreview requested: [Bug 435362] cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe : [Attachment 322592] I think this is quite safe
Boris Zbarsky (very little time until late May) <bzbarsky@mit.edu> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 435362: cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe https://bugzilla.mozilla.org/show_bug.cgi?id=435362 Attachment 322592: I think this is quite safe https://bugzilla.mozilla.org/attachment.cgi?id=322592&action=edit ------- Additional Comments from Boris Zbarsky (very little time until late May) <bzbarsky@mit.edu> This makes sure to set the owner to our inheri...

superreview granted: [Bug 435362] cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe : [Attachment 322592] I think this is quite safe
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (very little time until late May) <bzbarsky@mit.edu>'s request for superreview: Bug 435362: cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe https://bugzilla.mozilla.org/show_bug.cgi?id=435362 Attachment 322592: I think this is quite safe https://bugzilla.mozilla.org/attachment.cgi?id=322592&action=edit ...

superreview requested: [Bug 270380] Local image files in HTML signature file on top don't get attached in replies : [Attachment 198934] fixes for the bug
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 270380: Local image files in HTML signature file on top don't get attached in replies https://bugzilla.mozilla.org/show_bug.cgi?id=270380 Attachment 198934: fixes for the bug https://bugzilla.mozilla.org/attachment.cgi?id=198934&action=edit ...

superreview requested: [Bug 334515] crash initialising iframe as html edit where html loaded contains a second iframe [@ nsQueryInterface::operator()] : [Attachment 219692] Patch to fix
Jonas Sicking <bugmail@sicking.cc> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 334515: crash initialising iframe as html edit where html loaded contains a second iframe [@ nsQueryInterface::operator()] https://bugzilla.mozilla.org/show_bug.cgi?id=334515 Attachment 219692: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=219692&action=edit ------- Additional Comments from Jonas Sicking <bugmail@sicking.cc> This fixes the crash. I no longer crash from the testcases in this bug, bug 331981 and bug 211348. I still see very strang...

superreview granted: [Bug 270380] Local image files in HTML signature file on top don't get attached in replies : [Attachment 198934] fixes for the bug
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 270380: Local image files in HTML signature file on top don't get attached in replies https://bugzilla.mozilla.org/show_bug.cgi?id=270380 Attachment 198934: fixes for the bug https://bugzilla.mozilla.org/attachment.cgi?id=198934&action=edit ...

superreview granted: [Bug 334515] crash initialising iframe as html edit where html loaded contains a second iframe [@ nsQueryInterface::operator()] : [Attachment 219692] Patch to fix
David Baron <dbaron@mozilla.com> has granted Jonas Sicking <bugmail@sicking.cc>'s request for superreview: Bug 334515: crash initialising iframe as html edit where html loaded contains a second iframe [@ nsQueryInterface::operator()] https://bugzilla.mozilla.org/show_bug.cgi?id=334515 Attachment 219692: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=219692&action=edit ...

superreview requested: [Bug 223055] [FIX]try to open a local html-file, asks for saving : [Attachment 133837] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 223055: [FIX]try to open a local html-file, asks for saving http://bugzilla.mozilla.org/show_bug.cgi?id=223055 Attachment 133837: Patch http://bugzilla.mozilla.org/attachment.cgi?id=133837&action=edit ...

superreview requested: [Bug 301582] Win32 HTML clipboard format broken by patch for Bug #244685 (StartFragment offset incorrect) : [Attachment 190025] Fix to prevent offsets from being incorrect
Daniel Atallah <daniel_atallah@yahoo.com> has asked for superreview: Bug 301582: Win32 HTML clipboard format broken by patch for Bug #244685 (StartFragment offset incorrect) https://bugzilla.mozilla.org/show_bug.cgi?id=301582 Attachment 190025: Fix to prevent offsets from being incorrect https://bugzilla.mozilla.org/attachment.cgi?id=190025&action=edit ...

superreview requested: [Bug 248870] When javascript loaded in an IFRAME calls self.resizeTo the whole window is resized. : [Attachment 152171] Fix
Johnny Stenback <jst@mozilla.jstenback.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 248870: When javascript loaded in an IFRAME calls self.resizeTo the whole window is resized. http://bugzilla.mozilla.org/show_bug.cgi?id=248870 Attachment 152171: Fix http://bugzilla.mozilla.org/attachment.cgi?id=152171&action=edit ...

superreview requested: [Bug 137315] [FIX]Incorrect line numbers in HTML files (part 2) : [Attachment 141378] Merged to trunk
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 137315: [FIX]Incorrect line numbers in HTML files (part 2) http://bugzilla.mozilla.org/show_bug.cgi?id=137315 Attachment 141378: Merged to trunk http://bugzilla.mozilla.org/attachment.cgi?id=141378&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> jst, what do you think? This should make our line number reporting in the JS console finally right... ...

superreview requested: [Bug 301582] Win32 HTML clipboard format broken by patch for Bug #244685 (StartFragment offset incorrect) : [Attachment 190025] Fix to prevent offsets from being incorrect #2
Daniel Atallah <daniel_atallah@yahoo.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 301582: Win32 HTML clipboard format broken by patch for Bug #244685 (StartFragment offset incorrect) https://bugzilla.mozilla.org/show_bug.cgi?id=301582 Attachment 190025: Fix to prevent offsets from being incorrect https://bugzilla.mozilla.org/attachment.cgi?id=190025&action=edit ...

superreview requested: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170288] Proposed fix, bz's fix with window.open() etc fixed.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170288: Proposed fix, bz's fix with window.open() etc fixed. https://bugzilla.mozilla.org/attachment.cgi?id=170288&action=edit ...

superreview requested: [Bug 280947] Fix for bug 279945 breaks dragging of dynamic images : [Attachment 174494] Additional patch needed to download the right file with the fixed extension
Johnny Stenback <jst@mozilla.org> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 280947: Fix for bug 279945 breaks dragging of dynamic images https://bugzilla.mozilla.org/show_bug.cgi?id=280947 Attachment 174494: Additional patch needed to download the right file with the fixed extension https://bugzilla.mozilla.org/attachment.cgi?id=174494&action=edit ...

Web resources about - superreview requested: [Bug 435362] [FIX]cross-domain javascript security restrictions incorrectly applied to local HTML files loaded into an iframe : [Attachment 322807] Fix the parens - mozilla.dev.super-review

Resources last updated: 12/3/2015 12:15:19 AM