superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 317598] New version

jag (Peter Annema) <jag@tty.nl> has asked neil@parkwaycc.co.uk <neil@httl.n=
et>
for superreview:
Bug 429926: Make Cmd+T open a new window when no browser windows are open
https://bugzilla.mozilla.org/show_bug.cgi?id=3D429926

Attachment 317598: New version
https://bugzilla.mozilla.org/attachment.cgi?id=3D317598&action=3Dedit

------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
I was thinking we could just check gBrowser at the beginning of this functi=
on
and call OpenBrowserWindow(), but that would use the "new window" pref sett=
ing
instead of the "new tab" pref setting, which is probably not what we want.=
=0D
=0D
>Index: suite/browser/navigator.js=0D
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0D
>+	    uriToLoad =3D gBrowser ? getWebNavigation().currentURI.spec :=0D
>+=09=09=20=20=20=20=20=20=20
Components.classes["@mozilla.org/browser/global-history;2"]=0D
>+=09=09=09=09=20
..getService(Components.interfaces.nsIBrowserHistory).lastPageVisited;=0D
=0D
Please indent like this:=0D
=0D
	  uriToLoad =3D gBrowser ? getWebNavigation().currentURI.spec =0D
			       :
Components.classes["@mozilla.org/browser/global-history;2"]=0D
=09=09=09=09=09=20=20
..getService(Components.interfaces.nsIBrowserHistory)=0D
					   .lastPageVisited;=0D
=0D
Or with no wrapping on 80:=0D
=0D
	  const HISTORY_CONTRACTID =3D "@mozilla.org/browser/global-history;2";=0D
	  const nsIBrowserHistory =3D Components.interfaces.nsIBrowserHistory;=0D
	  uriToLoad =3D gBrowser ? getWebNavigation().currentURI.spec =0D
			       : Components.classes[HISTORY_CONTRACTID]=0D
					   .getService(nsIBrowserHistory)=0D
					   .lastPageVisited;=0D
=0D
r=3Djag with at least the indentation nit fixed.=
0
bugzilla
4/29/2008 8:40:14 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
814 Views

Similar Articles

[PageSpeed] 45

Reply:

Similar Artilces:

superreview granted: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 317598] New version
neil@parkwaycc.co.uk <neil@httl.net> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 317598: New version https://bugzilla.mozilla.org/attachment.cgi?id=317598&action=edit ...

superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
Stefan <stefanh@bluebottle.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview granted: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
neil@parkwaycc.co.uk <neil@httl.net> has granted Stefan <stefanh@inbox.com>'s request for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wi
Dan M <danm.moz@gmail.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ...

superreview requested: [Bug 355352] [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window : [Attachment 248569] New and improv
Josh Aas <joshmoz@gmail.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 355352: [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window https://bugzilla.mozilla.org/show_bug.cgi?id=355352 Attachment 248569: New and improved patch https://bugzilla.mozilla.org/attachment.cgi?id=248569&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> The minor changes remaining (comments mostly) can be made on checkin. ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> (In reply to comment #60) > (From update of attachment 227564 [edit]) > So this w...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ...

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wind
Johnny Stenback <jst@mozilla.jstenback.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview granted: [Bug 355352] [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window : [Attachment 248569] New and improved
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 355352: [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window https://bugzilla.mozilla.org/show_bug.cgi?id=355352 Attachment 248569: New and improved patch https://bugzilla.mozilla.org/attachment.cgi?id=248569&action=edit ------- Additional Comments from Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> moa=bsmedberg (I didn't revi...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a first try at closing the window after the external app handler has done its work. This se...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 227974: Unbitrots it https://bugzilla.mozilla.org/attachment.cgi?id=227974&action=edit ------- Additional Comments from froodiantherapy <stridey@gmail.com> This patch unbitrots the previous one. It touches all the high-traffic files, and took a long time to get back up to date, so lets try to get this review...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy (mostly gone until June 4) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy (mostly gone until June 4) <stridey@gmail.com> Assuming that this has cl+ too. ;) ...

superreview granted: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

Web resources about - superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 317598] New version - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/3/2015 3:17:50 PM