superreview requested: [Bug 429230] memory leak in pkix_CheckCert function : [Attachment 315876] Patch v1(remove debug code that leaks memory)

Alexei Volkov <alexei.volkov.bugs@sun.com> has asked Kai Engert (:kaie)
<kengert@redhat.com> for superreview:
Bug 429230: memory leak in pkix_CheckCert function
https://bugzilla.mozilla.org/show_bug.cgi?id=429230

Attachment 315876: Patch v1(remove debug code that leaks memory)
https://bugzilla.mozilla.org/attachment.cgi?id=315876&action=edit

------- Additional Comments from Alexei Volkov <alexei.volkov.bugs@sun.com>
Nominating the bug for 3.12.0. 

checkerCheck(a pointer to pkix_PolicyChecker_Check) will throw an error in case
when cert does not pass the check. In other words a leak is created every time
when cert fails validation.
0
bugzilla
4/18/2008 10:47:34 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
632 Views

Similar Articles

[PageSpeed] 19

Reply:

Similar Artilces:

superreview granted: [Bug 429230] memory leak in pkix_CheckCert function : [Attachment 315876] Patch v1(remove debug code that leaks memory)
Kai Engert (:kaie) <kengert@redhat.com> has granted Alexei Volkov <alexei.volkov.bugs@sun.com>'s request for superreview: Bug 429230: memory leak in pkix_CheckCert function https://bugzilla.mozilla.org/show_bug.cgi?id=429230 Attachment 315876: Patch v1(remove debug code that leaks memory) https://bugzilla.mozilla.org/attachment.cgi?id=315876&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> You remove a lot of code, is that all equivalent to PKIX_CHECK ? ...

superreview requested: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 318566] Fix memory leaks
Mark Banner <bugzilla@standard8.plus.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=431414 Attachment 318566: Fix memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=318566&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> This fixes the memory leaks I have found by going through: http://mxr.mozilla.org/seamonkey/search?string=array&...

superreview requested: [Bug 262758] live bookmarks leak memory/RDF resources : [Attachment 161801] 262758-livemark-refresh-leaks-memory-0.patch
vladimir@pobox.com has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 262758: live bookmarks leak memory/RDF resources https://bugzilla.mozilla.org/show_bug.cgi?id=262758 Attachment 161801: 262758-livemark-refresh-leaks-memory-0.patch https://bugzilla.mozilla.org/attachment.cgi?id=161801&action=edit ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 318566] Fix memory leaks
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocat= ed arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=3D431414 Attachment 318566: Fix memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=3D318566&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ // Ensure any old data is freed if necessary.=0D >+ if (mSearchAttrs) {=0D ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 319371] Fix memory leaks v2
Mark Banner <bugzilla@standard8.plus.com> has granted superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=431414 Attachment 319371: Fix memory leaks v2 https://bugzilla.mozilla.org/attachment.cgi?id=319371&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Fixes Neil's comments, carrying forward his sr. ...

superreview denied: [Bug 397832] libpkix leaks memory if a macro calls a function that returns an error : [Attachment 305807] Object leak test(patch v1)
Nelson Bolyard <nelson@bolyard.com> has denied superreview: Bug 397832: libpkix leaks memory if a macro calls a function that returns an error https://bugzilla.mozilla.org/show_bug.cgi?id=3D397832 Attachment 305807: Object leak test(patch v1) https://bugzilla.mozilla.org/attachment.cgi?id=3D305807&action=3Dedit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> 1. In source file lib/certhigh/certvfypkix.c Please move the declaration = =0D of this function:=0D =0D > extern void=0D > cert_AddToVerifyLog(CERTVerifyLog *log, CERTCertificate *...

superreview requested: [Bug 295074] POST responses remain in the memory cache when using XMLHttpRequest => huge memory leak : [Attachment 184211] v1 patch
Darin Fisher <darin@meer.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 295074: POST responses remain in the memory cache when using XMLHttpRequest => huge memory leak https://bugzilla.mozilla.org/show_bug.cgi?id=295074 Attachment 184211: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=184211&action=edit ...

superreview requested: [Bug 397832] libpkix leaks memory if a macro calls a function that returns an error : [Attachment 310353] Object leak test(patch v3)
Alexei Volkov <alexei.volkov.bugs@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 397832: libpkix leaks memory if a macro calls a function that returns an error https://bugzilla.mozilla.org/show_bug.cgi?id=397832 Attachment 310353: Object leak test(patch v3) https://bugzilla.mozilla.org/attachment.cgi?id=310353&action=edit ------- Additional Comments from Alexei Volkov <alexei.volkov.bugs@sun.com> Changes according review comments. ...

superreview requested: [Bug 397832] libpkix leaks memory if a macro calls a function that returns an error : [Attachment 310352] Object leak test(patch v2)
Alexei Volkov <alexei.volkov.bugs@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 397832: libpkix leaks memory if a macro calls a function that returns an error https://bugzilla.mozilla.org/show_bug.cgi?id=397832 Attachment 310352: Object leak test(patch v2) https://bugzilla.mozilla.org/attachment.cgi?id=310352&action=edit ------- Additional Comments from Alexei Volkov <alexei.volkov.bugs@sun.com> Changes according review comments. ...

superreview requested: [Bug 306785] memory leaks in PQG_ParamGenSeedLen : [Attachment 194622] fix for memory leaks
Julien Pierre <julien.pierre.bugs@sun.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 306785: memory leaks in PQG_ParamGenSeedLen https://bugzilla.mozilla.org/show_bug.cgi?id=306785 Attachment 194622: fix for memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=194622&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> I have tested this and verified the 2 leaks are gone. all.sh still passes. I'm not 100% sure that my change in getPQseed is correct . The code was previously freeing and re...

superreview requested: [Bug 270215] Memory leak in wallet_GetLine : [Attachment 166131] Patch v1
Philip K. Warren (IBM) <pkwarren@gmail.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 270215: Memory leak in wallet_GetLine https://bugzilla.mozilla.org/show_bug.cgi?id=270215 Attachment 166131: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=166131&action=edit ...

superreview requested: [Bug 297592] Need a JSS Selfserv test for checking memory leaks : [Attachment 189371] JSS_SelfServServer and JSS_SelfServClient program for testing memory leaks
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked glen beasley <glen.beasley@sun.com> for superreview: Bug 297592: Need a JSS Selfserv test for checking memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=297592 Attachment 189371: JSS_SelfServServer and JSS_SelfServClient program for testing memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=189371&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> JSS_SelfServServer.java and JSS_SelfServClient.java are server and client using JSS that can takein a pred...

superreview granted: [Bug 262758] live bookmarks leak memory/RDF resources : [Attachment 161801] 262758-livemark-refresh-leaks-memory-0.patch
Mike Shaver <shaver@mozilla.org> has granted vladimir@pobox.com's request for superreview: Bug 262758: live bookmarks leak memory/RDF resources https://bugzilla.mozilla.org/show_bug.cgi?id=262758 Attachment 161801: 262758-livemark-refresh-leaks-memory-0.patch https://bugzilla.mozilla.org/attachment.cgi?id=161801&action=edit ...

superreview requested: [Bug 315994] pwdecrypt crashes and leaks memory : [Attachment 202623] patch v1
Nelson Bolyard <nelson@bolyard.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 315994: pwdecrypt crashes and leaks memory https://bugzilla.mozilla.org/show_bug.cgi?id=315994 Attachment 202623: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=202623&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> Julilen and/or Bob, please review. ...

Web resources about - superreview requested: [Bug 429230] memory leak in pkix_CheckCert function : [Attachment 315876] Patch v1(remove debug code that leaks memory) - mozilla.dev.super-review

Resources last updated: 12/12/2015 3:14:57 PM