superreview requested: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac

John Daggett (:jtd) <jdaggett@mozilla.com> has asked Vladimir Vukicevic (:vlad)
<vladimir@pobox.com> for superreview:
Bug 428458: text input size="n" is too wide with monospace font
https://bugzilla.mozilla.org/show_bug.cgi?id=428458

Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font
on mac
https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit

------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com>
Based on Smokey's screenshots, setting Courier New as the default monospace
font doesn't seem like the right way to go.  Instead, on 10.4 explicitly tag
Courier and Monaco to be fixed-pitch fonts.  This appears to eliminate the
problem.

Patch also includes roc's previous Windows code change.
0
bugzilla
4/17/2008 8:25:03 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
530 Views

Similar Articles

[PageSpeed] 38

Reply:

Similar Artilces:

superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit ...

superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 315051] use ceil consistently
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 315051: use ceil consistently https://bugzilla.mozilla.org/attachment.cgi?id=315051&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Looks ok to me but really Stuart should review this ...

superreview requested: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from froodian <stridey@gmail.com> Pink, this blocks all the menu cleanup work for 1.1, so a speedy sr would be most helpful for me. :) ...

superreview granted: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink. are we sure those getter_addrefs -> dont_addrefs are correct? ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

superreview requested: [Bug 232487] Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts : [Attachment 152111] Fix duplicate line
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 232487: Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts http://bugzilla.mozilla.org/show_bug.cgi?id=232487 Attachment 152111: Fix duplicate line http://bugzilla.mozilla.org/attachment.cgi?id=152111&action=edit ...

superreview requested: [Bug 292487] Remove duplication of "font" in pref-viewing_messages.xul : [Attachment 182295] Patch v 0.1
Ian Neal <bugzilla@arlen.demon.co.uk> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 292487: Remove duplication of "font" in pref-viewing_messages.xul https://bugzilla.mozilla.org/show_bug.cgi?id=292487 Attachment 182295: Patch v 0.1 https://bugzilla.mozilla.org/attachment.cgi?id=182295&action=edit ...

superreview requested: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] Patch #2
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Alec Flett <alecf@flett.org> for superreview: Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts http://bugzilla.mozilla.org/show_bug.cgi?id=242346 Attachment 147494: Patch http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit ...

superreview requested: [Bug 418479] CG glyph rendering always anti-aliases even when system preference is to disable for font size < x : [Attachment 313541] patch, v.0.2, without cairo fixes
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 418479: CG glyph rendering always anti-aliases even when system preference is to disable for font size < x https://bugzilla.mozilla.org/show_bug.cgi?id=418479 Attachment 313541: patch, v.0.2, without cairo fixes https://bugzilla.mozilla.org/attachment.cgi?id=313541&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Tested with latest cairo changes. Note that the pref is only read at startup, probabl...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 62429] The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) : [Attachment 131996] Patch v0.6f
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 62429: The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) http://bugzilla.mozilla.org/show_bug.cgi?id=62429 Attachment 131996: Patch v0.6f http://bugzilla.mozilla.org/attachment.cgi?id=131996&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> Carrying r= forward and requesting sr ...

superreview requested: [Bug 62429] The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) : [Attachment 130529] Patch v0.6c
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 62429: The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) http://bugzilla.mozilla.org/show_bug.cgi?id=62429 Attachment 130529: Patch v0.6c http://bugzilla.mozilla.org/attachment.cgi?id=130529&action=edit ...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 292750] patch, v1.2, cmap font matching fix
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=3D396137 Attachment 292750: patch, v1.2, cmap font matching fix https://bugzilla.mozilla.org/attachment.cgi?id=3D292750&action=3Dedit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Tested patch, ready for inspection. I haven't done a lot of optimization on this yet, specifically I haven&...

Web resources about - superreview requested: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac - mozilla.dev.super-review

Resources last updated: 11/26/2015 6:14:58 AM