superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1

Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger
<cbiesinger@gmail.com> for superreview:
Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate
to it in Firefox using the file:/// URL.
https://bugzilla.mozilla.org/show_bug.cgi?id=426776

Attachment 313548: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
netwerk/base/src/nsDirectoryIndexStream.cpp:
  On MacOSX, IsFile() and IsDirectory() returns NS_ERROR_FILE_NOT_FOUND
  for symbolic links where the target does not exist.
  I'm leaving that as is, but we need to ignore the error and continue
  to the IsSymlink() test.
  A slightly stricter approach would test each 'rv' like so:
    NS_ENSURE_TRUE(NS_SUCCEEDED(rv)||rv==NS_ERROR_FILE_NOT_FOUND, rv)
  let me know if you like that better...

xpcom/io/nsLocalFileOSX.mm:
  On MacOSX, IsSymlink() currently set _retval to PR_FALSE for all
  symbolic links (even when the target exists).  Furthermore, it
  always returns NS_OK, even if the (link) file system path does
  not exist.

  I'm changing it to always set _retval to PR_TRUE for all symbolic
  links (even when the target does not exist).
  Also, return NS_ERROR_FILE_NOT_FOUND if the file system path doesn't
  exist or NS_ERROR_FAILURE if we failed to determine if it exists
  or not.
0
bugzilla
4/4/2008 6:54:48 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
584 Views

Similar Articles

[PageSpeed] 48

Reply:

Similar Artilces:

superreview canceled: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Christian :Biesinger <cbiesinger@gmail.com> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't naviga= te to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=3D426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=3D313548&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> + int err =3D lstat((char*)path, &stats);=0D =0D that cast se...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The 'cols' attribute is mapped to a 'ch' unit width. This patch implements the 'ch' unit generally for 'wid...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height&#...

superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height' and 'max...

superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> Asking for sr on this 7-char patch in case we need to take it ...

superreview requested: [Bug 299192] can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. : [Attachment 187728] patch
David Baron <dbaron@mozillafoundation.org> has asked Boris Zbarsky (No email until July) <bzbarsky@mit.edu> for superreview: Bug 299192: can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. https://bugzilla.mozilla.org/show_bug.cgi?id=299192 Attachment 187728: patch https://bugzilla.mozilla.org/attachment.cgi?id=187728&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> Yeah, I don't think this was intended. ...

superreview requested: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

superreview requested: [Bug 214551] rename 'run filters on folder' in the tools menu to 'run filters on this folder' : [Attachment 185427] Diff made with Patch Maker and 1.8b2 Gecko/20050604
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 214551: rename 'run filters on folder' in the tools menu to 'run filters on this folder' https://bugzilla.mozilla.org/show_bug.cgi?id=214551 Attachment 185427: Diff made with Patch Maker and 1.8b2 Gecko/20050604 https://bugzilla.mozilla.org/attachment.cgi?id=185427&action=edit ------- Additional Comments from zug_treno@yahoo.com This simple patch adds 'this' to three items in the Tools menu: Run Filters on this Folder, Run Junk Mail Contro...

superreview requested: [Bug 424333] crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] : [Attachment 311249] Trunk patch, rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 424333: crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] https://bugzilla.mozilla.org/show_bug.cgi?id=424333 Attachment 311249: Trunk patch, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=311249&action=edit ...

superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
David Baron <dbaron@mozilla.com> has granted superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> r+sr=dbaron. Let's do the renaming in a separate patch after this one lands. (You can if you want, or I can...) ...

superreview requested: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ...

superreview requested: [Bug 307632] Can't extend Selection Class anymore with Firefox 1.5b1 : [Attachment 195818] Use the current inner scope when wrapping natives in an outer window's scope.
Johnny Stenback <jst@mozilla.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 307632: Can't extend Selection Class anymore with Firefox 1.5b1 https://bugzilla.mozilla.org/show_bug.cgi?id=307632 Attachment 195818: Use the current inner scope when wrapping natives in an outer window's scope. https://bugzilla.mozilla.org/attachment.cgi?id=195818&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> This fixes this bug by making us always wrap all DOM things in an inner scope. We use the current inner here si...

superreview requested: [Bug 139568] ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 : [Attachment 172218] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 139568: ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 https://bugzilla.mozilla.org/show_bug.cgi?id=139568 Attachment 172218: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172218&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is the right thing to do. If this causes pageload issues, I'll remove the flush, but the assert ...

Web resources about - superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1 - mozilla.dev.super-review

Resources last updated: 1/5/2016 11:56:58 AM