superreview requested: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix

Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has asked Johnny
Stenback (:jst) <jst@mozilla.org> for superreview:
Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that
throws and syntax error in event handler
https://bugzilla.mozilla.org/show_bug.cgi?id=422009

Attachment 310421: Fix
https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit
0
bugzilla
3/19/2008 7:27:40 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
476 Views

Similar Articles

[PageSpeed] 47

Reply:

Similar Artilces:

superreview granted: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237063: Updated https://bugzilla.mozilla.org/attachment.cgi?id=237063&action=edit ...

superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237072: Maybe better https://bugzilla.mozilla.org/attachment.cgi?id=237072&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> The last patch did the wrong thing if the only object on fp->blockChain had a NULL parent. ...

superreview requested: [Bug 350268] "}" in "new Function" should cause syntax error instead of making the rest be ignored : [Attachment 235536] fix
Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 350268: "}" in "new Function" should cause syntax error instead of making the rest be ignored https://bugzilla.mozilla.org/show_bug.cgi?id=350268 Attachment 235536: fix https://bugzilla.mozilla.org/attachment.cgi?id=235536&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> The old "forgot to check for unconsumed tokens" gotcha. /be ...

superreview requested: [Bug 407019] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 : [Attachment 293779 ] Fix
Blake Kaplan <mrbkap@gmail.com> has asked Jonas Sicking (:sicking) <jonas@sicking.cc> for superreview: Bug 407019: "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 https://bugzilla.mozilla.org/show_bug.cgi?id=407019 Attachment 293779: Fix https://bugzilla.mozilla.org/attachment.cgi?id=293779&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> Sorry, I had tunnel vision when I fixed the first bug. This applies the same fix to the rest of the function. I'll attach a diff -w for easier reviewing ...

superreview requested: [Bug 336054] "Assertion failure: !OBJ_GET_PROTO(cx, ctor)" in JS_InitClass, involving Greasemonkey : [Attachment 220449] proposed fix
Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 336054: "Assertion failure: !OBJ_GET_PROTO(cx, ctor)" in JS_InitClass, involving Greasemonkey https://bugzilla.mozilla.org/show_bug.cgi?id=336054 Attachment 220449: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=220449&action=edit ...

superreview granted: [Bug 418133] [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch
Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 418133: [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> https://bugzilla.mozilla.org/show_bug.cgi?id=418133 Attachment 306201: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >+ // If EvaluateStringWithValue() threw an exception, just report it now. >+ // Failure to ...

superreview requested: [Bug 425360] Assertion failure: !cx->throwing at jsinterp.c:6201 : [Attachment 312309] Possible fix
Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 425360: Assertion failure: !cx->throwing at jsinterp.c:6201 https://bugzilla.mozilla.org/show_bug.cgi?id=425360 Attachment 312309: Possible fix https://bugzilla.mozilla.org/attachment.cgi?id=312309&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> I think that EvaluateScript should evaluate the script in a vacuum, which means no propagating exceptions out. Furthermore, SetTimeout (which is the caller here) doesn't seem to e...

superreview requested: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 344215: <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" https://bugzilla.mozilla.org/show_bug.cgi?id=344215 Attachment 229189: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229189&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Return NS_FINDBROADCASTER_NOT_FOUND when there is no/empty "element" attribute. (as we do in th...

superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated
Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237063: Updated https://bugzilla.mozilla.org/attachment.cgi?id=237063&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Need to get this into the trunk pretty quickly. /be ...

superreview requested: [Bug 406900] [FIX]"ASSERTION: Should be in an update while creating frames" with XBL, <xul:listitem> : [ Attachment 292366] Updated to smaug's comment
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has asked Jonas Sicking (:sicking) <jonas@sicking.cc> for superreview: Bug 406900: [FIX]"ASSERTION: Should be in an update while creating frames" with XBL, <xul:listitem> https://bugzilla.mozilla.org/show_bug.cgi?id=406900 Attachment 292366: Updated to smaug's comment https://bugzilla.mozilla.org/attachment.cgi?id=292366&action=edit ...

superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better
Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237072: Maybe better https://bugzilla.mozilla.org/attachment.cgi?id=237072&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Looks good to me again, but I'm not counting for much here. Igor's r+ counts....

superreview requested: [Bug 291198] "overflow" and "underflow" events are missing detail attribute : [Attachment 181327] Fix for bug
Nate Nielsen <nielsen@memberwebs.com> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 291198: "overflow" and "underflow" events are missing detail attribute https://bugzilla.mozilla.org/show_bug.cgi?id=291198 Attachment 181327: Fix for bug https://bugzilla.mozilla.org/attachment.cgi?id=181327&action=edit ...

superreview requested: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333894] Fix regression per Neil's suggestion
Kent James (:rkent) <kent@caspia.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel https://bugzilla.mozilla.org/show_bug.cgi?id=444994 Attachment 333894: Fix regression per Neil's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=333894&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> So this is what you had in mind, right? ...

Web resources about - superreview requested: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix - mozilla.dev.super-review

Resources last updated: 1/20/2016 3:46:22 AM