superreview requested: [Bug 421817] Don't use HTML5 drag-and-drop event names for non-HTML5 drag-and-drop implementation : [Attachment 309761] remove dragstart, dragleave and drop events for now, chan #2

Neil Deakin <enndeakin@gmail.com> has asked  for superreview:
Bug 421817: Don't use HTML5 drag-and-drop event names for non-HTML5
drag-and-drop implementation
https://bugzilla.mozilla.org/show_bug.cgi?id=421817

Attachment 309761: remove dragstart, dragleave and drop events for now, change
the NS_DRAGDROP_DROP constant to refer to the dragdrop event and not the drop
event.
https://bugzilla.mozilla.org/attachment.cgi?id=309761&action=edit
0
bugzilla
3/16/2008 1:58:50 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
967 Views

Similar Articles

[PageSpeed] 7

Reply:

Similar Artilces:

superreview requested: [Bug 421817] Don't use HTML5 drag-and-drop event names for non-HTML5 drag-and-drop implementation : [Attachment 309761] remove dragstart, dragleave and drop events for now, chan #3
Neil Deakin <enndeakin@gmail.com> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 421817: Don't use HTML5 drag-and-drop event names for non-HTML5 drag-and-drop implementation https://bugzilla.mozilla.org/show_bug.cgi?id=421817 Attachment 309761: remove dragstart, dragleave and drop events for now, change the NS_DRAGDROP_DROP constant to refer to the dragdrop event and not the drop event. https://bugzilla.mozilla.org/attachment.cgi?id=309761&action=edit ...

superreview granted: [Bug 421817] Don't use HTML5 drag-and-drop event names for non-HTML5 drag-and-drop implementation : [Attachment 309761] remove dragstart, dragleave and drop events for now, change
Johnny Stenback (:jst) <jst@mozilla.org> has granted Neil Deakin <enndeakin@gmail.com>'s request for superreview: Bug 421817: Don't use HTML5 drag-and-drop event names for non-HTML5 drag-and-drop implementation https://bugzilla.mozilla.org/show_bug.cgi?id=421817 Attachment 309761: remove dragstart, dragleave and drop events for now, change the NS_DRAGDROP_DROP constant to refer to the dragdrop event and not the drop event. https://bugzilla.mozilla.org/attachment.cgi?id=309761&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozill...

superreview requested: [Bug 420341] Drag and drop link/bookmark issues, regressed by bug 389931 : [Attachment 310239] (Cv1a) <bookmarksMenu.js> (Don't Close Target On Drop)
Serge Gautherie <sgautherie.bz@free.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 420341: Drag and drop link/bookmark issues, regressed by bug 389931 https://bugzilla.mozilla.org/show_bug.cgi?id=420341 Attachment 310239: (Cv1a) <bookmarksMenu.js> (Don't Close Target On Drop) https://bugzilla.mozilla.org/attachment.cgi?id=310239&action=edit ------- Additional Comments from Serge Gautherie <sgautherie.bz@free.fr> Cv1, but with an early return. ...

superreview requested: [Bug 420341] Drag and drop link/bookmark issues, regressed by bug 389931 : [Attachment 316121] (Cv1b) <bookmarksMenu.js> (Don't Close Target On Drop)
Serge Gautherie <sgautherie.bz@free.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 420341: Drag and drop link/bookmark issues, regressed by bug 389931 https://bugzilla.mozilla.org/show_bug.cgi?id=420341 Attachment 316121: (Cv1b) <bookmarksMenu.js> (Don't Close Target On Drop) https://bugzilla.mozilla.org/attachment.cgi?id=316121&action=edit ------- Additional Comments from Serge Gautherie <sgautherie.bz@free.fr> [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041602 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)...

superreview requested: [Bug 420341] Drag and drop link/bookmark issues, regressed by bug 389931 : [Attachment 310143] (Cv1) <bookmarksMenu.js> (Don't Close Target On Drop)
Serge Gautherie <sgautherie.bz@free.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 420341: Drag and drop link/bookmark issues, regressed by bug 389931 https://bugzilla.mozilla.org/show_bug.cgi?id=420341 Attachment 310143: (Cv1) <bookmarksMenu.js> (Don't Close Target On Drop) https://bugzilla.mozilla.org/attachment.cgi?id=310143&action=edit ------- Additional Comments from Serge Gautherie <sgautherie.bz@free.fr> [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b5pre) Gecko/2008031700 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4...

superreview requested: [Bug 338772] Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped : [Attachment 233429] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 338772: Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped https://bugzilla.mozilla.org/show_bug.cgi?id=338772 Attachment 233429: patch https://bugzilla.mozilla.org/attachment.cgi?id=233429&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Inlining this into the existing return would make it ridiculously long. ...

superreview requested: [Bug 307086] Recent OS/2 trunk builds: drag and drop does not work : [Attachment 195248] patch to fix drag & drop on OS/2
Rich Walsh <dragtext@e-vertise.com> has asked Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> for superreview: Bug 307086: Recent OS/2 trunk builds: drag and drop does not work https://bugzilla.mozilla.org/show_bug.cgi?id=307086 Attachment 195248: patch to fix drag & drop on OS/2 https://bugzilla.mozilla.org/attachment.cgi?id=195248&action=edit ...

superreview granted: [Bug 420341] Drag and drop link/bookmark issues, regressed by bug 389931 : [Attachment 316121] (Cv1b) <bookmarksMenu.js> (Don't Close Target On Drop)
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge Gautherie <sgautherie.bz@free.fr>'s request for superreview: Bug 420341: Drag and drop link/bookmark issues, regressed by bug 389931 https://bugzilla.mozilla.org/show_bug.cgi?id=420341 Attachment 316121: (Cv1b) <bookmarksMenu.js> (Don't Close Target On Drop) https://bugzilla.mozilla.org/attachment.cgi?id=316121&action=edit ...

superreview canceled: [Bug 420341] Drag and drop link/bookmark issues, regressed by bug 389931 : [Attachment 310143] (Cv1) <bookmarksMenu.js> (Don't Close Target On Drop)
Serge Gautherie <sgautherie.bz@free.fr> has canceled Serge Gautherie <sgautherie.bz@free.fr>'s request for superreview: Bug 420341: Drag and drop link/bookmark issues, regressed by bug 389931 https://bugzilla.mozilla.org/show_bug.cgi?id=420341 Attachment 310143: (Cv1) <bookmarksMenu.js> (Don't Close Target On Drop) https://bugzilla.mozilla.org/attachment.cgi?id=310143&action=edit ------- Additional Comments from Serge Gautherie <sgautherie.bz@free.fr> Cv1, but with an early return. ...

superreview granted: [Bug 420341] Drag and drop link/bookmark issues, regressed by bug 389931 : [Attachment 310239] (Cv1a) <bookmarksMenu.js> (Don't Close Target On Drop)
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge Gautherie <sgautherie.bz@free.fr>'s request for superreview: Bug 420341: Drag and drop link/bookmark issues, regressed by bug 389931 https://bugzilla.mozilla.org/show_bug.cgi?id=420341 Attachment 310239: (Cv1a) <bookmarksMenu.js> (Don't Close Target On Drop) https://bugzilla.mozilla.org/attachment.cgi?id=310239&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ dontCloseTargetOnDrop : false, I think this would be better named mDidDrop. sr=me with this fix...

superreview canceled: [Bug 337761] Bookmarks / personal toolbar folder doesn't open for dragged link : [Attachment 298333] drag and drop event patch v.1
Jim Mathies <jmathies@mozilla.com> has canceled Jim Mathies <jmathies@mozilla.com>'s request for superreview: Bug 337761: Bookmarks / personal toolbar folder doesn't open for dragged link https://bugzilla.mozilla.org/show_bug.cgi?id=337761 Attachment 298333: drag and drop event patch v.1 https://bugzilla.mozilla.org/attachment.cgi?id=298333&action=edit ...

superreview granted: [Bug 338772] Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped : [Attachment 233429] patch
jag (Peter Annema) <jag@tty.nl> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 338772: Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped https://bugzilla.mozilla.org/show_bug.cgi?id=338772 Attachment 233429: patch https://bugzilla.mozilla.org/attachment.cgi?id=233429&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Instead of that comment you could move the second part to a |acceptsBookmarks(aTarget)| function which o...

superreview requested: [Bug 162791] PATCH: URL bar accepts Drag & Drop of strings/URLs : [Attachment 122076] doesn't load URL on drop
Simon Woodside <sbwoodside@yahoo.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 162791: PATCH: URL bar accepts Drag & Drop of strings/URLs http://bugzilla.mozilla.org/show_bug.cgi?id=162791 Attachment 122076: doesn't load URL on drop http://bugzilla.mozilla.org/attachment.cgi?id=122076&action=edit ------- Additional Comments from Simon Woodside <sbwoodside@yahoo.com> r+ ...

superreview requested: [Bug 428096] Clipboard and drag-and-drop don't interoperate with HTML on OS X : [Attachment 332415] Fixes a bug in the patch that caused it to not compile.
Josh Aas <joshmoz@gmail.com> has asked Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> for superreview: Bug 428096: Clipboard and drag-and-drop don't interoperate with HTML on OS X https://bugzilla.mozilla.org/show_bug.cgi?id=428096 Attachment 332415: Fixes a bug in the patch that caused it to not compile. https://bugzilla.mozilla.org/attachment.cgi?id=332415&action=edit ...

Web resources about - superreview requested: [Bug 421817] Don't use HTML5 drag-and-drop event names for non-HTML5 drag-and-drop implementation : [Attachment 309761] remove dragstart, dragleave and drop events for now, chan #2 - mozilla.dev.super-review

Resources last updated: 12/3/2015 11:19:09 PM